Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210823061938.28240-1-l4stpr0gr4m@gmail.com> <13c1df91-be22-f4e0-cd61-7c99eb4e45f4@nvidia.com>
In-Reply-To: <13c1df91-be22-f4e0-cd61-7c99eb4e45f4@nvidia.com>
From:   Kangmin Park <l4stpr0gr4m@gmail.com>
Date:   Mon, 23 Aug 2021 18:12:31 +0900
Message-ID: <CAKW4uUyPdQ9hXeyjnC+5VS7zDaw+3sxy53HwOv2AxEZ7tngT=Q@mail.gmail.com>
Subject: Re: [PATCH net-next] net: bridge: replace __vlan_hwaccel_put_tag with skb_vlan_push
To:     Nikolay Aleksandrov <nikolay@nvidia.com>
Cc:     Roopa Prabhu <roopa@nvidia.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2021=EB=85=84 8=EC=9B=94 23=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 6:00, N=
ikolay Aleksandrov <nikolay@nvidia.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=
=B1:
>
> On 23/08/2021 09:19, Kangmin Park wrote:
>
> This changes behaviour though, I don't like changing code just for the sa=
ke of it.
> Perhaps the author had a reason to use hwaccel_put_tag instead. Before we=
 would
> just put hwaccel tag, now if there already is hwaccel tag we'll push it i=
nside
> the skb and then push the new tag in hwaccel. In fact I think you can eve=
n trigger
> the warning inside skb_vlan_push, so:
>
> Nacked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
>
>

Thanks for the review. I got it.
Then, how about cleanup by changing return type of
br_handle_ingress_vlan_tunnel()?
This function is only referenced in br_handle_frame(), and goto drop
when it return
non-zero. But, the ingress function always return 0, there is no
meaning for now.
If you think the cleanup is worth it, I'll send you a v2 patch.

Regards.