Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1695837pxb; Mon, 23 Aug 2021 02:18:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQe14TKjnu6gOl2KuYOHyuOFe/74MpR5mY+YkUEamDi3zuL4JpLgjpDSD4Qe7BbWr1XW0N X-Received: by 2002:a17:907:76e5:: with SMTP id kg5mr14485976ejc.474.1629710326493; Mon, 23 Aug 2021 02:18:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629710326; cv=none; d=google.com; s=arc-20160816; b=AF5xG+9oucfBIRL/5MIh/dIdHj/8Ci43CCoSLe2wPgdxS7XyFB8TrqsI0rXf7rtqy3 HpsqUS/VK1ruu3JZFfv/tjB7c02QA24mJGGeBsR4wHqQADYcYRSGDIdmHY7exct1wIU8 XmUJTJVtKf5kUEX13LA7CzWNkDJHGZKMI7OgBKWYqv1rOev83YBSb553OHCWOGwtHO5j ZYAzBsHOW+f851WcbC7uvY93Vl9f6x0q3Q66FNa99/VJM80gAoxsmmXuDWPY9x0u6nUQ OrmjUCcP0gCTpNmqofJjb1aGjbBL35NOgKxD4dqAOUScNGHiAuZ7sGbTh3v6oICF90i4 AqhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=9QLjRZu+Qt7qgSvBEQ/53pbQu1xoAU50oF0hD2z0Qgk=; b=F0K8p2OknkkvsOG5hVYB41Bg+lI2Am97DH8rGc0WqB3nK0RRtbOLuyvETZ/KzJoufD 32I1hn/UAQcUbfzV5O/UCjkoxKSwBCuE0gIc32ypBkbjB+Uqpp+pd04OVg1Z6BlNszaJ 6K+02yTEY81/n2zISLfHrOxSk8gX/BScnaWXElfOtt3DrhQh4sOe7tSjfWvlZs2/CKDe dCEXMPEIwVCbSHBuFUSYak+TLZiMyrxI7hd4KjwZrFznPKUzthmoc03MrbNq8aSmOen6 eOOPBjnytXf01M8cQRRX0BT7Eb7rAkH6C9ZmI0S3CSbYBeo10zbRKJ+TrKVyRzMgS51N ycAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g23si9546132edp.82.2021.08.23.02.18.23; Mon, 23 Aug 2021 02:18:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235699AbhHWJRw (ORCPT + 99 others); Mon, 23 Aug 2021 05:17:52 -0400 Received: from mail-ua1-f45.google.com ([209.85.222.45]:39666 "EHLO mail-ua1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235681AbhHWJRv (ORCPT ); Mon, 23 Aug 2021 05:17:51 -0400 Received: by mail-ua1-f45.google.com with SMTP id a4so7606455uae.6; Mon, 23 Aug 2021 02:17:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9QLjRZu+Qt7qgSvBEQ/53pbQu1xoAU50oF0hD2z0Qgk=; b=dXNDm2dOIspLVSKshmZAcZWzK76K1wAR0YK+SGgew2NlyOUUeIRlVr5tb9noV3ZO6W GEfxgzaksOIGC7dtjNpW5uFuCEiGCPBQdhSNPsOZMbA9S58sB2bhQ/K5UTXbsf/WU8l1 bCuFYV7jLTwBd6qmVlgYS08wk9a1JpPAm6r8WJ7NUiwaa6as7MulnpbH0S5j3yOAee4n AONWKS5m5OAaC8ReC99TjOieqH9Dp7yMDO45tVK3nHKkI99MJYZsPOf5QdF71E/SaQdV XTLUBayFdnWoCnY1poOrk4+86bWV1WUsvgzld7K8GHJHGuieLesgx5sClvPcmG40SHmE 2B7w== X-Gm-Message-State: AOAM5320adD/AhkCHQBKpGh4az9GMUWGcKtKdhq6TQCzEbomie/C+Wqz Ysisaj5uyaOuy32mS5ARVAnk2FtvSZkkuHE9tlQLUcDD X-Received: by 2002:ab0:545:: with SMTP id 63mr21148288uax.122.1629710228796; Mon, 23 Aug 2021 02:17:08 -0700 (PDT) MIME-Version: 1.0 References: <20210816162201.28801-1-uli+renesas@fpond.eu> In-Reply-To: <20210816162201.28801-1-uli+renesas@fpond.eu> From: Geert Uytterhoeven Date: Mon, 23 Aug 2021 11:16:57 +0200 Message-ID: Subject: Re: [PATCH] serial: sh-sci: fix break handling for sysrq To: Ulrich Hecht Cc: Linux-Renesas , "open list:SERIAL DRIVERS" , Wolfram Sang , Yoshihiro Shimoda , Greg KH , Jiri Slaby , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 16, 2021 at 6:22 PM Ulrich Hecht wrote: > This fixes two issues that cause the sysrq sequence to be inadvertently > aborted on SCIF serial consoles: > > - a NUL character remains in the RX queue after a break has been detected, > which is then passed on to uart_handle_sysrq_char() > - the break interrupt is handled twice on controllers with multiplexed ERI > and BRI interrupts > > Signed-off-by: Ulrich Hecht FTR: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds