Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] media: camss: vfe: Don't call hw_version() before
 its dependencies are met
From:   Marek Szyprowski <m.szyprowski@samsung.com>
To:     Robert Foss <robert.foss@linaro.org>, todor.too@gmail.com,
        agross@kernel.org, bjorn.andersson@linaro.org, mchehab@kernel.org,
        hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Naresh Kamboju <naresh.kamboju@linaro.org>
Cc:     Linux Kernel Functional Testing <lkft@linaro.org>
Message-ID: <e0f79e99-61b1-b98e-e7c5-0fc9c1f0b943@samsung.com>
Date:   Mon, 23 Aug 2021 12:10:19 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0)
        Gecko/20100101 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <4f2e8d19-8c89-53d4-37d3-97dead170065@samsung.com>
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20210812092201eucas1p1ba2165a230084f99e3a858827788cf54@eucas1p1.samsung.com>
        <20210812092152.726874-1-robert.foss@linaro.org>
        <4f2e8d19-8c89-53d4-37d3-97dead170065@samsung.com>
Precedence: bulk

On 12.08.2021 12:16, Marek Szyprowski wrote:
> On 12.08.2021 11:21, Robert Foss wrote:
>> vfe->ops->hw_version(vfe) is being called before vfe->base has been
>> assigned, and before the hardware has been powered up.
>>
>> Fixes: b10b5334528a9 ("media: camss: vfe: Don't read hardware version 
>> needlessly")
>>
>> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

This restores old, well tested code path.

Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>

>> ---
>>   drivers/media/platform/qcom/camss/camss-vfe.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c 
>> b/drivers/media/platform/qcom/camss/camss-vfe.c
>> index 6b2f33fc9be2..71f78b40e7f5 100644
>> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
>> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
>> @@ -604,6 +604,8 @@ static int vfe_get(struct vfe_device *vfe)
>>           vfe_reset_output_maps(vfe);
>>             vfe_init_outputs(vfe);
>> +
>> +        vfe->ops->hw_version(vfe);
>>       } else {
>>           ret = vfe_check_clock_rates(vfe);
>>           if (ret < 0)
>> @@ -1299,7 +1301,6 @@ int msm_vfe_subdev_init(struct camss *camss, 
>> struct vfe_device *vfe,
>>           return -EINVAL;
>>       }
>>       vfe->ops->subdev_init(dev, vfe);
>> -    vfe->ops->hw_version(vfe);
>>         /* Memory */
>
> Best regards

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland