Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1733645pxb; Mon, 23 Aug 2021 03:21:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLRANninhCRO/dbzCQt/e/QEpF3nox8JHlidCJ2qQweBHzHii/z3T3uzKV/SsLJVzXaxAu X-Received: by 2002:a05:6402:2794:: with SMTP id b20mr37760153ede.126.1629714075289; Mon, 23 Aug 2021 03:21:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629714075; cv=none; d=google.com; s=arc-20160816; b=bkl0F2DfrX5PG6BQ8A9LGRFuLwgKXhFSPXJGLHvxX/oQbuI18YTfJnyDnLdieKtQha jmtkxgxMcxZJXPTA1JkKSPW4Ap/fDrs+Anw7qEe7ib3ocw2JbWSIFjkeC3KUfbavyV6M MS0zKzQC6kpFHbAm3nA/bghIYbjxESVd79GRtQMqwwoe1mcnHJqLCUVX+TZL97xLVyKL q0KoVBoLQs5q/jSjlts6gIjg72tKdB68/6QVSO+t1vUSx6Coot288Qbt7N8q/l9CwzQb ldVW3NhhKK6TTINX3QzHfGQ8RPghjm3+UNNFXZpVXo2nCt7KvsWpmo3Tz/qud1DQqN4/ 4usA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=K6yDnLSIpYXYrIIISakMJ/pbasH+mpQMUOZLV1Lnsw4=; b=khSHCEaEDx5BBiKiy9cuOg9CovbMRVSfPKVjJY1iFO0bjrIh+f+ZnWzpRZ193IRXMT 8jr3v2SeCY+EKHbNC30GDDG6etCl6AW0Wkk10E/3tINhU17UMSKO4Fa3QQIrONcglGdY iJSxX7lKdPcuDV12YbxQTiCg9GMXmIaGHlHA7XT8a6SR2kkviieEGb+VijL0+QaNVC5G aDTzye10ejuIdMaTHb6tthZaAJWnXtD8f64y3n02ygQyQxq39nDx+z7oi8bVCEwqjGo6 W6l1H7skeRtpgHpx64Ei656NRVLMkF6lTjKZsnBJCWaYe9pwrpjcUinD7F3mlKQ3elK8 EvgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lj74Y5KP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lc15si7772683ejb.662.2021.08.23.03.20.51; Mon, 23 Aug 2021 03:21:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lj74Y5KP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236034AbhHWKUH (ORCPT + 99 others); Mon, 23 Aug 2021 06:20:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232421AbhHWKUG (ORCPT ); Mon, 23 Aug 2021 06:20:06 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66C36C061575; Mon, 23 Aug 2021 03:19:24 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id h13so25539008wrp.1; Mon, 23 Aug 2021 03:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=K6yDnLSIpYXYrIIISakMJ/pbasH+mpQMUOZLV1Lnsw4=; b=lj74Y5KPbqoe4ZwuOwXT8BOYIaKVexQv88j394iBmoyUjC9FRzDDJOuhly4WsEedI+ KAWQtKN5wvb7kKJO160V9YfVHt9CTBc/KoBxtDbpHSytBFby5ejcjE0osDWpCyRoWMpc MBHyu9fPRo+XtXWl1dSatYLGZ8RMF62QjgVMHrIStqHUWDrnlX0VvCi1uhNDGAzQyabZ yjok/IUOg51xwAfaCi2MrWPwLgkAW5jHVYBRBiNQDIHmvyKNNrQnPjAicbUGUv9B5Ytl /O6xg3K2WsIFrMfgWFpYgauxc5EAQMiarGGE3539miFGNSJwKi17i+xPrsOePrXteTa9 NwjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=K6yDnLSIpYXYrIIISakMJ/pbasH+mpQMUOZLV1Lnsw4=; b=qMXaHs2HVM1arWV1NCQ+bxI0VQdz/ileuAXOXJwzfL5OmYIF2iK9vWclwti6scyo2l fODejdTlqwzb7dhomdTUzvCNG5GOlZSHCBdOMF2UqiuAuYiAAPSSxoja9+uWosDqjQXx Ej4zFo6uyB2GjJbtF2LTE7goubJCYH/ITU31+nI66KEL7LZfjcpcP7O2PY2Z2lKgQV+1 Hs07jNLePGQaaA45TZnt2aQzoTjFDu0njzgNXBWTx+TxPQ7tN6+927rZoZXz2rbGnzGk GPvHcoFonL6q7R0U4cBzYS/0169+dQGe6WboG3/AnNOPicGaR8KA2Ccv2aEHXI60EZs4 o3dw== X-Gm-Message-State: AOAM533/es4TR+8GRHg+9fLaHGRX/4PqA32mpbjK/e7Gooy1x2XNF29E 5XuOW0PV/gz+dn7PQyWZ1vczHMApDfU= X-Received: by 2002:adf:ab0e:: with SMTP id q14mr12875791wrc.171.1629713963063; Mon, 23 Aug 2021 03:19:23 -0700 (PDT) Received: from localhost.localdomain ([85.255.233.176]) by smtp.gmail.com with ESMTPSA id l18sm20539922wmc.30.2021.08.23.03.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 03:19:22 -0700 (PDT) From: Pavel Begunkov To: Jens Axboe , io-uring@vger.kernel.org, Alexander Viro , linux-fsdevel Cc: Palash Oswal , Sudip Mukherjee , linux-kernel@vger.kernel.org, syzbot+9671693590ef5aad8953@syzkaller.appspotmail.com, asml.silence@gmail.com Subject: [PATCH v3 0/2] iter revert problems Date: Mon, 23 Aug 2021 11:18:43 +0100 Message-Id: X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org iov_iter_revert() doesn't go well with iov_iter_truncate() in all cases, see 2/2 for the bug description. As mentioned there the current problems is because of generic_write_checks(), but there was also a similar case fixed in 5.12, which should have been triggerable by normal write(2)/read(2) and others. It may be better to enforce reexpands as a long term solution, but for now this patchset is quickier and easier to backport. v2: don't fail if it was justly fully reverted v3: use truncated size + reexapand based approach Pavel Begunkov (2): iov_iter: track truncated size io_uring: reexpand under-reexpanded iters fs/io_uring.c | 2 ++ include/linux/uio.h | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) -- 2.32.0