Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 net-next] net: bridge: change return type of
 br_handle_ingress_vlan_tunnel
To:     Kangmin Park <l4stpr0gr4m@gmail.com>,
        Roopa Prabhu <roopa@nvidia.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210823102118.17966-1-l4stpr0gr4m@gmail.com>
From:   Nikolay Aleksandrov <nikolay@nvidia.com>
Message-ID: <d37ff915-6d94-2d22-9e93-46b374fc47d7@nvidia.com>
Date:   Mon, 23 Aug 2021 13:25:20 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <20210823102118.17966-1-l4stpr0gr4m@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.21.240.23] (213.179.129.39) by ZR0P278CA0117.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Mon, 23 Aug 2021 10:25:26 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ab3705c0-6a9f-4e5c-9975-08d96620539f
X-MS-TrafficTypeDiagnostic: DM4PR12MB5102:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM4PR12MB5102952185302856693EC378DFC49@DM4PR12MB5102.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:529;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +VpTPPpiAbYT6scpzVU3SaYagDAKNzq2TxE0VwMYvCqw7KKUsUdhhk88PHmpG9jU9FTptivqRa/09O6ZiBLmEeVa/H7jasFtxSmHhfVPEhtTjb6UM8CNse2Fk/7HcGpuyRAMeBQVEyYTgjEX8sKX8Np1eFoRxWTTaN5Ev8uQfOQDsqzPJjqfMtxD3IoDtVd7SEN/e7CDAYsPErFtEFRnjidD/oYgIX00GJGKF0yicKWPa/OYcZ+fCy+RSrOQe6JQPMoccD0btMkDxpbBX3VfSCUvDWNpn6Ho90xBMZiICbrxkm0hx59rRHMgoChocC4AqkeWder1fVBKD00KUnOg/gsjV0QlNhPA1hMfcve9ASBMCdje8Rg/Nw0mky9meQbrQDsY217oeMFqe21hdQl/IX6X260e6HA9y0pj5SC8HQ2Ctr0xHHDwfKnfwxJAfTS4sEO1anbkvO8iZorUdGDa3PVjGMwlum+2ME50x1badK3F5/6IoDy6hHw21ghOiqR9wiKJ/I4uWqf9pDBaBr4hpxajZB+agcgPlDjhEOLpAgiZ55Sda7b9tt5ti9ZQfQDcdfriZgpYdDAQMmnuKtpr48FhZDZq6RStFPJnDD1/hLeqmPB7o26BWdgJBdpnov9KHKNiiw4EhhYFs6vRAvLYy7gSMVpMAHmyUAT0IbRahH3AZKrRyGhvf1mAauO1zPE3hx6nx2NTFL6EZtLFd9k2+/YGQVavvnz0RLH1YJm42N4=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5278.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(31686004)(36756003)(2616005)(66476007)(66556008)(6486002)(4326008)(956004)(66946007)(6666004)(2906002)(186003)(86362001)(110136005)(53546011)(8936002)(38100700002)(54906003)(508600001)(16576012)(31696002)(83380400001)(5660300002)(8676002)(316002)(6636002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0M2L09nN2pvUWkxSFU1ajF1dEVxVmNNaC8xOTh0ZGJYcWI0K2pzZk5SZmo1?=
 =?utf-8?B?TytlNEZPVnJFbU84eFBacThOWlZpeVpLNFlUaVlWdVRLMjNucXUyNEtLN2xK?=
 =?utf-8?B?MXpZRm1qdFQ3bWdkRG8zRU1VR3cxYTR4K3hudDVNdW43eHZYeDhtcXFKRzZQ?=
 =?utf-8?B?UlVBdUluZTRxR2ZKTDNpME5GeFVlZThkQkpiMzQ0U3lJa3k1QjFsdzIrUUhy?=
 =?utf-8?B?bGExR0t3ei9USC9KekFEYXBINHlSMTNDOE1YQkVyM01JbW5SZlVEYU13VFdT?=
 =?utf-8?B?WmpxRFFkakdjTXpjcWJReGhRQTY0cDNjZ1U1bEdGa0VsejdObFpBQW10TjdM?=
 =?utf-8?B?Ym9IZytFajJnMEhsbTZGdGNSOC9UN3ByLzVXd3BoeHFrVTltblYvNjZjaGZ2?=
 =?utf-8?B?SDhmSm5Fd2hWUVpSR3o0Qy9oamtmMjFKeWhQQ25ldjE0NG9jV0E2NGVkWU51?=
 =?utf-8?B?bzJxRzBtRzNoSFZraDl6VTZhK1pFVTJDazdBM21KckRsZUtxMlJPdFRiWVk1?=
 =?utf-8?B?MVJTWWJyYTdPMUtNMzlycU9NVE54Q2w0K3JNbGtkUjl6MFJTbXFSM3EwN2Jn?=
 =?utf-8?B?emdVS2EyQTZtOHYvbGRvRFRySXNqU1BIVDdRZ2tldkg5dGE3dWZaam1JMUlC?=
 =?utf-8?B?NWYwOTJYaTZsZTBBT0NNUWgvZnZjY3pnOStxNXRTSTRMSDlsenBaR1hLekpj?=
 =?utf-8?B?eUxJMFFOS3JjOU5OUERmeXpHU0VtdWh5dnpnM3pLeFhhVHF4VGFxei9hQXNI?=
 =?utf-8?B?cHI5V2lpNGozWkJieW82TFduUlA0YlF0WTY0YjFhdTF1SDNDdTE0MlBrOTJM?=
 =?utf-8?B?VDZNeVZETCtSa2owdjFHM3hLQ2h3YXlOVXNMT0Nzakt1NExoc2liOGFTSEMw?=
 =?utf-8?B?VFEyRWxXTzhFNDUzekRybDRwVEV3dDRMSW03aUVtcVFHZHA1eE5ranZ2anBH?=
 =?utf-8?B?QktId3N4anhtei9MUE5uQWxVRWpZWUlMOHV6SFljSFBKRDF4a05JcHVPUzFk?=
 =?utf-8?B?Njc2eTJkUGM2SGdIcW5tWVdPYU5scldpdXhYL0s2bkFiVWUzUis2WDdLMERK?=
 =?utf-8?B?YWRyNGF0QzY5S0lrVHg1emRLTjdGWWN5WHE0VU9YZjlob0dSSUlzRXRYUThZ?=
 =?utf-8?B?b1lZVUdUVUxIZXF0MkFHY3ZFL3NaQ29LOWI1b2ozeDYzMTRCSjFTY3ByZnpq?=
 =?utf-8?B?U2o2RVdVYlRKSFg4Q3JIelprNmF3cVRic2k4ZUdhUmpWZGdwR25GOG01eHVt?=
 =?utf-8?B?NjBkWjdyb0lTMk1mQXVxcU1nSXV1OUpnd0phUkpTN1lWSGlWR2ZlaExkVkFy?=
 =?utf-8?B?K3pWMHdFSzRaTWYwMkphSFF2RXNkcVEvQUMybHEzd09rUE5HYjMyMUdIeWZW?=
 =?utf-8?B?cm9vaktYTFA3UUlpbHZpem44eTNxZlBOYk5sTkN4N0FNaHNWL3VId2tSL3JJ?=
 =?utf-8?B?K2pDQWZNekkvTHFBV2t3VmVWTm9KckxuQ0lIWHQ4ZWdJTktXVWpzSEFzQzJs?=
 =?utf-8?B?TllxRXBCbXBiNk9GcWRVYWhDaHF1ZituUkh5MGZ2dGFPOGNSV0Uxck1YN3Zy?=
 =?utf-8?B?bzFpcGswU2tqcVdUajgyaDN3ci9BKzJMQnRCZldCeTV1MXF4SVRZRHVWbkRC?=
 =?utf-8?B?ODYzQ3B2QWFSaS9vMXhrT2k3dnluMURjZ0FSc3dnSGhSa1J6dm4zZncvSkhI?=
 =?utf-8?B?U2FKN3N4TGl1dnhJbVVUK1FDK1dZeDlMdStCNmxFY2xKYkJKMXFyNXg1dmVL?=
 =?utf-8?Q?9YjI3rAK+n6wqerzXkgBKHwej10+IQ11M7MPEkn?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab3705c0-6a9f-4e5c-9975-08d96620539f
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5278.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2021 10:25:28.0259
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DZB1an+4d7uEIQwjfoAuYARvQAoqDkFkgnVzN4yGsL9o1PRznh0aDFcb7C3GgmcGhvZ6g8SPy7zkymW1UKQdEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5102
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 23/08/2021 13:21, Kangmin Park wrote:
> br_handle_ingress_vlan_tunnel() is only referenced in
> br_handle_frame(). If br_handle_ingress_vlan_tunnel() is called and
> return non-zero value, goto drop in br_handle_frame().
> 
> But, br_handle_ingress_vlan_tunnel() always return 0. So, the
> routines that check the return value and goto drop has no meaning.
> 
> Therefore, change return type of br_handle_ingress_vlan_tunnel() to
> void and remove if statement of br_handle_frame().
> 
> Signed-off-by: Kangmin Park <l4stpr0gr4m@gmail.com>
> ---
> v3:
>  - remove unnecessary return statement
> 
> v2:
>  - cleanup instead of modifying ingress function
>  - change prototype of ingress function
>  - cleanup br_handle_frame function
>  - change commit message accordingly
> 
>  net/bridge/br_input.c          |  7 ++-----
>  net/bridge/br_private_tunnel.h |  6 +++---
>  net/bridge/br_vlan_tunnel.c    | 14 ++++++--------
>  3 files changed, 11 insertions(+), 16 deletions(-)
> 

Looks good to me,
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>