Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH rdma-next v3 2/3] lib/scatterlist: Fix wrong update of
 orig_nents
To:     Jason Gunthorpe <jgg@nvidia.com>, Leon Romanovsky <leon@kernel.org>
CC:     Doug Ledford <dledford@redhat.com>,
        Christoph Hellwig <hch@infradead.org>,
        Ariel Elior <aelior@marvell.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        "David Airlie" <airlied@linux.ie>,
        Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        <dri-devel@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
        "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Michal Kalderon <mkalderon@marvell.com>,
        "Mike Marciniszyn" <mike.marciniszyn@cornelisnetworks.com>,
        Mustafa Ismail <mustafa.ismail@intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        "Roland Scheidegger" <sroland@vmware.com>,
        Shiraz Saleem <shiraz.saleem@intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        VMware Graphics <linux-graphics-maintainer@vmware.com>,
        Weihang Li <liweihang@huawei.com>,
        Wenpeng Liang <liangwenpeng@huawei.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Zack Rusin <zackr@vmware.com>,
        Zhu Yanjun <zyjzyj2000@gmail.com>
References: <cover.1627551226.git.leonro@nvidia.com>
 <460ae18dd1bbd6c1175e75f5d4e51ddb449acf8d.1627551226.git.leonro@nvidia.com>
 <20210820155425.GA530861@nvidia.com>
From:   Maor Gottlieb <maorg@nvidia.com>
Message-ID: <85542c97-c7e0-3db3-baa8-2413c00f75a4@nvidia.com>
Date:   Mon, 23 Aug 2021 14:09:37 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20210820155425.GA530861@nvidia.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2021 11:09:47.6425
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fef27b1-3c4f-482c-3ebd-08d966268521
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT063.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4224
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/20/2021 6:54 PM, Jason Gunthorpe wrote:
> On Thu, Jul 29, 2021 at 12:39:12PM +0300, Leon Romanovsky wrote:
>
>> +/**
>> + * __sg_free_table - Free a previously mapped sg table
>> + * @table:	The sg table header to use
>> + * @max_ents:	The maximum number of entries per single scatterlist
>> + * @total_ents:	The total number of entries in the table
>> + * @nents_first_chunk: Number of entries int the (preallocated) first
>> + *                     scatterlist chunk, 0 means no such preallocated
>> + *                     first chunk
>> + * @free_fn:	Free function
>> + *
>> + *  Description:
>> + *    Free an sg table previously allocated and setup with
>> + *    __sg_alloc_table().  The @max_ents value must be identical to
>> + *    that previously used with __sg_alloc_table().
>> + *
>> + **/
>> +void __sg_free_table(struct sg_table *table, unsigned int max_ents,
>> +		     unsigned int nents_first_chunk, sg_free_fn *free_fn)
>> +{
>> +	sg_free_table_entries(table, max_ents, nents_first_chunk, free_fn,
>> +			      table->orig_nents);
>> +}
>>   EXPORT_SYMBOL(__sg_free_table);
> This is getting a bit indirect, there is only one caller of
> __sg_free_table() in sg_pool.c, so may as well just export
> sg_free_table_entries have have it use that directly.
>
> Jason

So I can just extend __sg_free_table to get number of entries. What do 
you think?