Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1778905pxb; Mon, 23 Aug 2021 04:34:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynjtr3Bh40+tbNCYOZRcFPcwi+1VmdzxucsR0nDkOYybOBAKh+dW6RLt0cj1gFfYcoaley X-Received: by 2002:a5d:974f:: with SMTP id c15mr25252276ioo.190.1629718455306; Mon, 23 Aug 2021 04:34:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629718455; cv=none; d=google.com; s=arc-20160816; b=cqSo2hNFGdtJ2iWylap5snHfXP8i6EsQ9BCDugEGxO16keoaBZgCsZMDa/Z+Z0I9BV mjT9l0aFnRIkR+pzcCqOvcE/2dWE/kHBs8rSOUuroYzzBVj2dXguYcIXVjaK234dIPeY x15bCgcb9Vz1+xcLlvcWNXuf6DE9qZ83W5PqDOea9gWqoXzMiWJ6BLODt2u8uuGjLZPV /OZGvKNsgr7K+qJ+Mg1GWhjto6b6XcaJLl3PkShi4fXSgy1lfxjEpDlUyhAxx2llKbYQ 0JD5KHQI6sq2vlkij6KcPPKazuQDqXNBsJpDiKedl55LOcz+oSm+xcFUGUuLicC3jkMV gdaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=bp/7BZts99wmfwuACrg+kj4hF5QuWdYC9eC4oGj3mHs=; b=FS8TbcpWX/dDCcJeo8x5Aj2yDd2PME8s/4+7ckJSYz0DKhzBytRVKSFvqsrFgmxEEd bnK0n1s77kVw1B7gc9vkUtrA9GhN2BpSRWn4V98DfQxpwpsd7XGL+X7yQFX3oKdb5C59 JUuwPsXlFB52DDi+j1qJALb0oyiEBoSuVYLigaxrvRBl+g+Sly3KMErbgPeX6SWmnqS/ sOTWKeAqFefROmGl4+EL4jcfEYPk2rL9a8Eapu24T7zSx8QPOEsaM4KlMXV21MGLNshV 8b6JAzQFcHF+5EcK+xdWMSw5+quZZ0nBh6CgZqZvnBWc6dAlcUb1lN2Rd5ok4MYgJfx2 Fmag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n13si14404238ili.37.2021.08.23.04.34.03; Mon, 23 Aug 2021 04:34:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236559AbhHWLeB (ORCPT + 99 others); Mon, 23 Aug 2021 07:34:01 -0400 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:25933 "EHLO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236447AbhHWLd6 (ORCPT ); Mon, 23 Aug 2021 07:33:58 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.3]) by rmmx-syy-dmz-app08-12008 (RichMail) with SMTP id 2ee86123876ccd8-049f5; Mon, 23 Aug 2021 19:33:02 +0800 (CST) X-RM-TRANSID: 2ee86123876ccd8-049f5 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[223.112.105.130]) by rmsmtp-syy-appsvr02-12002 (RichMail) with SMTP id 2ee261238767421-c70cc; Mon, 23 Aug 2021 19:33:02 +0800 (CST) X-RM-TRANSID: 2ee261238767421-c70cc From: Tang Bin To: davem@davemloft.net, wg@grandegger.com, mkl@pengutronix.de, kuba@kernel.org, kevinbrace@bracecomputerlab.com, romieu@fr.zoreil.com Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Bin Subject: [PATCH 1/3] via-rhine: Use of_device_get_match_data to simplify code Date: Mon, 23 Aug 2021 19:33:36 +0800 Message-Id: <20210823113338.3568-2-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 In-Reply-To: <20210823113338.3568-1-tangbin@cmss.chinamobile.com> References: <20210823113338.3568-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Retrieve OF match data, it's better and cleaner to use 'of_device_get_match_data' over 'of_match_device'. Signed-off-by: Tang Bin --- drivers/net/ethernet/via/via-rhine.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c index 961b623b7..3b73a9c55 100644 --- a/drivers/net/ethernet/via/via-rhine.c +++ b/drivers/net/ethernet/via/via-rhine.c @@ -1113,13 +1113,12 @@ static int rhine_init_one_pci(struct pci_dev *pdev, static int rhine_init_one_platform(struct platform_device *pdev) { - const struct of_device_id *match; const u32 *quirks; int irq; void __iomem *ioaddr; - match = of_match_device(rhine_of_tbl, &pdev->dev); - if (!match) + quirks = of_device_get_match_data(&pdev->dev); + if (!quirks) return -EINVAL; ioaddr = devm_platform_ioremap_resource(pdev, 0); @@ -1130,10 +1129,6 @@ static int rhine_init_one_platform(struct platform_device *pdev) if (!irq) return -EINVAL; - quirks = match->data; - if (!quirks) - return -EINVAL; - return rhine_init_one_common(&pdev->dev, *quirks, (long)ioaddr, ioaddr, irq); } -- 2.20.1.windows.1