Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1821141pxb; Mon, 23 Aug 2021 05:36:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFVRUNNlP3KhPYYw/0h2o+b0Wm2v7e1oGNdeQ38BdVQ2J4ocKYr5GTM0aIMW5708iM3VLd X-Received: by 2002:a05:6402:424a:: with SMTP id g10mr36445503edb.326.1629722184659; Mon, 23 Aug 2021 05:36:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629722184; cv=none; d=google.com; s=arc-20160816; b=mi/Owqw62xhnDDTavYA3DivRri1L4rD2Ib0LYV+i4VJaUuFfLAP/gHUAisjkq5MgdA LQTTa7RgnTMMfwlaTdGdFF+EA9zXmyjcCe0QKrc40CtorbnZt+3yV94TumCn1zhFFwrN ZlqMBJsOs4iLeXeJqod2ZBfZP50JudfibFdX8iiREZpL4mqO9FTU8RBNrOMW79gX0v1m 1HGAoo/2UdXBcDTDufZ0rd2BtYSds8Fzvw4VXe0h4Plf/AnvDRoEMnatXwMcLVDQ6KiJ 1cetVzbX6eG4niurbmGgy6kjRSEyvzhHPTbNhsdUl3XELQlbsGyWHaYJHnPux/2uAAvi gcIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=8mgD6S2yCoKCWf8ujY9+h3Gu7MvImNb3s0/Jy/F5H4s=; b=b5Wfr/iTeimoP+Yh53Klw0MliQRIZBm/Xp1koPAHwFzkbhsQcqnyn5w2LbfgoMArT/ 0ZigTcWmNGEU2Mj8K3NxKK4eX6yXCqMpIjXKh5ivvrvGQLWToEhohvazxTyZWKbVX7EM kAc3DvaNun7JkhaB6DbofazwYk+ACcZARQT+c+78d2vQX51nlgVasfd5oRf84BUcRHft 5pnREZ5g0kYzw4pAXoHz3zap0mDdIfkaKNsHzNjwpX/P3eu8tiuDPHjprHJrFoTNh+g8 Ttx7kidR3gu38uIWJ4kgnsYfKUQGfTIgjPzGQhKh1TNCLYI2K7leKzZnRmaYcJ/CR37T ZIdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v3si14761768ejr.487.2021.08.23.05.36.00; Mon, 23 Aug 2021 05:36:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237107AbhHWMbp (ORCPT + 99 others); Mon, 23 Aug 2021 08:31:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:48270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233755AbhHWMbl (ORCPT ); Mon, 23 Aug 2021 08:31:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A53A76138B; Mon, 23 Aug 2021 12:30:55 +0000 (UTC) Date: Mon, 23 Aug 2021 13:30:52 +0100 From: Catalin Marinas To: Lorenzo Pieralisi Cc: linux-kernel@vger.kernel.org, Hanjun Guo , Ard Biesheuvel , Will Deacon , Sudeep Holla , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Veronika kabatova , Robin Murphy Subject: Re: [PATCH RESEND v3] ACPI: Add memory semantics to acpi_os_map_memory() Message-ID: <20210823123052.GC8603@arm.com> References: <20210802152359.12623-1-lorenzo.pieralisi@arm.com> <20210823104618.14552-1-lorenzo.pieralisi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210823104618.14552-1-lorenzo.pieralisi@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 23, 2021 at 11:46:18AM +0100, Lorenzo Pieralisi wrote: > The memory attributes attached to memory regions depend on architecture > specific mappings. > > For some memory regions, the attributes specified by firmware (eg > uncached) are not sufficient to determine how a memory region should be > mapped by an OS (for instance a region that is define as uncached in > firmware can be mapped as Normal or Device memory on arm64) and > therefore the OS must be given control on how to map the region to match > the expected mapping behaviour (eg if a mapping is requested with memory > semantics, it must allow unaligned accesses). > > Rework acpi_os_map_memory() and acpi_os_ioremap() back-end to split > them into two separate code paths: > > acpi_os_memmap() -> memory semantics > acpi_os_ioremap() -> MMIO semantics > > The split allows the architectural implementation back-ends to detect > the default memory attributes required by the mapping in question > (ie the mapping API defines the semantics memory vs MMIO) and map the > memory accordingly. > > Link: https://lore.kernel.org/linux-arm-kernel/31ffe8fc-f5ee-2858-26c5-0fd8bdd68702@arm.com > Tested-by: Hanjun Guo > Signed-off-by: Lorenzo Pieralisi > Acked-by: Ard Biesheuvel > Cc: Ard Biesheuvel > Cc: Will Deacon > Cc: Hanjun Guo > Cc: Sudeep Holla > Cc: Catalin Marinas > Cc: "Rafael J. Wysocki" > --- > Resending with all lists CC'ed. > > Patch series is a v3 of a previous version[2]: > > v2->v3: > - Dropped first two-patches following LKML feedback[2] > v1->v2 > - Added patch 1 and 2 according to feedback received on[1] > > [1] https://lore.kernel.org/linux-acpi/20210726100026.12538-1-lorenzo.pieralisi@arm.com > [2] https://lore.kernel.org/linux-acpi/20210802152359.12623-1-lorenzo.pieralisi@arm.com > > arch/arm64/include/asm/acpi.h | 3 +++ > arch/arm64/kernel/acpi.c | 19 ++++++++++++++++--- > drivers/acpi/osl.c | 23 ++++++++++++++++------- > include/acpi/acpi_io.h | 8 ++++++++ > 4 files changed, 43 insertions(+), 10 deletions(-) For arm64: Acked-by: Catalin Marinas I presume this patch would go in via the acpi tree. -- Catalin