Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1856556pxb; Mon, 23 Aug 2021 06:23:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrK9RYyRIHe7XTLvFOuXSSg/7AcrQpTDyyQhGHf72WZt7L7CvY3o0h6rbDQWNuhlk1yQ/K X-Received: by 2002:a5d:824e:: with SMTP id n14mr26259700ioo.134.1629725032333; Mon, 23 Aug 2021 06:23:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629725032; cv=none; d=google.com; s=arc-20160816; b=WDFQ9OO+OmUcVh7mKMB9qIYruN9by7xQh7HZcaRb5YKIct2zcaKGFjud2VspuFaW6y oUMdPWIQUvH4yDkHmyRwPcrVVogb03ObxKJrXOccMCRHM5U6krOjwUIl9MTaIb0K9Mt3 pUjQ8Aq5Hfy0kytCoMFvKmL1RqSZaTRt84jEmhhGAP88A1RpbggeebG1cES11xt0XM2b Mn0Qv1JWL/7OH0vgRBuRZoC3SOAarVN+gfmQcWk7gb6DcajF42f9m325WV/x47weQ3k1 NP4okA9tq6Xgn8oist1iOH4a8+4kj2JMW7mA5+sDTSZybpc5oNFa5QSB7NID1nKmMbSg GfUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=AIj0tHei29m04wDM04n24TUHC/VW6A4IN8JGjNKdUt4=; b=a4slANRlEgXCn8rLER6L6mpu/bCfXYLQK2MaOqIkR+wN1KWhj69n5UK+WETEuYj9Au aXT8OCX/RPqYtL3F67NmXNOKnxn/Ba+GN90xNq3F/WlKv/ioVxYEaSwQzXW06ITh0vIU JmvU6F9QRihayDPuNcKkLRTfgbJddnC2KOIbVIskL47zCTj9IKIt97+OMYqvroBhFG1e 7mf0MGFJ2YrdRtv4Tfvuyglx84yY2xLtiahqQBsuv5RcoMZiW9zcPbvZ5J1FozH24uGY NN7MC7g/GwufZvDlvE6DPqU5lu1yl7zwNqShminVyMfOi4Yz+Ao0jmlOtLqf4oOHf6KF 32/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k32si5861110jav.52.2021.08.23.06.23.38; Mon, 23 Aug 2021 06:23:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237386AbhHWNWT (ORCPT + 99 others); Mon, 23 Aug 2021 09:22:19 -0400 Received: from verein.lst.de ([213.95.11.211]:47946 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235813AbhHWNWS (ORCPT ); Mon, 23 Aug 2021 09:22:18 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 46C7967357; Mon, 23 Aug 2021 15:21:32 +0200 (CEST) Date: Mon, 23 Aug 2021 15:21:32 +0200 From: "hch@lst.de" To: Dan Williams Cc: "ruansy.fnst@fujitsu.com" , Jane Chu , "linux-kernel@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "nvdimm@lists.linux.dev" , "linux-mm@kvack.org" , "linux-fsdevel@vger.kernel.org" , "dm-devel@redhat.com" , "djwong@kernel.org" , "david@fromorbit.com" , "hch@lst.de" , "agk@redhat.com" , "snitzer@redhat.com" Subject: Re: [PATCH RESEND v6 1/9] pagemap: Introduce ->memory_failure() Message-ID: <20210823132132.GA17677@lst.de> References: <20210730100158.3117319-1-ruansy.fnst@fujitsu.com> <20210730100158.3117319-2-ruansy.fnst@fujitsu.com> <1d286104-28f4-d442-efed-4344eb8fa5a1@oracle.com> <78c22960-3f6d-8e5d-890a-72915236bedc@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 18, 2021 at 10:10:51AM -0700, Dan Williams wrote: > > Sounds like a nice solution. I think I can add an is_notify_supported() interface in dax_holder_ops and check it when register dax_holder. > > Shouldn't the fs avoid registering a memory failure handler if it is > not prepared to take over? For example, shouldn't this case behave > identically to ext4 that will not even register a callback? Yes.