Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 23 Aug 2021 07:23:14 -0700
From:   Kees Cook <keescook@chromium.org>
To:     =?ISO-8859-1?Q?Christian_K=F6nig?= <christian.koenig@amd.com>,
        Lijo Lazar <lijo.lazar@amd.com>
CC:     "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Hawking Zhang <Hawking.Zhang@amd.com>,
        Feifei Xu <Feifei.Xu@amd.com>, Likun Gao <Likun.Gao@amd.com>,
        Jiawei Gu <Jiawei.Gu@amd.com>, Evan Quan <evan.quan@amd.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        Alex Deucher <alexander.deucher@amd.com>,
        Luben Tuikov <luben.tuikov@amd.com>,
        Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
        Dennis Li <Dennis.Li@amd.com>,
        Sathishkumar S <sathishkumar.sundararaju@amd.com>,
        Jonathan Kim <jonathan.kim@amd.com>,
        Kevin Wang <kevin1.wang@amd.com>,
        David M Nieto <David.Nieto@amd.com>,
        Kenneth Feng <kenneth.feng@amd.com>,
        Lee Jones <lee.jones@linaro.org>,
        John Clements <John.Clements@amd.com>,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH=5D_drm/amd/pm=3A_And_destina?= =?US-ASCII?Q?tion_bounds_checking_to_struct_copy?=
User-Agent: K-9 Mail for Android
In-Reply-To: <4922d89d-1293-7b32-d684-c731c246e6c1@amd.com>
References: <20210819201441.3545027-1-keescook@chromium.org> <4922d89d-1293-7b32-d684-c731c246e6c1@amd.com>
Message-ID: <FB2A077F-78CB-4D84-A8F2-C63C57923496@chromium.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On August 22, 2021 11:28:54 PM PDT, "Christian K=C3=B6nig" <christian=2Eko=
enig@amd=2Ecom> wrote:
>
>
>Am 19=2E08=2E21 um 22:14 schrieb Kees Cook:
>> [=2E=2E=2E]
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu=2Eh b/drivers/gpu/drm/am=
d/amdgpu/amdgpu=2Eh
>> index 96e895d6be35=2E=2E4605934a4fb7 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu=2Eh
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu=2Eh
>> @@ -1446,4 +1446,29 @@ static inline int amdgpu_in_reset(struct amdgpu_=
device *adev)
>>   {
>>   	return atomic_read(&adev->in_gpu_reset);
>>   }
>> +
>> +/**
>> + * memcpy_trailing - Copy the end of one structure into the middle of =
another
>> + *
>> + * @dst: Pointer to destination struct
>> + * @first_dst_member: The member name in @dst where the overwrite begi=
ns
>> + * @last_dst_member: The member name in @dst where the overwrite ends =
after
>> + * @src: Pointer to the source struct
>> + * @first_src_member: The member name in @src where the copy begins
>> + *
>> + */
>> +#define memcpy_trailing(dst, first_dst_member, last_dst_member,		   \
>> +		        src, first_src_member)				   \
>
>Please don't add a function like this into amdgpu=2Eh, especially when it=
=20
>is only used by the SMU code=2E

Sure, I'm happy to move it=2E It wasn't clear to me which headers were con=
sidered "immutable"=2E Which header should I put this in?

>And please give it an amdgpu_ prefix so that we are not confusing it=20
>with a core function=2E

Sure, I will include that=2E

>Apart from that looks good to me=2E

Thanks!

-Kees