Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1952913pxb; Mon, 23 Aug 2021 08:27:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzEV3adD4MY47hKNNv64vcJ3Y/DeAomWSnFqEkPFY/iYBGg2TCeOtePXtx5p78H3h1+fftF X-Received: by 2002:a92:b301:: with SMTP id p1mr18480458ilh.10.1629732455925; Mon, 23 Aug 2021 08:27:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629732455; cv=none; d=google.com; s=arc-20160816; b=sTTaGc6VY14etm9KoUVo+H9vAhng8pRCT5ZrYwje26smLWGRWCirJLJhpdoWmY5xxR IuLAvcw/anwD9e3RfhTKKAccg5Oo4Kny+QNSDVenZCDgeXT7K0OmNY0Ho2ghKq/SKBIV F4jV64WJcBpQdV9HX6mxIfcL+YfbrUpBqiBBRC+h90p765n8Fy4epmEvRQnBySp/NUe/ NpPPWdZHXXFovQGAe4s3tzLAn+LUh+qATyF0OSkGSnZM5T1LrefDiHvBQDWbnb5dSxJi TU+mHHdUxcElVA15ZTYpsyodjLqGgtIqC2a9zIyKhQnklvAx1p5PKzUzEvpP6l66iodq yINA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id:user-agent :references:in-reply-to:subject:cc:to:from:date:mime-version :dkim-signature:dkim-signature; bh=zzNXlRcAHsKm6STMJq4mGozzykusNpq+Qf/hEUad6WM=; b=d3n53gatFpA4fFx4pp4GqUcB+sAWxdavVgoY2ij0E+MiOG8bJ27RuGtNfvG/s7FBdq bvPR8kFMkXwnGhx+WS+o7AG2KYB5utQTRISJUhJSIl9pkxzSUN26NJLvyiQzosUKX77J ihKkfQ2EmzDIoRIlLXm8OVtduzrd0ffAGchMZS6wLqZvDQ1M89jDhqGOOhbHp4SPVKoq L1s+l15sdPvMGx8VFvLjjmtO6jFsKw8dlitJaxX9crZc29ekrbiJkh1S5doRk8f1aF6T evKA6Zb2cO0l1EVm4ZKyuV0LSi5TNWlcsKOM/IqO8TExSZkukMzcd/e9pE1MazYeqEZ7 CIVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=1AXChqte; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n11si15533507ilt.25.2021.08.23.08.27.23; Mon, 23 Aug 2021 08:27:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=1AXChqte; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231224AbhHWP1N (ORCPT + 99 others); Mon, 23 Aug 2021 11:27:13 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:55166 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230246AbhHWP1M (ORCPT ); Mon, 23 Aug 2021 11:27:12 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D341F21FF5; Mon, 23 Aug 2021 15:26:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1629732388; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zzNXlRcAHsKm6STMJq4mGozzykusNpq+Qf/hEUad6WM=; b=1AXChqteUJFNWbj2o/0GNgcHa4jYElBXHjofi5oyJRId9YO/vq+uxX16e+V/5AsvJEofgy MpuIRdEFNFvitS5T106TQOUKJtj829lmHWPfxbkVTkNHx3dI8wxflbVD98AT6dkNwBDm/K CT/oxPz1VaGDHWLVj1q5hTuLE3VlCQg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1629732388; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zzNXlRcAHsKm6STMJq4mGozzykusNpq+Qf/hEUad6WM=; b=GhCN9RpxkL0+j78tQz8IcfuFkaWKQvYFME0ox6+WBeIMTdWpH6b39C4KL+OsUmfcF02hAN U2YV3rynyBIOZSCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C3B9613BD1; Mon, 23 Aug 2021 15:26:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BueULyS+I2FsSAAAMHmgww (envelope-from ); Mon, 23 Aug 2021 15:26:28 +0000 MIME-Version: 1.0 Date: Mon, 23 Aug 2021 08:26:28 -0700 From: Davidlohr Bueso To: Ran Xiaokai Cc: christian.brauner@ubuntu.com, jamorris@linux.microsoft.com, keescook@chromium.org, ktkhai@virtuozzo.com, legion@kernel.org, linux-kernel@vger.kernel.org, ran.xiaokai@zte.com.cn, varad.gautam@suse.com Subject: Re: [PATCH] tests: add mqueue sysctl tests for user namespace In-Reply-To: <20210823032909.45736-1-ran.xiaokai@zte.com.cn> References: <20210803140133.vksebmgqhlbqipla@wittgenstein> <20210823032909.45736-1-ran.xiaokai@zte.com.cn> User-Agent: Roundcube Webmail Message-ID: <80849d5c6fb87d1404ec8b2a6d9fe78f@suse.de> X-Sender: dbueso@suse.de Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-08-22 20:29, Ran Xiaokai wrote: > create mode 100644 tools/testing/selftests/mqueue_sysctl/Makefile > create mode 100644 tools/testing/selftests/mqueue_sysctl/config > create mode 100644 > tools/testing/selftests/mqueue_sysctl/mq_sysctl_test.c It would be better to use the already existing mqueue directory, instead of creating a new one just for sysctl stuff. Also, while nit, perhaps mq_sysctl_tests.c (plural) to go with the other naming of the tests... Thanks, Davidlohr