Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 23 Aug 2021 17:19:06 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     Peter Gonda <pgonda@google.com>
Cc:     kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
        David Rientjes <rientjes@google.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2 V5] Add AMD SEV and SEV-ES intra host migration
 support
Message-ID: <YSPYinqcP3yr6SpO@google.com>
References: <20210823162756.2686856-1-pgonda@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210823162756.2686856-1-pgonda@google.com>
Precedence: bulk

On Mon, Aug 23, 2021, Peter Gonda wrote:
> V5:
>  * Fix up locking scheme

Please add a selftest to prove/verify the anti-deadlock scheme actually works.
Unless I'm mistaken, only KVM_SEV_INIT needs to be invoked, i.e. the selftest
wouldn't need anything remotely close to full SEV support.  And that means it
should be trivial to verify the success path as well.  E.g. create three SEV VMs
(A, B, and C) and verify migrating from any VM to any other VM works (since none
of the VMs have memory regions).  Then spin up eight pthreads and have each thread
concurrently migrate a specific combination an arbitrary number of times.  Ignore
whether the migration failed or succeeded, "success" from the test's perspective
is purely that it completed, i.e. didn't deadlock.