Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 23 Aug 2021 20:07:57 +0200
From:   Heiko Carstens <hca@linux.ibm.com>
To:     jing yangyang <cgel.zte@gmail.com>
Cc:     Vasily Gorbik <gor@linux.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Vineeth Vijayan <vneethv@linux.ibm.com>,
        Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        jing yangyang <jing.yangyang@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] s390:fix Coccinelle warnings
Message-ID: <YSPj/YRDlGqoVu26@osiris>
References: <20210820025159.11914-1-jing.yangyang@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210820025159.11914-1-jing.yangyang@zte.com.cn>
Precedence: bulk

On Thu, Aug 19, 2021 at 07:51:59PM -0700, jing yangyang wrote:
> WARNING !A || A && B is equivalent to !A || B
> 
> This issue was detected with the help of Coccinelle.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
> ---
>  arch/s390/include/asm/scsw.h | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/s390/include/asm/scsw.h b/arch/s390/include/asm/scsw.h
> index a7c3ccf..754122d 100644
> --- a/arch/s390/include/asm/scsw.h
> +++ b/arch/s390/include/asm/scsw.h
> @@ -691,9 +691,8 @@ static inline int scsw_tm_is_valid_pno(union scsw *scsw)
>  {
>  	return (scsw->tm.fctl != 0) &&
>  	       (scsw->tm.stctl & SCSW_STCTL_STATUS_PEND) &&
> -	       (!(scsw->tm.stctl & SCSW_STCTL_INTER_STATUS) ||
> -		 ((scsw->tm.stctl & SCSW_STCTL_INTER_STATUS) &&
> -		  (scsw->tm.actl & SCSW_ACTL_SUSPENDED)));
> +		(!(scsw->tm.stctl & SCSW_STCTL_INTER_STATUS) ||
> +		(scsw->tm.actl & SCSW_ACTL_SUSPENDED));

This turns something unreadable into something else which is
unreadable. It's up to Vineeth to decide what to do with this.

However I'd prefer if this would be changed into something readable,
maybe as addon patch, like e.g.:

static inline bool scsw_tm_is_valid_pno(union scsw *scsw)
{
	if (scsw->tm.fctl == 0)
		return false;
	if (!(scsw->tm.stctl & SCSW_STCTL_STATUS_PEND))
		return false;
	if (!(scsw->tm.stctl & SCSW_STCTL_INTER_STATUS))
		return false;
	if (scsw->tm.actl & SCSW_ACTL_SUSPENDED)
		return false;
	return true;
}

Chances are that the above is wrong... it's just to illustrate ;)