Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210816000542.18711-1-rdunlap@infradead.org>
In-Reply-To: <20210816000542.18711-1-rdunlap@infradead.org>
From:   Marc Dionne <marc.dionne@auristor.com>
Date:   Mon, 23 Aug 2021 16:22:48 -0300
Message-ID: <CAB9dFdvoo_JtbqW6s4+DKMraWxMX-Qivdt+nm7_w2Q-dq3WTaQ@mail.gmail.com>
Subject: Re: [PATCH] net: RxRPC: make dependent Kconfig symbols be shown indented
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        David Howells <dhowells@redhat.com>,
        linux-afs@lists.infradead.org,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        netdev <netdev@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Aug 15, 2021 at 9:06 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Make all dependent RxRPC kconfig entries be dependent on AF_RXRPC
> so that they are presented (indented) after AF_RXRPC instead
> of being presented at the same level on indentation.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Marc Dionne <marc.dionne@auristor.com>
> Cc: linux-afs@lists.infradead.org
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: netdev@vger.kernel.org
> ---
>  net/rxrpc/Kconfig |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> --- linux-next-20210813.orig/net/rxrpc/Kconfig
> +++ linux-next-20210813/net/rxrpc/Kconfig
> @@ -21,6 +21,8 @@ config AF_RXRPC
>
>           See Documentation/networking/rxrpc.rst.
>
> +if AF_RXRPC
> +
>  config AF_RXRPC_IPV6
>         bool "IPv6 support for RxRPC"
>         depends on (IPV6 = m && AF_RXRPC = m) || (IPV6 = y && AF_RXRPC)
> @@ -30,7 +32,6 @@ config AF_RXRPC_IPV6
>
>  config AF_RXRPC_INJECT_LOSS
>         bool "Inject packet loss into RxRPC packet stream"
> -       depends on AF_RXRPC
>         help
>           Say Y here to inject packet loss by discarding some received and some
>           transmitted packets.
> @@ -38,7 +39,6 @@ config AF_RXRPC_INJECT_LOSS
>
>  config AF_RXRPC_DEBUG
>         bool "RxRPC dynamic debugging"
> -       depends on AF_RXRPC
>         help
>           Say Y here to make runtime controllable debugging messages appear.
>
> @@ -47,7 +47,6 @@ config AF_RXRPC_DEBUG
>
>  config RXKAD
>         bool "RxRPC Kerberos security"
> -       depends on AF_RXRPC
>         select CRYPTO
>         select CRYPTO_MANAGER
>         select CRYPTO_SKCIPHER
> @@ -58,3 +57,5 @@ config RXKAD
>           through the use of the key retention service.
>
>           See Documentation/networking/rxrpc.rst.
> +
> +endif
>
> _______________________________________________
> linux-afs mailing list
> http://lists.infradead.org/mailman/listinfo/linux-afs


Reviewed-by: Marc Dionne <marc.dionne@auristor.com>

Marc