Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210819182544.224121-1-krzysztof.kozlowski@canonical.com>
 <20210819182544.224121-2-krzysztof.kozlowski@canonical.com> <fffdaaad-ac75-5c2f-6a31-7cdc3e57de20@roeck-us.net>
In-Reply-To: <fffdaaad-ac75-5c2f-6a31-7cdc3e57de20@roeck-us.net>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Mon, 23 Aug 2021 16:12:22 -0500
Message-ID: <CAL_Jsq+EXrMRFSwQKW2SOO2fgB48ACD6yXaujat9AbgxdG0_BA@mail.gmail.com>
Subject: Re: [PATCH 2/2] dt-bindings: hwmon: merge max31785 into trivial devices
To:     Guenter Roeck <linux@roeck-us.net>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Jean Delvare <jdelvare@suse.com>, Jiri Kosina <trivial@kernel.org>,
        Linux HWMON List <linux-hwmon@vger.kernel.org>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Aug 20, 2021 at 9:23 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 8/19/21 11:25 AM, Krzysztof Kozlowski wrote:
> > Ther Maxim max31785 bindings are trivial, so simply merge it into
> > trivial-devices.yaml.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > ---
> >   .../devicetree/bindings/hwmon/max31785.txt    | 22 -------------------
>
> Not sure if that is a good idea. It would make more sense to standardize the
> properties needed by the driver/chip instead (see existing dts files in the kernel).

This device is certainly not trivial, the binding is just incomplete.

Device specific fan controller bindings are something I'm just going
to reject until someone comes up with something common.

Rob