Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210819182544.224121-1-krzysztof.kozlowski@canonical.com> <441b28c9-a997-7143-825f-f272e399d60f@roeck-us.net>
In-Reply-To: <441b28c9-a997-7143-825f-f272e399d60f@roeck-us.net>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Mon, 23 Aug 2021 16:19:47 -0500
Message-ID: <CAL_JsqKJgvK8g+zbzLCBxnKbgAioBcdHWNAvqe4Z9BzkNMwPpA@mail.gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: merge max1619 into trivial devices
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Jean Delvare <jdelvare@suse.com>,
        Jiri Kosina <trivial@kernel.org>,
        Linux HWMON List <linux-hwmon@vger.kernel.org>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Aug 20, 2021 at 9:26 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 8/19/21 11:25 AM, Krzysztof Kozlowski wrote:
> > Ther Maxim max1619 bindings are trivial, so simply merge it into
> > trivial-devices.yaml.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> Do we have a general guideline on how to handle such trivial bindings ?

Not really. I debate (with myself) just getting rid of it as I suspect
lots of bindings are just incomplete. Like should supplies be
required? But it's convenient to have and not duplicate a bunch of
boilerplate.

> I normally leave it up to the driver author to decide one way or another.

Me too.

This one looks simple enough to be in trivial-devices, so I'll take
having a schema over not.

Rob