Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Chrisanthus, Anitha" <anitha.chrisanthus@intel.com>
To:     jing yangyang <cgel.zte@gmail.com>
CC:     "Dea, Edmund J" <edmund.j.dea@intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        jing yangyang <jing.yangyang@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: RE: [PATCH linux-next] : add put_device() after
 of_find_device_by_node()
Thread-Topic: [PATCH linux-next] : add put_device() after
 of_find_device_by_node()
Thread-Index: AQHXlWijNuCVLSkwqE+rSAtXsowutauBv3Ow
Date:   Mon, 23 Aug 2021 23:24:38 +0000
Message-ID: <BY5PR11MB4182B03BCF3FE98A5B0054D78CC49@BY5PR11MB4182.namprd11.prod.outlook.com>
References: <20210820021029.10770-1-jing.yangyang@zte.com.cn>
In-Reply-To: <20210820021029.10770-1-jing.yangyang@zte.com.cn>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?T52kgVqHNqTIOk+xxejfUOslBQN62Pi7F0xKYKYxwxd2DDvA81aOwoJOcFT7?=
 =?us-ascii?Q?Qgz5Av5BEAd5gHEbXvq9DjtkVLesYg574SG4y04vcTi9xr1btsf5Dss//zgn?=
 =?us-ascii?Q?d/WVpmj5gg/4RO/eTqTYyr6R0Mcjbp+LcEX9TdWo6EsdTealTAGc3WNgA79B?=
 =?us-ascii?Q?aINH5+rWb4Hf+Ud3e7fCnOyB1XSyXj7Cq0g7SQBgHpb8iKYLwVQBNh/bPsbP?=
 =?us-ascii?Q?DbtW/pQAyDn15H5usCLlwLBDBRrob/lepHRlr6ATmZ/krAGWb1CeyvSKi3fx?=
 =?us-ascii?Q?8EtI6Y5xeIru+SB5iHmkxrLRYe498cCMwCU/9w5xgaDOa1J3VdLQ5xz3hWuv?=
 =?us-ascii?Q?IrM5up7GA0muUR1pCi0PtQym0VJBZ79QL2keC9qmDZG9plIWS5y4QhauKiac?=
 =?us-ascii?Q?K2hgvomfeAIbtdqXiMR3Pd+oW/G4c0sEUs92Ry5AkzIpvnM97FuuIPDrN/AV?=
 =?us-ascii?Q?O5OqDH2fnpwKsUOxezwuAMwNZ9xDMYBY0vRdMKszYt82IqARVrkkEm8JXVM7?=
 =?us-ascii?Q?vaUoIxG4BNc96DhMUhkyYKm+EmlSElIXC7IiKVnX1QyoJIhvucmS+gqldy6g?=
 =?us-ascii?Q?qxZ1dX3dAhwfqJXsWFIweJfUuVMTT39+ghyy7zYVKoWK3igutUPLt7cCkZBS?=
 =?us-ascii?Q?g9G4q9viTGrqtoMHMcXDaiiY3DMCmQdIuMjvbNdz+zIoA89vt+ZZHeQvvf5n?=
 =?us-ascii?Q?myj7vVKhpxAGiQ+gUxb35J8m83qzXGQcqh+liigX7gHLejgMXl7fDSNEK7O1?=
 =?us-ascii?Q?7mh6cHH2dgSA/XpqVMYgyJGcRXa8wqFAv8F5T2HmEXu+odvpfKfb88Yu9hx9?=
 =?us-ascii?Q?wgYFvOMepcea49rj/eFCALpZkIu7ejKksKSf/xUsR+YtoojZ2afZRLKfpRAd?=
 =?us-ascii?Q?09GXyx//a4+Kd1YAvInGpdfF0mnzghV9ExyNbk+SBJL+ZQcS6mD7U6YKGjKl?=
 =?us-ascii?Q?0JcuHugst3ijP7MgA//jZuRzXtRg+1P1abIHbEtoWGBWT2Wa75JCREJWE3Cq?=
 =?us-ascii?Q?xVGxGvVcOpgm0yhE1VOtN0rneWFlk3PsT0LmgImmqk5CObLiQ9N8jPgnMDEC?=
 =?us-ascii?Q?7pXUGq5ePCVomkGnCTrJF35yN/JwY7LmRPchHtFQHwcn41jpgs79tKfP3nYF?=
 =?us-ascii?Q?sgcmViN0LsIoG8RXxD+5B2iYxv38d2cXKx4/qSV7Bb0a2rLh9PqRY4LLukAk?=
 =?us-ascii?Q?cR1f65ZHc7PjiN6/qmDiEuifQwUlfKeg57CkOtwr+/g1qY2w+Xe1pvYZ7JDZ?=
 =?us-ascii?Q?WM3GhINU8UhPHtCsto5pkqEXvAshR3WTJzLDb7Vs8cM/ZXZRUq815RD9rked?=
 =?us-ascii?Q?X4M=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4182.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b32846ab-e4c9-4580-5e6d-08d9668d2d48
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2021 23:24:38.5005
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +MSpIFfZygTFvFxS6BFb5UWUPiiYkwHMIa2gzt25xFsPr0m9svtlwl31dmpYBPsIcJYZ0FZ7mJGccMSIpPHtEZWTHRUuqX5BUpPrJPFJflI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3768
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Acked-by: Anitha Chrisanthus <anitha.chrisanthus@intel.com>

> -----Original Message-----
> From: jing yangyang <cgel.zte@gmail.com>
> Sent: Thursday, August 19, 2021 7:10 PM
> To: Chrisanthus, Anitha <anitha.chrisanthus@intel.com>
> Cc: Dea, Edmund J <edmund.j.dea@intel.com>; David Airlie <airlied@linux.i=
e>;
> Daniel Vetter <daniel@ffwll.ch>; dri-devel@lists.freedesktop.org; linux-
> kernel@vger.kernel.org; jing yangyang <jing.yangyang@zte.com.cn>; Zeal
> Robot <zealci@zte.com.cn>
> Subject: [PATCH linux-next] : add put_device() after of_find_device_by_no=
de()
>=20
> This was found by coccicheck:
> ./drivers/gpu/drm/kmb/kmb_drv.c:503:2-8:
> ERROR  missing put_device; call of_find_device_by_node on line 490,
> but without a corresponding object release within this function.
>=20
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
> ---
>  drivers/gpu/drm/kmb/kmb_drv.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/kmb/kmb_drv.c
> b/drivers/gpu/drm/kmb/kmb_drv.c
> index f54392e..58495a9 100644
> --- a/drivers/gpu/drm/kmb/kmb_drv.c
> +++ b/drivers/gpu/drm/kmb/kmb_drv.c
> @@ -500,8 +500,10 @@ static int kmb_probe(struct platform_device *pdev)
>  	ret =3D kmb_dsi_host_bridge_init(get_device(&dsi_pdev->dev));
>=20
>  	if (ret =3D=3D -EPROBE_DEFER) {
> +		put_device(&dsi_pdev->dev);
>  		return -EPROBE_DEFER;
>  	} else if (ret) {
> +		put_device(&dsi_pdev->dev);
>  		DRM_ERROR("probe failed to initialize DSI host bridge\n");
>  		return ret;
>  	}
> @@ -509,9 +511,10 @@ static int kmb_probe(struct platform_device *pdev)
>  	/* Create DRM device */
>  	kmb =3D devm_drm_dev_alloc(dev, &kmb_driver,
>  				 struct kmb_drm_private, drm);
> -	if (IS_ERR(kmb))
> +	if (IS_ERR(kmb)) {
> +		put_device(&dsi_pdev->dev);
>  		return PTR_ERR(kmb);
> -
> +	}
>  	dev_set_drvdata(dev, &kmb->drm);
>=20
>  	/* Initialize MIPI DSI */
> --
> 1.8.3.1
>=20