Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp2384607pxb; Mon, 23 Aug 2021 20:20:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDaXYJr1wwJ0n2oL8E+BhRbaTlRRCmUkaiaSCoQn6IsVdX9SzHuXRIAc3Icjr8NMf3fx1R X-Received: by 2002:a02:a695:: with SMTP id j21mr29428444jam.99.1629775224921; Mon, 23 Aug 2021 20:20:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629775224; cv=none; d=google.com; s=arc-20160816; b=mt/QGoSIFOoPYBbCCF3iJPlpYKiztew+ABPsa5eSGdSMdbXR5Sm+Q8w9XirED/I3K4 nagSa9jBjuIN7nfYT/fv4+jKmMX7HAjoO3IVcwpJYYdkejmO4E6rCZOlp8ALY97F9wce K3u1KRr+oZf6q8LJtPz0GPB6n9+n+dpkj3ALKnXXE4ORSXhgDVbpvQ2DkWAMRnU553U4 bkRyBwPrgiHOBoX+QSMbpVrbY5s5XYpiB/Ulol1T1tdrPRgP4J5VK1+l/dwWFyvGvatp rPwsfR5/Pos8MtEQ+xx+/VeG0PbMqkKUMAc5n+4w1wUTheIwfK4/X+UC6SEhIoT/BS3L L6YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:mail-followup-to:message-id:subject:to:from :date; bh=5D82S9+3TK8N3FGq4hoekyxRGEvIGQ47Kt2lPVRm+NQ=; b=qLuexFGuwJeOwpxlzwX01/93Sz9NpvDiXrN7NEABYAHmijHVejF4Qb+jiDOMb9YJ6i XqE5H+6VsGzGPGnIcfPmskwLhQM0A04PHl7/xEofggpiSod2ymitgrDoRwlWOsALkj/y g4iT4is9AR2Rd1lXat337dXgxiJ5zOZSXWvR/jWAcjxtE4tV9m7ALl6a6McXmzuH2a9e njI3uq9YKlWTav+Utf4hlYuvJsTlwGJpySmiKHmh0892bHM4LtD/tGaZpG3LbRHTDFHR 93iRKcI5dl1iXWoC9t5UXOsO3v8jYPXTOioe48DxNHOyF8e/yiLjg8ckgqjbs10zJMm3 hiiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i5si1974950jam.97.2021.08.23.20.20.13; Mon, 23 Aug 2021 20:20:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233885AbhHXDTt (ORCPT + 99 others); Mon, 23 Aug 2021 23:19:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234158AbhHXDTr (ORCPT ); Mon, 23 Aug 2021 23:19:47 -0400 X-Greylist: delayed 127 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 23 Aug 2021 20:19:03 PDT Received: from scorn.kernelslacker.org (scorn.kernelslacker.org [IPv6:2600:3c03:e000:2fb::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC246C061575 for ; Mon, 23 Aug 2021 20:19:02 -0700 (PDT) Received: from [2601:196:4600:6634:ae9e:17ff:feb7:72ca] (helo=wopr.kernelslacker.org) by scorn.kernelslacker.org with esmtp (Exim 4.92) (envelope-from ) id 1mIMxn-0001N0-0G; Mon, 23 Aug 2021 23:18:59 -0400 Received: by wopr.kernelslacker.org (Postfix, from userid 1026) id BD53956006F; Mon, 23 Aug 2021 23:18:58 -0400 (EDT) Date: Mon, 23 Aug 2021 23:18:58 -0400 From: Dave Jones To: Linux Kernel , Peter Zijlstra , Johannes Weiner , Linus Torvalds Subject: Re: 5.14-rc breaks iotop swap io monitoring. Message-ID: <20210824031858.GA3263@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Linux Kernel , Peter Zijlstra , Johannes Weiner , Linus Torvalds References: <20210824031648.GA2725@codemonkey.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210824031648.GA2725@codemonkey.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Note: SpamAssassin invocation failed Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 23, 2021 at 11:16:48PM -0400, Dave Jones wrote: > I just noticed that in 5.14-rc running iotop, it complains on startup > that "CONFIG_TASK_DELAY_ACCT not enabled in kernel, cannot determine > SWAPIN and IO %" and sure enough a bunch of columns show up as > 'unavailable'. > > My suspicion is this commit, which I've not confirmed yet as it doesn't > cleanly revert. I'll poke at it some more in the morning, but figured > I'd bring it up sans-evidence in the hope that I'll wake up to someone > having an Ah-ha moment. Forgot to mention, my config has both SCHEDSTATS, SCHED_INFO and TASK_DELAY_ACCT set to =y Dave