Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     Tuo Li <islituo@gmail.com>
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>,
        target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org, TOTE Robot <oslab@tsinghua.edu.cn>,
        baijiaju1990@gmail.com
Subject: Re: [PATCH v2] scsi: target: pscsi: Fix possible null-pointer dereference in pscsi_complete_cmd()
Date:   Tue, 24 Aug 2021 00:02:59 -0400
Message-Id: <162977310549.31461.1789264867256411794.b4-ty@oracle.com>
In-Reply-To: <20210810040414.248167-1-islituo@gmail.com>
References: <20210810040414.248167-1-islituo@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.mkp.ca.oracle.com (138.3.201.9) by SJ0PR03CA0295.namprd03.prod.outlook.com (2603:10b6:a03:39e::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Tue, 24 Aug 2021 04:03:09 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3899b79d-a6e9-4e0e-ac56-08d966b41601
X-MS-TrafficTypeDiagnostic: PH0PR10MB5529:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR10MB5529A5948D8C5618483D285F8EC59@PH0PR10MB5529.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: D3Cht2LjKStfNjCPo5vmhOzymiApCzfIsPHbFUCGcjkEkiBSKrv2SkHT9aEle6o+Ds4gCmaegbuzbo8+FdctVLLt8VI+ccsmgvqjlFep8UdqbENzdvxlSpncJ3DLaXQ/F6FAIRd6OjWLl1M/H+hqThj8KyeL+VYTvWHO4oS6dIhQjcE7hqOw54ptxZFPZnpjw+FwOYlmTx4XNSw6FtFV+DsTIAqUzf6qOghMWkh5LaZpLI3jIq+WlHfGjWNdIL1owOTkaeFoZ6DH5qTO46xQr2LOZNaiRzFNEq1j1SHIZ57dvhUM/ZlXYnEUFL2zjiHEWwxNxpQr/B2+8d3nwBwZ0sIibs+iwTHJ3mMYDsKkOAD3ocNbcNtjNmRy5+oCqJ73opKIaX5O51DV50pPit12APwOBs2fO1vK0FigUAjJ2jW69sDiHjJKvKLN6mydsH0VxHloTE065tjN1kWo4DeW10suiKxwpTPlpXk7TtlQCeVxgncYqd2sOHM7qf2b10/+sO5i6pjFjPLOkmHJi9JwUQ9ivzI+SaRDP0KyXxoncWQqFAKBgr4ZxFCAL1gwQvsn5hHdkJ8NZEKgey7uJ/ZKG5lcgxgIyW/V2S6YcdQH5AQWdRLHli1eR242ozR74A77rA/D+Dd0YcmzRpjijingl/JlI1SXHy5Zszc/6ZGAOPayPxgTSSYUWIQu4LR6OozhoC37SNQn9tK7C+gNgS0C68drvuZSOwpDDhM4usLbHqbSWdupUK1yXialuQaBfCXAtesIeU/r1v46tIcyThdcQQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(396003)(39860400002)(376002)(136003)(366004)(26005)(5660300002)(4744005)(186003)(8936002)(966005)(38100700002)(54906003)(6666004)(6486002)(7696005)(478600001)(4326008)(2616005)(956004)(66476007)(66946007)(52116002)(2906002)(66556008)(38350700002)(36756003)(86362001)(8676002)(6916009)(316002)(103116003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTIxU2dJUTdTMXY2N2w3ODFZL0FscWpBaERWZ0R1VHk1bUNHVFhlMkNoS2p5?=
 =?utf-8?B?elVzdmdVM0oyZWN5YlNOYWJ4ME16U2J2TjU5NnN5cmExVDNNbmpOeWF3UkRw?=
 =?utf-8?B?TlBTWS9Ga0hubm5oeXc0ai8yUmU4c0llZzBveXJzVnNYT1NGdk9vNXBhNC8r?=
 =?utf-8?B?SzVzcmYxMEhrUXBCME9aclA5ZmcvSnF3bnFVZFRnZ3BOOGs0ZHZDYjlhdGhD?=
 =?utf-8?B?MnB1OGNXZjdQUERRTjZMcGE4YitxVmNxa0hCZVJLV1NOZW5kK1AvRExyRWRI?=
 =?utf-8?B?akNGZzRkb2ZCS2JRZHN3Vkt6WHJOa2p0QVgrQU9saUJtQ0trYVNzcG5RL29U?=
 =?utf-8?B?bFhYZlFReXRiWG1mekFwVnI3U2RmZDhnSWR2ZnpWZmJ2WDhnTFVTa2JFOWZr?=
 =?utf-8?B?LzM3bnN2d1MxZlN1ZkhwaklTTzVYTWpWSExNZ0VHdWpGZEpjM1hubDdUQjJC?=
 =?utf-8?B?SWgwbHIrWXBZVW5VOFVXdmVBaGErTkFiYTRtd1MxaHp1YVBQbGdpL1I5bHUw?=
 =?utf-8?B?MkJTb2Y1ZnZWQmQ3Skw4UFdpZmcxc3UrK1UyT3ZnYW5iRkxxaTJoUDM2UnU2?=
 =?utf-8?B?bUVZRiswT0pRaFZGVXNJNjRqa2RRVWNLV2pEdDh0T1FSVjM2ZkJ1V1NtOUdK?=
 =?utf-8?B?K3AvQ1ZhSW42Q1FkeXphOXRJZ3NsNCtoYzROZllENWxVV1dGV0U0ZWZMRUtm?=
 =?utf-8?B?UmhPT2lZZTRZd3hjWjlBYk9qUmJMMkd1QlpHd3IyVHNhbjhiQVptbFhqaTFC?=
 =?utf-8?B?UUhZTGNWVXNNaHNpNUNpN0JIVTVGQ0xVNnIrQnkrRUJpZEU2MlE0RVV2bTZW?=
 =?utf-8?B?bUh3a0lVekpwV3I5cTk4c2k0R1BJcDh3a3ZDN0VrY2NLQnhsNXd0djFuWEJI?=
 =?utf-8?B?am1ZM0JjVmVWN3lFSncwWEZQSnAwaEN1enNBd2JKSmovQnNvNVBQMWhuMERS?=
 =?utf-8?B?YUZ5dy9jblpNWnRLTXpPK3pFSXF4WDE0Ny84SkVaSVBoRGhSaGI1M2lNanZH?=
 =?utf-8?B?M1BuZ3M4ZFJ5WUtlWngrMWNoN0szWmZrU01uMUcwT3ZwTTRlU2ppWTJjT0Jw?=
 =?utf-8?B?dHd4L2dPcDdUSHAxSnZudkkrZ1ZpYkxqQk9iTGpBdFMwMFlpQml0WGdWUzRi?=
 =?utf-8?B?ZHkwMzhvZHZPZm0vOVZWRkpjdGZXdWZIWXBJbzJZckFKZDBLeVUwdFR2dFQx?=
 =?utf-8?B?NDBkVEZQMzd5WXJ5U29XZnE0eXBPdmdxR1VxakgrUDdnUDNQRm40U1ZiYzFX?=
 =?utf-8?B?dVZ0aDB3MDRyYXJSTnUwUnBlRXNRWkF2OVBhU0J5MGw0QkNBcmxQaDZpak5B?=
 =?utf-8?B?MncvNnk3MFZ0QW45WHJwUGRGOUppbXVRRit1cTlpb2lWMnZSZU5LbS8xMFI1?=
 =?utf-8?B?UUNja1luaXhWZXRHSGxsblJrOGZtTHR2b3RvUE5hdi9JQ1NRbzJaM28yMk9L?=
 =?utf-8?B?Z2NPNENCVUFKZWVhS3hMeDZZd2ZnYUpEb2ZDSCs5NFI0T1JFTEtmOHJUYlM2?=
 =?utf-8?B?RmdOejBqanBHbVc3c0pGTHJ6Y05SZitZMElacTIzai90Rm1oeERUTEhDcS9J?=
 =?utf-8?B?QXgyZGFQSnBYc1hmQnlrZnk0TWdJSUxwcXRpZHFTWWw3VmJCSUFFUDFyME5X?=
 =?utf-8?B?aTBhTzRKZklTak1qUUxSRUJqRUtOR3hIRE1pK1dOT0tsenVMdEhYaFBRUGxx?=
 =?utf-8?B?dksxdnl3OXVMN0t2K1JGMUM0Q0hmMmpxUTV3bjhTYVUxU3kvQWc4R1cza3hi?=
 =?utf-8?Q?YlprMfkKtU/3BWfY8V9EXkIZYVR+vkg8Iotkwgd?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3899b79d-a6e9-4e0e-ac56-08d966b41601
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2021 04:03:10.0962
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hQUy/MEd6OuQjZCFsvUbupfNLxBMXVsc9s7wCtInx+e7OSRL7KLqDdoRnXFumh4NV/UenPqr9FIxrScsWGDQMkG/v+n1qg8aXvEyABNy4ew=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5529
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10085 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 spamscore=0
 bulkscore=0 mlxlogscore=895 malwarescore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000
 definitions=main-2108240024
X-Proofpoint-GUID: J5_8a_quObzJFND1tKbpiuuqNjF9bezq
X-Proofpoint-ORIG-GUID: J5_8a_quObzJFND1tKbpiuuqNjF9bezq
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 9 Aug 2021 21:04:13 -0700, Tuo Li wrote:

> The return value of transport_kmap_data_sg() is assigned to the variable
> buf:
>   buf = transport_kmap_data_sg(cmd);
> 
> And then it is checked:
>   if (!buf) {
> 
> [...]

Applied to 5.15/scsi-queue, thanks!

[1/1] scsi: target: pscsi: Fix possible null-pointer dereference in pscsi_complete_cmd()
      https://git.kernel.org/mkp/scsi/c/0f99792c01d1

-- 
Martin K. Petersen	Oracle Linux Engineering