Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp2572167pxb; Tue, 24 Aug 2021 02:16:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6IcXw+6OK+9nFIodupEEellUbgrvcPLy9eMy1LNP7I1/ri6jTTxhaHwIQtkq0Zwoj6WCI X-Received: by 2002:a17:906:fcda:: with SMTP id qx26mr18429426ejb.121.1629796618819; Tue, 24 Aug 2021 02:16:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629796618; cv=none; d=google.com; s=arc-20160816; b=Li9OTJ47Don/pzBGRbRL2A6isuhUptdCzJiHxOZ4M61KAvcUvbhpelHVg7tYyVr5hW M+aPHP0UShCjsvwvnfWZII16s2a3wQ7Vk3NZYNPQaE8uDSvAq117UxXoPcQ/YEIOCqGZ dGPQDSi6aER9C9WLcC5zrWx+zU3NCfQeWfRoQrisAe05ttVK9uIzvvngC6CSq67/7iOQ pPM1SVStPH2kKYECLlEey0R3m2XzeLt5FJ1rvLS57cY8dJPzVS/PARAM2x/rx+swuLne WHVFQzNOt+E+OGXYJSb8ijlePNL0pwavz5sHOyPCqFIPPYcHB3vreSHr5F7q5FPqw5Uv k5Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=6R9MsfR3gmhuz3nWLZW1kqph4hPawg4BSnB7Fx8sGqE=; b=wPHVvqZd4a9d8zWacyqP87RVpn1ymQlEYAcVFCKcnTQ/IhycIyNLMVmpiOIY3FeqwS GF/+MsnKkWTAvVj3WWGmxramlibvO7awg4mBAlfyyijMe5uj2dYNS3eZcdTWiVjZagfx bHGbMn3apfKj5fKLCI8PkI7XH7IdtS/ekAyTa5ofDZ8NjtSgBAFtnLTvevgIxpSs+7cS FsUNYNsAsyz+LYMZwSLLbCF1W9q6E5/vPD8UxHI0Mlu4jMc8/23j8wtFG53IeclDNc6D 7J8o2xjGNQaLiXHjS2Bv3B616EwDf6XNCoYVSihUYzXHbQCQhK6NaJwjEx3awchWdvH2 0vwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Bkod/r27"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ky22si16285327ejc.543.2021.08.24.02.16.35; Tue, 24 Aug 2021 02:16:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Bkod/r27"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235712AbhHXJPX (ORCPT + 99 others); Tue, 24 Aug 2021 05:15:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235658AbhHXJPW (ORCPT ); Tue, 24 Aug 2021 05:15:22 -0400 Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DAF8C0613D9 for ; Tue, 24 Aug 2021 02:14:38 -0700 (PDT) Received: by mail-qt1-x834.google.com with SMTP id b1so16223120qtx.0 for ; Tue, 24 Aug 2021 02:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version:in-reply-to :content-transfer-encoding; bh=6R9MsfR3gmhuz3nWLZW1kqph4hPawg4BSnB7Fx8sGqE=; b=Bkod/r27mUBMfYIfxzoQRvTvoKu3LrmldiZeC8OQKd2wVKA3L0kXx4mV8DpEs9FooS s0uI4lOd55Yj5hCVFXYpQKcyc6mjxJdUac2SbV1zufjQvs3JsOdQ9mSGck3QNbYnxCun bJJSrbWuBIQX2gWLqcV30IJyDV5cans8oXwj0ihdbhKfThJWDM4iqaBi3NRJpgwW9gZT lzx/HYi1qYBkT+Cxsl2BNyEbX9bf8SCIEeYaf6nr2OS32Fw50Kn9GAvWg7oilBwEkYog YgzyWJobGdPzWnCa1UW4u6bca2zonAdPUmkzYNOXV7tg+BqRIPOUcN5501/YLT1QqHy9 nXwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :in-reply-to:content-transfer-encoding; bh=6R9MsfR3gmhuz3nWLZW1kqph4hPawg4BSnB7Fx8sGqE=; b=pPNZfS/fotktoqhe+nDQ7SsF/u2VlsnaOSmFcNeRMldG+jPSH3Cg+bKCmLkmErqd4y 3v4mtVlcnPzHnT98ViOl+SfmNf+6HCZ0oH/xEf1cDH/mh8oKgNlTWzEEBpAkIM906SkW KnfrNwPmiPEtYEyOwMHBeCoHqLTvmJE271gqADLFoNh4wTrqCX0UHlRcLVsWCXyE9je2 wBOaZhNPejrnPBk30kN1EM5OW6OfNSZSFaUOI8xf++H0ZovEAlTiqmvCKlXUNFDLGeWq uR9uL2GWDvvPcezN7Cu9UGzyfKySYSouF+5qR2DEQjwYPSpgrDbQbpz1gAlmnjsKjUn+ 4FNw== X-Gm-Message-State: AOAM531haLZMOtfnNkdnSL/hI80pDfJkWgdAWQECDsm6oGodL/p7XU1J N+IUUiRxfIgoNROpTHttB6s= X-Received: by 2002:ac8:5194:: with SMTP id c20mr24749748qtn.68.1629796477596; Tue, 24 Aug 2021 02:14:37 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id z21sm5464570qts.27.2021.08.24.02.14.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Aug 2021 02:14:37 -0700 (PDT) From: SeongJae Park X-Google-Original-From: SeongJae Park To: =?UTF-8?q?Valdis=20Kl=C4=93tnieks?= Cc: Randy Dunlap , Thara Gopinath , Greg Kroah-Hartman , Sudeep Holla , linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq: qcom-cpufreq-hw: Fix 'make allmodconfig' build Date: Tue, 24 Aug 2021 09:14:30 +0000 Message-Id: <20210824091430.20367-1-sjpark@amazon.de> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 In-Reply-To: <440653.1629666844@turing-police> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sun, 22 Aug 2021 17:14:04 -0400 "Valdis Klētnieks" wrote: > > [-- Attachment #1: Type: text/plain, Size: 270 bytes --] > > On Sun, 22 Aug 2021 14:08:08 -0700, Randy Dunlap said: > > > This fixes one build error for me but I am still seeing another one: > > > > ERROR: modpost: "cpu_scale" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined! > > That's a different patch, am working on fixing that one now.. I didn't take a deep look here, so I unsure if this is an appropriate fix, but I was able to work-around this issue for my use case with below change. ``` --- a/drivers/base/arch_topology.c +++ b/drivers/base/arch_topology.c @@ -149,6 +149,7 @@ void topology_set_freq_scale(const struct cpumask *cpus, unsigned long cur_freq, } DEFINE_PER_CPU(unsigned long, cpu_scale) = SCHED_CAPACITY_SCALE; +EXPORT_PER_CPU_SYMBOL_GPL(cpu_scale); void topology_set_cpu_scale(unsigned int cpu, unsigned long capacity) { ``` Thanks, SJ