Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 24 Aug 2021 21:21:29 +1000
From:   Aleksa Sarai <cyphar@cyphar.com>
To:     Shuah Khan <skhan@linuxfoundation.org>
Cc:     Baolin Wang <baolin.wang@linux.alibaba.com>, shuah@kernel.org,
        Christian Brauner <christian@brauner.io>,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: openat2: Fix testing failure for O_LARGEFILE
 flag
Message-ID: <20210824112129.2t6lzqyf2dxllw4a@senku>
References: <1627475340-128057-1-git-send-email-baolin.wang@linux.alibaba.com>
 <01184d9e-477d-cbe4-c936-62b92e915911@linux.alibaba.com>
 <9411d418-567b-78f0-0e4d-30f08371c55a@linux.alibaba.com>
 <a9dc1616-61b9-c010-950c-521693c74247@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ufybcjmqvvbiby3e"
Content-Disposition: inline
In-Reply-To: <a9dc1616-61b9-c010-950c-521693c74247@linuxfoundation.org>
Precedence: bulk


--ufybcjmqvvbiby3e
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2021-08-23, Shuah Khan <skhan@linuxfoundation.org> wrote:
> Hi Baolin,
>=20
> On 8/22/21 8:40 PM, Baolin Wang wrote:
> > Hi Shuah,
> >=20
> > On 2021/7/28 20:32, Baolin Wang wrote:
> > > Hi,
> > >=20
> > > > When running the openat2 test suite on ARM64 platform, we got below=
 failure,
> > > > since the definition of the O_LARGEFILE is different on ARM64. So w=
e can
> > > > set the correct O_LARGEFILE definition on ARM64 to fix this issue.
> > >=20
> > > Sorry, I forgot to copy the failure log:
> > >=20
>=20
> Please cc everybody get_maintainers.pl suggests. You are missing
> key reviewers for this change.
>=20
> Adding Christian Brauner and Aleksa Sarai to the thread.
>=20
> > > # openat2 unexpectedly returned # 3['/lkp/benchmarks/kernel_selftests=
/tools/testing/selftests/openat2'] with 208000 (!=3D 208000)
>=20
> Not sure I understand this. 208000 (!=3D 208000) look sthe same to me.
>=20
> > > not ok 102 openat2 with incompatible flags (O_PATH | O_LARGEFILE) fai=
ls with -22 (Invalid argument)
> > >=20
> > > >=20
> > > > Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> >=20
> > Could you apply this patch if no objection from your side? Thanks.
> >=20
>=20
> Ideally this define should come from an include file.

The issue is that O_LARGEFILE is set to 0 by glibc because glibc appears
to hide the nuts and bolts of largefile support from userspace. I
couldn't find a nice way of doing a architecture-dependent includes of
include/uapi from kselftests, so I just went with this instead -- but I
agree that a proper include would be better if someone can figure out
how to do it.

> Christian, Aleksa,
>=20
> Can you review this patch and let me know if this approach looks right.

Reviewed-by: Aleksa Sarai <cyphar@cyphar.com>

It'd be nice to fix this for the other architectures I mention in the
comment (mips, parisc, powerpc, sparc) -- which are the ones that I
could find that had a custom O_LARGEFILE definition.

> > > > ---
> > > > =A0 tools/testing/selftests/openat2/openat2_test.c | 4 ++++
> > > > =A0 1 file changed, 4 insertions(+)
> > > >=20
> > > > diff --git a/tools/testing/selftests/openat2/openat2_test.c b/tools=
/testing/selftests/openat2/openat2_test.c
> > > > index d7ec1e7..1bddbe9 100644
> > > > --- a/tools/testing/selftests/openat2/openat2_test.c
> > > > +++ b/tools/testing/selftests/openat2/openat2_test.c
> > > > @@ -22,7 +22,11 @@
> > > > =A0=A0 * XXX: This is wrong on {mips, parisc, powerpc, sparc}.
> > > > =A0=A0 */
> > > > =A0 #undef=A0=A0=A0 O_LARGEFILE
> > > > +#ifdef __aarch64__
> > > > +#define=A0=A0=A0 O_LARGEFILE 0x20000
> > > > +#else
> > > > =A0 #define=A0=A0=A0 O_LARGEFILE 0x8000
> > > > +#endif
> > > > =A0 struct open_how_ext {
> > > > =A0=A0=A0=A0=A0 struct open_how inner;
> > > >=20
> >=20
>=20
> thanks,
> -- Shuah

--=20
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>

--ufybcjmqvvbiby3e
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSxZm6dtfE8gxLLfYqdlLljIbnQEgUCYSTWNwAKCRCdlLljIbnQ
Ep/uAQDWL4pxkriA19TI8MlqihWk/zMgI75lNQtI5MUCR5WZvgD/YUOzLOSyZrU9
z0gdvEDAdRLwmJEEzs/wtDV/eb0YbQo=
=ijy5
-----END PGP SIGNATURE-----

--ufybcjmqvvbiby3e--