Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 24 Aug 2021 14:48:58 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc:     ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: [PATCH] fs/ntfs3: fix an error code in ntfs_get_acl_ex()
Message-ID: <20210824114858.GH31143@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kili (62.8.83.99) by ZR0P278CA0144.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:40::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Tue, 24 Aug 2021 11:49:06 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a0a012bf-89dd-4a55-694c-08d966f52f0b
X-MS-TrafficTypeDiagnostic: CO1PR10MB4595:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO1PR10MB459560756F01653B0366F5378EC59@CO1PR10MB4595.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: JAF+v07pyDuefIUywZjAMRfLi2cGFMptF7qx41UU1spNeZNAuG3HCdBmN8l09uZj/2w3r8s1Om2Y1U+LnzBVB01bMduSNqxtUHpmHi4jTSwjpGg0Oc6XyZ8D5z72IoMNU1A/VKOgJytL8WZnDDf0nucw+m/L5UxIzbuXhAWayD9gVmiQjaoUu6Ky4+cR2lVeWDejRPuUT5AluySZ6ax6ZKvA4w45ymJuRWGcL4Kr8+eJ3QOL06ucowWs3MiPezCb9Iftx1kmEkKb+D7T5bKfaZ7t5Uyi5/GCwd1t2F6up25jf3ZxIBRFPq+XOyEd1Eh42cHf39uxloNKsNDC0I1j+GtnQde7zVD+FtQXIc0KzkvZfsGr89JkzdA6Zp5C3WjuuGX/fL5yjeAzJ7gzZO6W0Nksf6Ha8RSGF6bqEZbOKJtTxY8wtxYjFq34GX6qUcriDc6o79nM2IYzPW/gu2XH5KFBMvDhzGkUmIe/6u35QbwDJP4sH0wvllOg7/clQgSQz97kg/YeBVdPkbaXURKTm0y5YLGwM9HMGKoLX0da4EDG4w9witAnXAEMvHLGgbC0SIzOgVlh7k9Zm1rfJclHwQvA7g+6Ui3H5G7I67ovwC/UtoaTHEUITLZayQs25SXJb+sUA/PejbLEy0RuNG8ndBmw3BwmlUK4jDRTR1NLKSyNXofi4YxfdDjhRswhQXFfSFBtLcri7wZ4kuQCZ8IKNQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(136003)(39860400002)(366004)(376002)(396003)(38100700002)(38350700002)(6666004)(1076003)(86362001)(9686003)(66946007)(4326008)(2906002)(6496006)(66476007)(33656002)(316002)(55016002)(52116002)(26005)(478600001)(186003)(5660300002)(6916009)(8676002)(33716001)(956004)(66556008)(83380400001)(44832011)(9576002)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2S84Ub24d/Z8F8TpGCndlbKb9bXtIr2gpdJbpFn2wEZQfJgJJI/sKEaJ1skU?=
 =?us-ascii?Q?RGn6MrbMPuIHvm+A+j9ADp1EhwgZJBvgqnCdau/GNRJXQR2kr3WYsuYcW8Ag?=
 =?us-ascii?Q?RQvdYfL3UDclpQTuiwf5GWfh6m7lQYB8oAfIH4/mDFoWiDFo26vgryqyUzbg?=
 =?us-ascii?Q?AyA1X3VUhYhWjXHcm3Th+sTSUWhw4i+7jDNZrDQi8VfLleNn3+xG80KEcBbV?=
 =?us-ascii?Q?qixw3eLUqq/2xMdGX1EMZP6dqXPa0iUFs9GRObtXlULPs9jcqZFwU6zEsiKC?=
 =?us-ascii?Q?130RswK6/dqmqS9QtEJ79upSnRzK3QqRp6nX5UYfPo4zQCjeGPko2EYbT8uT?=
 =?us-ascii?Q?X0a2ULU127Ir1gg3iuTrpkErcdkEVFs1uMkEOSI+ri6DfBRMSktlVcB4G7gB?=
 =?us-ascii?Q?fuxh6zxbZlhOkIRD8hppLeEXInJllbjdK7U1PfVQrz+xiYcoxiyhitpyOMBt?=
 =?us-ascii?Q?3ZpFP8jkhkTDynThLp1oyjUWfuURK3lMkP5YWu9A6wVtRuQu2MPm8BZpwBsh?=
 =?us-ascii?Q?/bQWnta+UAuYSEpgQo6Jp4Muqcn5cKwsLmIP/chj/qta2C4Yu5Rc4d1SrR0C?=
 =?us-ascii?Q?KnFPfBlDvzLJmxi8QnaQl/caacPovhhB0x+cIpvkxUy0jt8Jmh5EmzdcBPA5?=
 =?us-ascii?Q?QDC3Pgmu+ozHGFMuLBknoh62s0x36Kk9yzm7Gq8/L8QlGJac/vp5v85h4NYT?=
 =?us-ascii?Q?2X/XHPbl/KpOsF3/RsGDyRH5Duz3RuJG+WuBZw02YR2ApbmuwgSovljunRXn?=
 =?us-ascii?Q?eICfoL4FFZNMwPzXf01jitupBn+xBqtbGLoc4OoZAUoXXlEA1g/biib7uM2b?=
 =?us-ascii?Q?pNnH3ahs+HhcJ9x42xbg9KaEFNRx1G7XFgd81xh8vm6ntXBsE63D3U6rGhLM?=
 =?us-ascii?Q?MH02jvbznElJlayzlw6xdqGoS4WSq1a2GRzLxh8OmlU9Q8EiS/xROV1R93NV?=
 =?us-ascii?Q?W9FyhA2k3S6686UiNT86glpy6x9SL719TFIkCmtFjwqmYo97K8dpP2mDcREh?=
 =?us-ascii?Q?RitSoyCzUKBrstW1YAEbVauN/muj4akXa1ivnFVYi2ItOZ0si7LAoQYHJHpb?=
 =?us-ascii?Q?GIhXmad43PhEJs5SdDNFHNAKpwLNZJulKUtRQM5Z8q1CL+Rd+jMWNxGb3QuA?=
 =?us-ascii?Q?NnPfFpvf1ce5srqPRKFsB9BIx6Fv37szDewDCebcP4wtqfOml8/N4lE+aqnO?=
 =?us-ascii?Q?+ZLBoH6MDW3b7w7TgcmeRvM/S+/pD4tPLm+8C/JdZdS5zAqwagIeFeD56ffE?=
 =?us-ascii?Q?hEhoYCBV4p9VOObEc2b1/FxBLlONy09L+j7ht04gKoWTYddgmcTUnvxrXhiZ?=
 =?us-ascii?Q?6QMOLJaKXezVwrFaQ0XGCBlE?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a0a012bf-89dd-4a55-694c-08d966f52f0b
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2021 11:49:09.3722
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XU7/2lQgVoze+y/o/MmxE9b40hNKxm1GXccXuvHNtrvlf5pQ7I8EXYY4LNWJ+BBq7qcjY97wobehCApdPoL8f4ahwm9Mkh8slGEgDfkztw4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4595
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10085 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0
 spamscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000
 definitions=main-2108240079
X-Proofpoint-ORIG-GUID: fESl5YGN12tV0eyGEQ1QPncp4M508hhT
X-Proofpoint-GUID: fESl5YGN12tV0eyGEQ1QPncp4M508hhT
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The ntfs_get_ea() function returns negative error codes or on success
it returns the length.  In the original code a zero length return was
treated as -ENODATA and results in a NULL return.  But it should be
treated as an invalid length and result in an PTR_ERR(-EINVAL) return.

Fixes: be71b5cba2e6 ("fs/ntfs3: Add attrib operations")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I'm not super familiar with this code.  Please review this one
extra carefully.  I think it's theoretical because hopefully
ntfs_get_ea() doesn't ever return invalid lengths.

 fs/ntfs3/xattr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c
index 9239c388050e..e8ed38d0c4c9 100644
--- a/fs/ntfs3/xattr.c
+++ b/fs/ntfs3/xattr.c
@@ -521,7 +521,7 @@ static struct posix_acl *ntfs_get_acl_ex(struct user_namespace *mnt_userns,
 		ni_unlock(ni);
 
 	/* Translate extended attribute to acl */
-	if (err > 0) {
+	if (err >= 0) {
 		acl = posix_acl_from_xattr(mnt_userns, buf, err);
 		if (!IS_ERR(acl))
 			set_cached_acl(inode, type, acl);
-- 
2.20.1