Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp2666821pxb; Tue, 24 Aug 2021 04:56:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsxMBIKm8b/6mPYZdyvbEAWr/cSOa/mGhmf55/opd45Mzuekc/OWgWcnQkRA85Xeufg17e X-Received: by 2002:a05:6e02:1d88:: with SMTP id h8mr13368757ila.258.1629806199779; Tue, 24 Aug 2021 04:56:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629806199; cv=none; d=google.com; s=arc-20160816; b=sXryigS9AtEj4RHM5VWtJfLTF2S+rUVt2vmk0d5OvO1g9PgGlgb7eIMsPiVV/3jk23 Bh9qWTOK2Rmv4wSj4LHIxqFUUi21lPPAQmdM4A7HNfWZwRAfcsXjemaHrWwEdXCeILUx 51UiYbic+NJqEnOLUJlI2dFelHxT0glgSrMaocxO8l0cRhUC2Dwd8f/Uw7RSJnTj5jep riOZPkCPdnUgJdDgI/qcCfcUonQ9UoxRDMIoLXugyciCDexqOCH/r9gRo7F7qYJovSkD R/OKSevWZn4N03zfJc5r3FN/JzvqGt2D+3CRh0m4QPYSPRkH5x0vZkuqcv+ndtyEYsEd 3ApA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:dkim-signature; bh=ElYIbHm61WTFfx7/zY+xRqeQZgdxqlOoV93Dz97CB90=; b=ZTnhFpSd/QqkIqC5SNav+T7G90wYMGH9gyuLRz57Xnd0bkGG0iVj3tI+GjndKOPchs m7DLutrTXSRZ84Y/O8xd8E+O250aet3k6s5+oettHgpfBWbkYC41dBPxLptoYkx5kiEt akvSmgMbrJgUBwRICYEwq95K2BQvRQxyuwgIKlC3oseDeTikZzpjqwKxXuI1GCnRlC85 /B9v6iHCtGbZKOlJHT7EbFK26pNs1RLiwDDipFmro2rSBeOqjhSjh6Ug6mPKG6HQ6fhE RRsraOxie3kBiWj3uPUPLO2I8FEtvsg7/YZC2WRqtDV268XvL5LXHQ/xsTX/DdnEs52g POMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=GXAI3+YU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u11si11561620jau.60.2021.08.24.04.56.27; Tue, 24 Aug 2021 04:56:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=GXAI3+YU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236908AbhHXL4P (ORCPT + 99 others); Tue, 24 Aug 2021 07:56:15 -0400 Received: from esa.microchip.iphmx.com ([68.232.153.233]:20919 "EHLO esa.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236650AbhHXL4O (ORCPT ); Tue, 24 Aug 2021 07:56:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1629806131; x=1661342131; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nvQXMiaPy2VuNQO50RLteRfILBr98vNnCM+YLfLiMik=; b=GXAI3+YUqRs7Sndc+mBBMy3orUyeGQEz9ik/h1vwaCazN9FgWcSxiMj1 DPrG07NjYRqmiHfv4AxdfO2e6SMg+vd6ZDxoe4eTTQVVl7sucl63QMFoK AvdaaStsUoPQbKZD9nw+GhonlZ04wBcpYxBeAzPiTfqAGBpIiV4QrIgSA Vmj5z+eDPn/RcKFQsGaRqajg1MYXR5/Q4Z9IzY01uFdkK76KQMu60pZ3L eYz+GbZ+WkxeS8VmEeZcTn2O9zMNwyxXn5TdCy2hFzk5Y8q63919P2jhF C3AbjWJ/6Z6IZlMManjoOZvORmuJcNlBGytJlBsSjEDMBh3+Wf4kIi+kX Q==; IronPort-SDR: 6nPG1Al6NEDaXSpPdGdoVRRm6Hi4pWaBvvs6si5FpIn+sJSk/P6n4jbLO1f2vgB4Edld59Va2K 3LAgxeMLWOw/huylvtwDj8zSVrPfPqWTiZSSEdXv65nGffvxP0M7DSaPfSDa7lDPsyKVzfZZaF 4pGLEkzzeYrORjjwTx5zgbEHQquYFEW4c+t/4y/eCXmwx6LzIY0Riq+eboTIjqkK8eNcu+Neto bj071yJsx50L34yivs1QsdYqbuqH9SmjnWBsPyanNgSGO3RkO1Ltyzvg0QuFkhSApEgrZNHxai JWtd9X7OFfQOW2j2sWwWN/aV X-IronPort-AV: E=Sophos;i="5.84,347,1620716400"; d="scan'208";a="133408028" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 24 Aug 2021 04:55:30 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 24 Aug 2021 04:55:29 -0700 Received: from ROB-ULT-M18282.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 24 Aug 2021 04:55:18 -0700 From: Eugen Hristev To: , , , CC: , , , , Eugen Hristev Subject: [PATCH v2 02/10] iio: adc: at91-sama5d2_adc: initialize hardware after clock is started Date: Tue, 24 Aug 2021 14:54:33 +0300 Message-ID: <20210824115441.681253-3-eugen.hristev@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210824115441.681253-1-eugen.hristev@microchip.com> References: <20210824115441.681253-1-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The hw_init hardware init call must happen after the clock is prepared and enabled. Otherwise, writing to the registers might lead to a block or external abort. Signed-off-by: Eugen Hristev --- drivers/iio/adc/at91-sama5d2_adc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c index ea5ca163d879..1f4d461c2c18 100644 --- a/drivers/iio/adc/at91-sama5d2_adc.c +++ b/drivers/iio/adc/at91-sama5d2_adc.c @@ -1833,12 +1833,12 @@ static int at91_adc_probe(struct platform_device *pdev) goto vref_disable; } - at91_adc_hw_init(indio_dev); - ret = clk_prepare_enable(st->per_clk); if (ret) goto vref_disable; + at91_adc_hw_init(indio_dev); + platform_set_drvdata(pdev, indio_dev); ret = at91_adc_buffer_and_trigger_init(&pdev->dev, indio_dev); -- 2.25.1