Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210822192205.43210-1-arielmarcovitch@gmail.com>
In-Reply-To: <20210822192205.43210-1-arielmarcovitch@gmail.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Tue, 24 Aug 2021 22:23:41 +0900
Message-ID: <CAK7LNAQ6G11a-4_UZUtorBmmU6RzKeEkNjEzAWTpVv+LZR_=7A@mail.gmail.com>
Subject: Re: [PATCH 0/3] checkkconfigsymbols.py: Fix various bugs
To:     Ariel Marcovitch <arielmarcovitch@gmail.com>
Cc:     Michal Marek <michal.lkml@markovi.net>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Valentin Rothberg <valentinrothberg@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Aug 23, 2021 at 4:22 AM Ariel Marcovitch
<arielmarcovitch@gmail.com> wrote:
>
> Hi!
>
> This series fixes some issues in the checkkconfigsymbols.py script.
>
> The first patch fixes a bug in the --ignore option that makes the
> script check only the files matching the pattern instead of ignoring
> them.
>
> The second patch fixes a parsing error in the Kconfig files parser
> that makes it ignore 'if' statements after 'help' sections.
>
> The third patch prevents the user from using 'HEAD' refs in the
>  --commit option, because it doesn't really work.

Honestly, I didn't even know this script.

I added Valentin Rothberg, the main contributor
to this script.


> Thanks!
>
> -Ariel
>
> Ariel Marcovitch (3):
>   checkkconfigsymbols.py: Fix the '--ignore' option
>   checkkconfigsymbols.py: Fix Kconfig parsing to find 'if' lines
>   checkkconfigsymbols.py: Forbid passing 'HEAD' to --commit
>
>  scripts/checkkconfigsymbols.py | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
>
>
> base-commit: 36a21d51725af2ce0700c6ebcb6b9594aac658a6
> --
> 2.25.1
>


-- 
Best Regards
Masahiro Yamada