Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp2735526pxb; Tue, 24 Aug 2021 06:28:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxF9RBXvQ6o8NG2KoxQhDJS72R9S0EtewpKl5SzW3c8qioco8xw8RzoIov65NH42HQ0rR2R X-Received: by 2002:a05:6638:974:: with SMTP id o20mr34158586jaj.10.1629811727288; Tue, 24 Aug 2021 06:28:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629811727; cv=none; d=google.com; s=arc-20160816; b=AhRLwPb6b9gi2U2x78H+6nax5XyHR97bDO8CflPtdkno1wYIiTKdsNRTkD4btoze1+ 7CDxDiqKHg9lqiBEfBWLqNqA0ZeXfdG+XkWntHJl1MqELOVqczFOdvfY1LgSf7DLVKir ZiPzrj/lfy0g7j2XolCa6AcEgRAL6w9VWPz/KKGbzMB1pz/QcRyhm3ySlraalHlfHK74 14TeonD597vM7taTHfKn/EbOb286a5HzHQF7VnSEvU76dGJndNTToupkMx/L/ilWmg6J 2JAY6Xn1jJPCwEy+kmgO3/KVzzn/g8YCVwIRqg9EcAKrOHFvE41W4afC0BHUY5ukq6iq O6Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=mEX5GsDnBKUwBVC9nPw7/UhroQtKxIX0gjinMul8ucY=; b=k02gTnJWhzgBezFP/KM35LLTQ5lDGOLfGIi3wJssdoq0FIIkSz6mlXwSzyc54XRRT/ Z1WDTfNigh05HxteypXHlxblI1WAHyVZgBO51rGM9pwutPRMoiv0d64ooT86ab4Rkbmr uvuRB+i6XxFxHVNZrtXNkyySMEakUKudslDOtIzRRxsM9sTjclEShP/H1jMxg9IcQzuI GZP3MJ/6awt4jF5Hkm+Co9mrFm2hjhSKHOz8jiSs/cq4d+nLWo+Ww2DzcJPms8BfbGJs SD4sKFrd3YvXdxKbyaCPAQaUDIr/K2vomPv4ooMxWQQj56bW82J9XpMHLdgWC1Sp4q5L zDwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y59si18630624jah.22.2021.08.24.06.28.33; Tue, 24 Aug 2021 06:28:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237691AbhHXN1A (ORCPT + 99 others); Tue, 24 Aug 2021 09:27:00 -0400 Received: from pegase2.c-s.fr ([93.17.235.10]:39237 "EHLO pegase2.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237680AbhHXN0w (ORCPT ); Tue, 24 Aug 2021 09:26:52 -0400 Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Gv8y61vsKz9sVp; Tue, 24 Aug 2021 15:26:06 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W-FZZ7Hovc6V; Tue, 24 Aug 2021 15:26:06 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Gv8y60tq4z9sVf; Tue, 24 Aug 2021 15:26:06 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id ED4B68B80A; Tue, 24 Aug 2021 15:26:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id o_wlUGlayvSR; Tue, 24 Aug 2021 15:26:05 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id E91E38B824; Tue, 24 Aug 2021 15:26:04 +0200 (CEST) Subject: Re: [PATCH v2] powerpc/audit: Convert powerpc to AUDIT_ARCH_COMPAT_GENERIC To: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <877dgbc6vx.fsf@mpe.ellerman.id.au> From: Christophe Leroy Message-ID: <953a60d7-1004-676d-240e-17ddc3d4942d@csgroup.eu> Date: Tue, 24 Aug 2021 15:26:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <877dgbc6vx.fsf@mpe.ellerman.id.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 24/08/2021 à 15:24, Michael Ellerman a écrit : > Christophe Leroy writes: >> Commit e65e1fc2d24b ("[PATCH] syscall class hookup for all normal >> targets") added generic support for AUDIT but that didn't include >> support for bi-arch like powerpc. >> >> Commit 4b58841149dc ("audit: Add generic compat syscall support") >> added generic support for bi-arch. >> >> Convert powerpc to that bi-arch generic audit support. >> >> Signed-off-by: Christophe Leroy >> --- >> v2: >> - Missing 'git add' for arch/powerpc/include/asm/unistd32.h >> - Finalised commit description >> --- >> arch/powerpc/Kconfig | 5 +- >> arch/powerpc/include/asm/unistd32.h | 7 +++ >> arch/powerpc/kernel/Makefile | 3 -- >> arch/powerpc/kernel/audit.c | 84 ----------------------------- >> arch/powerpc/kernel/compat_audit.c | 44 --------------- >> 5 files changed, 8 insertions(+), 135 deletions(-) >> create mode 100644 arch/powerpc/include/asm/unistd32.h >> delete mode 100644 arch/powerpc/kernel/audit.c >> delete mode 100644 arch/powerpc/kernel/compat_audit.c > > This looks OK, but I don't know much about audit. > > Can you resend with the audit maintainers on Cc? > Sure.