Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp2785671pxb; Tue, 24 Aug 2021 07:34:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGVAUOHcJs22mv8t3H21BiGtBSxNOTF8OASI1qESlEW4oflbp2xm8jakjMT0D2Vj1x3LTe X-Received: by 2002:aa7:d9d2:: with SMTP id v18mr24404eds.128.1629815698798; Tue, 24 Aug 2021 07:34:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629815698; cv=none; d=google.com; s=arc-20160816; b=oxOyltMW/FzAwgtcXgElFA5K5hjFAcCLrUtRRp0tRsGQVMI1EQrEq2iixGTdrKN34S StCp7L4EKszd2fmBXc0AuJWJW5siEYNmqUHm0IZg2+uiI101QLm9LSW7mVO2F2gbMdMB YsrixpwvkvYy18/SxwbrwR0/NeimqsIV7tK+Yx0dS0Eb+gbTV7rqEo64QlkoDjoB56nZ 07N0Z/RBCby1py5dDdfD6cxSGp30wccTIl7pqz8Zd7Mx2j5m0vEcsblCPhHmxGmSmrHc VK3E5gmaPZv/lIqCx+vO45d7RTmdEffi7NhPFvGb6qr8aUxjS0ol4gZaaA0lCEBQQoDv 81WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=WAOiuATXevPHNBvPplmlBHr/FxqYY3GsxpXENpilWKY=; b=PpLdPgybhBFBqxFnRfs7o8DIcw1Mf/eio6A/0XV9TQXOCsmb8xmpwDwg2U4ZRmNbj7 B4z9SDsXx6UlglC+PmfTT6FhH74A/jYHQmXvHJsz5idl0tCvuaGvV9bPBVBfPT9xHwQ9 JsUbC9VbGEgjVVZ9SlhymIlL2nX8Qp9/+xgUUi1HLY2A7noVYjWOOLA2AJn3rWT5iq2l 6097hAIf75ZT20BhCnXcpXCqXtXIvUtp7ZMjPRnkuAOUyhQApM5W/d1j1NTg6pB2JaDk 9hAaQXl4S5GCkruXQUnxrsbi0U6iO/mP/DY27b2Y4pn/G2un77VdUftkLXDBChXv19Nb wYzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=WOyt9t0Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ee39si17303278edb.579.2021.08.24.07.34.34; Tue, 24 Aug 2021 07:34:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=WOyt9t0Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237749AbhHXOdr (ORCPT + 99 others); Tue, 24 Aug 2021 10:33:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237442AbhHXOdq (ORCPT ); Tue, 24 Aug 2021 10:33:46 -0400 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FB39C061757 for ; Tue, 24 Aug 2021 07:33:02 -0700 (PDT) Received: by mail-il1-x12c.google.com with SMTP id l10so6974198ilh.8 for ; Tue, 24 Aug 2021 07:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WAOiuATXevPHNBvPplmlBHr/FxqYY3GsxpXENpilWKY=; b=WOyt9t0ZSbCOg6SIqTfFuAaqsoP+napnQatblZNXOZv389nl83Ysmds3o/R/BCG8CR Ggl2Kqha7WNRG8f7ytT0aW2T0c8GwgW6Tz/kJo1FvpLknhg6m4T7xd6dVPsZQaUzP5Fj iD48EZsk/WB8RA54gj1+CIxY+j2fscClna/mY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WAOiuATXevPHNBvPplmlBHr/FxqYY3GsxpXENpilWKY=; b=drfoKtGvp1j+N6UI5R8xtUdEk7Wl+Eqpot5B2jLG2GGSocG5KLdRrtcwBFAHcYTYS5 waZRYhL9UwXA/5+6ioiaBK68iyl0oAj6NBlXUiH0yGXBIdsHQOw7JmsqEOibSStj1FA1 fuCn2ERkmLogTOEmCL1pqKcMcNB4f2UeIyHnotIDetFQay6ZCrndsb4Pa1COtRKv/bAj qpYKm1QaI//mIlhV8o55T1hlkUPDNUXkf0nnzL2eNB8h/SHFT31OKjiNNsjhGMz34vaT ffMkT+2ilbsO4hRd9rprgMBs3JheM/Xd6a+7mitZlL9KIB8xTg6UOs3t/ORHV/mTy8pO oUiQ== X-Gm-Message-State: AOAM530QMCUML7ujFIgqxlJXnk/3SpbEzcKLavQM0u6Hrmtjso9QJzSO c+khPQVks1xzOaUNUasgdo0wWQ== X-Received: by 2002:a92:c94e:: with SMTP id i14mr26842749ilq.143.1629815581534; Tue, 24 Aug 2021 07:33:01 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id 12sm6128492ilq.37.2021.08.24.07.33.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Aug 2021 07:33:01 -0700 (PDT) Subject: Re: [PATCH] selftests: openat2: Fix testing failure for O_LARGEFILE flag To: Christian Brauner , Aleksa Sarai Cc: Baolin Wang , shuah@kernel.org, Christian Brauner , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <1627475340-128057-1-git-send-email-baolin.wang@linux.alibaba.com> <01184d9e-477d-cbe4-c936-62b92e915911@linux.alibaba.com> <9411d418-567b-78f0-0e4d-30f08371c55a@linux.alibaba.com> <20210824112129.2t6lzqyf2dxllw4a@senku> <20210824113619.a3gyxlerst7tumzn@wittgenstein> From: Shuah Khan Message-ID: <11702c81-8b7c-bbe6-705a-f0fed5f10ba5@linuxfoundation.org> Date: Tue, 24 Aug 2021 08:33:00 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210824113619.a3gyxlerst7tumzn@wittgenstein> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/24/21 5:36 AM, Christian Brauner wrote: > On Tue, Aug 24, 2021 at 09:21:29PM +1000, Aleksa Sarai wrote: >> On 2021-08-23, Shuah Khan wrote: >>> Hi Baolin, >>> >>> On 8/22/21 8:40 PM, Baolin Wang wrote: >>>> Hi Shuah, >>>> >>>> On 2021/7/28 20:32, Baolin Wang wrote: >>>>> Hi, >>>>> >>>>>> When running the openat2 test suite on ARM64 platform, we got below failure, >>>>>> since the definition of the O_LARGEFILE is different on ARM64. So we can >>>>>> set the correct O_LARGEFILE definition on ARM64 to fix this issue. >>>>> >>>>> Sorry, I forgot to copy the failure log: >>>>> >>> >>> Please cc everybody get_maintainers.pl suggests. You are missing >>> key reviewers for this change. >>> >>> Adding Christian Brauner and Aleksa Sarai to the thread. >>> >>>>> # openat2 unexpectedly returned # 3['/lkp/benchmarks/kernel_selftests/tools/testing/selftests/openat2'] with 208000 (!= 208000) >>> >>> Not sure I understand this. 208000 (!= 208000) look sthe same to me. >>> >>>>> not ok 102 openat2 with incompatible flags (O_PATH | O_LARGEFILE) fails with -22 (Invalid argument) >>>>> >>>>>> >>>>>> Signed-off-by: Baolin Wang >>>> >>>> Could you apply this patch if no objection from your side? Thanks. >>>> >>> >>> Ideally this define should come from an include file. >> >> The issue is that O_LARGEFILE is set to 0 by glibc because glibc appears >> to hide the nuts and bolts of largefile support from userspace. I >> couldn't find a nice way of doing a architecture-dependent includes of >> include/uapi from kselftests, so I just went with this instead -- but I >> agree that a proper include would be better if someone can figure out >> how to do it. > From a quick look, it will take sone work to consolidate multiple O_LARGEFILE defines. > I'd just add arch-dependent defines for now and call it good. So seems > good enough for me: > > Thanks! > Acked-by: Christian Brauner > >> >>> Christian, Aleksa, >>> >>> Can you review this patch and let me know if this approach looks right. >> >> Reviewed-by: Aleksa Sarai Thank you for the patch and the reviews. I will apply this for 5.15-rc1 thanks, -- Shuah