Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] selftests: openat2: Fix testing failure for O_LARGEFILE
 flag
To:     Christian Brauner <christian.brauner@ubuntu.com>,
        Aleksa Sarai <cyphar@cyphar.com>
Cc:     Baolin Wang <baolin.wang@linux.alibaba.com>, shuah@kernel.org,
        Christian Brauner <christian@brauner.io>,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <1627475340-128057-1-git-send-email-baolin.wang@linux.alibaba.com>
 <01184d9e-477d-cbe4-c936-62b92e915911@linux.alibaba.com>
 <9411d418-567b-78f0-0e4d-30f08371c55a@linux.alibaba.com>
 <a9dc1616-61b9-c010-950c-521693c74247@linuxfoundation.org>
 <20210824112129.2t6lzqyf2dxllw4a@senku>
 <20210824113619.a3gyxlerst7tumzn@wittgenstein>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <11702c81-8b7c-bbe6-705a-f0fed5f10ba5@linuxfoundation.org>
Date:   Tue, 24 Aug 2021 08:33:00 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210824113619.a3gyxlerst7tumzn@wittgenstein>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/24/21 5:36 AM, Christian Brauner wrote:
> On Tue, Aug 24, 2021 at 09:21:29PM +1000, Aleksa Sarai wrote:
>> On 2021-08-23, Shuah Khan <skhan@linuxfoundation.org> wrote:
>>> Hi Baolin,
>>>
>>> On 8/22/21 8:40 PM, Baolin Wang wrote:
>>>> Hi Shuah,
>>>>
>>>> On 2021/7/28 20:32, Baolin Wang wrote:
>>>>> Hi,
>>>>>
>>>>>> When running the openat2 test suite on ARM64 platform, we got below failure,
>>>>>> since the definition of the O_LARGEFILE is different on ARM64. So we can
>>>>>> set the correct O_LARGEFILE definition on ARM64 to fix this issue.
>>>>>
>>>>> Sorry, I forgot to copy the failure log:
>>>>>
>>>
>>> Please cc everybody get_maintainers.pl suggests. You are missing
>>> key reviewers for this change.
>>>
>>> Adding Christian Brauner and Aleksa Sarai to the thread.
>>>
>>>>> # openat2 unexpectedly returned # 3['/lkp/benchmarks/kernel_selftests/tools/testing/selftests/openat2'] with 208000 (!= 208000)
>>>
>>> Not sure I understand this. 208000 (!= 208000) look sthe same to me.
>>>
>>>>> not ok 102 openat2 with incompatible flags (O_PATH | O_LARGEFILE) fails with -22 (Invalid argument)
>>>>>
>>>>>>
>>>>>> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>>>>
>>>> Could you apply this patch if no objection from your side? Thanks.
>>>>
>>>
>>> Ideally this define should come from an include file.
>>
>> The issue is that O_LARGEFILE is set to 0 by glibc because glibc appears
>> to hide the nuts and bolts of largefile support from userspace. I
>> couldn't find a nice way of doing a architecture-dependent includes of
>> include/uapi from kselftests, so I just went with this instead -- but I
>> agree that a proper include would be better if someone can figure out
>> how to do it.
> 

 From a quick look, it will take sone work to consolidate multiple
O_LARGEFILE defines.

> I'd just add arch-dependent defines for now and call it good. So seems
> good enough for me:
> 
> Thanks!
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
> 
>>
>>> Christian, Aleksa,
>>>
>>> Can you review this patch and let me know if this approach looks right.
>>
>> Reviewed-by: Aleksa Sarai <cyphar@cyphar.com>

Thank you for the patch and the reviews. I will apply this for 5.15-rc1

thanks,
-- Shuah