Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210810210319.6564-1-zhouzhouyi@gmail.com> <YRM5heBfgNtEGvoC@boqun-archlinux>
 <YST4aWMArEBsKW07@hirez.programming.kicks-ass.net>
In-Reply-To: <YST4aWMArEBsKW07@hirez.programming.kicks-ass.net>
From:   Zhouyi Zhou <zhouzhouyi@gmail.com>
Date:   Tue, 24 Aug 2021 22:43:18 +0800
Message-ID: <CAABZP2wtAVYmWfSBmJDyaLuTFQGq6KsN=3uogZtm8FK1_bAJAg@mail.gmail.com>
Subject: Re: [PATCH][RFC] lockdep: improve comments in wait-type checks
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Boqun Feng <boqun.feng@gmail.com>, mingo@redhat.com,
        will@kernel.org, longman@redhat.com, paulmck@kernel.org,
        Josh Triplett <josh@joshtriplett.org>,
        rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        "Joel Fernandes, Google" <joel@joelfernandes.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        rcu <rcu@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Thank both of you for correcting my mistakes.
I do benefit a lot from your emails.

Cheers
Zhouyi

On Tue, Aug 24, 2021 at 9:47 PM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Wed, Aug 11, 2021 at 10:44:21AM +0800, Boqun Feng wrote:
> > Hi,
> >
> > On Wed, Aug 11, 2021 at 05:03:19AM +0800, Zhouyi Zhou wrote:
> > > Hi Peter,
> > >   I think comments in wait-type checks may benifit from some comments
> > > improvement.
> >
> > Thanks for looking into this!
> >
> > Even for an RFC patch, it's better that you write a proper commit log,
> > and note that you can put all this background information right after
> > the "---" line, if you think that will help people review it.
> >
> > >   I recklessly add Paul to signed-off-by, because I asked his opinion
> > > about comment in rcu_read_lock_bh part.
> > >
> >
> > Probably a Suggested-by will suffice, but I leave that to Paul ;-)
>
> This, also since Paul never actually touched the patch.
>
> > > Thanks a lot
> > > Zhouyi
> > >
> > > Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
> > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> >
> > Please make you the last one in the "Signed-off-by" list, see
> > Documentation/process/submitting-patches.rst:
> >
> > "Notably, the last Signed-off-by: must always be that of the developer
> > submitting the patch."
>
> The first sob should be that of the author, and given that's the same
> person as the submitter in this case, he's got a problem at his hands
> ;-)
>