Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 24 Aug 2021 10:56:21 -0400
From:   Johannes Weiner <hannes@cmpxchg.org>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 2/4] mm: Kconfig: group swap, slab, hotplug and thp
 options into submenus
Message-ID: <YSUIlWMmRIIrEutE@cmpxchg.org>
References: <20210819195533.211756-1-hannes@cmpxchg.org>
 <20210819195533.211756-2-hannes@cmpxchg.org>
 <0c438e9d-7879-a1c1-7641-5c0dc00f5163@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0c438e9d-7879-a1c1-7641-5c0dc00f5163@suse.cz>
Precedence: bulk

On Tue, Aug 24, 2021 at 02:03:43PM +0200, Vlastimil Babka wrote:
> On 8/19/21 21:55, Johannes Weiner wrote:
> > There are several clusters of related config options spread throughout
> > the mostly flat MM submenu. Group them together and put specialization
> > options into further subdirectories to make the MM section a bit more
> > organized and easier to navigate.
> > 
> > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> 
> Acked-by: Vlastimil Babka <vbabka@suse.cz>

Thanks, Vlastimil!

> Note:
> 
> > -config ZBUD
> > -	tristate "Low (Up to 2x) density storage for compressed pages"
> > -	help
> > -	  A special purpose allocator for storing compressed pages.
> > -	  It is designed to store up to two compressed pages per physical
> > -	  page.  While this design limits storage density, it has simple and
> > -	  deterministic reclaim properties that make it preferable to a higher
> > -	  density approach when reclaim will be used.
> > -
> 
> The whole large hunk with deletion part of the block move will be rejected in
> current trees because this is apparently based on older commit than 2a03085ce887
> ("mm/zbud: don't export any zbud API") which adds a "depends on ZPOOL" to the
> above. It's thus also missing in the add hunk part of the move and if not
> careful when resolving the reject, the depend will then be missing in the result.

Thanks for the headsup. Yeah I forgot to rebase before sending from an
older branch, I'll be sure to do that (paying attention to the zpool
depends) before sending the next version.