Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 24 Aug 2021 10:44:53 -0500
From:   Steve Wahl <steve.wahl@hpe.com>
To:     CGEL <cgel.zte@gmail.com>
Cc:     Steve Wahl <steve.wahl@hpe.com>, Mike Travis <mike.travis@hpe.com>,
        Dimitri Sivanich <dimitri.sivanich@hpe.com>,
        Russ Anderson <russ.anderson@hpe.com>,
        Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org,
        linux-kernel@vger.kernel.org,
        Jing Yangyang <jing.yangyang@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] x86:uv: fix boolreturn.cocci warnings
Message-ID: <YSUT9S+uD8KyaqgR@swahl-home.5wahls.com>
References: <20210824072124.61750-1-deng.changcheng@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210824072124.61750-1-deng.changcheng@zte.com.cn>
Precedence: bulk

Reviewed-by: Steve Wahl <steve.wahl@hpe.com>

On Tue, Aug 24, 2021 at 12:21:24AM -0700, CGEL wrote:
> From: Jing Yangyang <jing.yangyang@zte.com.cn>
> 
> ./arch/x86/include/asm/uv/uv.h:36:53-54:WARNING:return of 0/1 in
> function 'is_early_uv_system' with return type bool
> 
> Return statements in functions returning bool should use true/false
> instead of 1/0.
> 
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn>
> ---
>  arch/x86/include/asm/uv/uv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/uv/uv.h b/arch/x86/include/asm/uv/uv.h
> index 648eb23..9395925 100644
> --- a/arch/x86/include/asm/uv/uv.h
> +++ b/arch/x86/include/asm/uv/uv.h
> @@ -33,7 +33,7 @@ static inline bool is_early_uv_system(void)
>  #else	/* !X86_UV */
>  
>  static inline enum uv_system_type get_uv_system_type(void) { return UV_NONE; }
> -static inline bool is_early_uv_system(void)	{ return 0; }
> +static inline bool is_early_uv_system(void)	{ return false; }
>  static inline int is_uv_system(void)	{ return 0; }
>  static inline int is_uv_hubbed(int uv)	{ return 0; }
>  static inline void uv_cpu_init(void)	{ }
> -- 
> 1.8.3.1
> 
> 

-- 
Steve Wahl, Hewlett Packard Enterprise