Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 24 Aug 2021 19:57:30 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Kari Argillander <kari.argillander@gmail.com>
Cc:     Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
        ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] fs/ntfs3: add checks for allocation failure
Message-ID: <20210824165730.GN7722@kadam>
References: <20210824115236.GJ31143@kili>
 <20210824160244.ruutwl3nq6b5feec@kari-VirtualBox>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210824160244.ruutwl3nq6b5feec@kari-VirtualBox>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (62.8.83.99) by JNAP275CA0001.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Tue, 24 Aug 2021 16:57:41 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1a275ba0-eae2-4c88-e477-08d967204aec
X-MS-TrafficTypeDiagnostic: CY4PR10MB1638:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CY4PR10MB1638535EDF5E2677D1DBF0D18EC59@CY4PR10MB1638.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rU+o6aOHqs+ZuPQAIayI6d8EbEUHzeEQNSSbAeu44JW8yppnnsyEwIdrr5tTDs6svXvgWd1p02/GFb3uExFvvV+V32HwjbMWTapqmeDrk3JdiAhgQ51xvJE+VfMiMXxib/JWV8XrU0KNipAjpRP+WlVw7UVR+Ui/LOcTcqTKPJhPR7dH5f6AmibPVoo1xeKPA+0VnjXMQ7ehPIyJnsdTMO5RJo0o/D00PMrhX7Z5+XlXjaZh3lcsBeDi3yBfcQAuK58WP1aBYDsbF5Dn77aPO171H7kwehLxPnsjc61t1/+nmDynSgRZ8bVa9KhGVKMW7nGKRIs7CP/WvemMIVZq3kWqracPtrhIQNvVmR3jcvBk6L7zQPAE36EDELT4mnumnlbJaKQYH7ppZbczeiZSJzsrULhmMh6QBhYCPiONZvl27FzKb//OBEQHZ1zuBcDJ9GpuEU+MC7HRLC4A6PXEh1Uqn6z3esutS9YUSa+Pp/YeXyTreFyV1tJ4cvbUqnZzo4tt2xpms6XQgLo0tP3wGdy7g3n/oGrhDw/qbZWOGn/3Vo4vbdJS9hdGrgXoMZdJZ+wBIraGNSsDMP1FQ3fWiESRQ/GwozrWngHfF9GEg4gA79jBD1DcSTGtMrvQIvg3pUELkpcBCOH3NOnVm71zIMh1UHd8LqIIiGN0DtI6ZY3OMnfO7uWOBu2V9x5b4wKRuQokRxFeGVjxgBgLiUloZg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR1001MB2358.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(396003)(136003)(376002)(39860400002)(346002)(4326008)(1076003)(9686003)(6496006)(186003)(26005)(8676002)(4744005)(55016002)(6916009)(478600001)(5660300002)(38100700002)(38350700002)(33716001)(316002)(52116002)(2906002)(86362001)(33656002)(8936002)(44832011)(956004)(66476007)(66556008)(6666004)(66946007)(9576002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hE8eEa9vxXBcBz4Nb63lBsRMG3wM6J7u/UdEdTrnWDlUevKfvI0mg1QkJXhI?=
 =?us-ascii?Q?x3hKyZq+CMD2DguVLCA/LuNSDUIJyNhplYodfiRqcexG62qy7teUIA0BoUnA?=
 =?us-ascii?Q?/Z9fCANfhhFKp1xhiXcEmfYu3QLZkoCyRNSnZ5FJWfO9TEIH/hcVJ16WlXwv?=
 =?us-ascii?Q?FPap05eq72KtLxJMe5V62umyYAOhLuGsvVf0RLbYktSuhBMhSUrCHZQu5f/E?=
 =?us-ascii?Q?8+JAIJqPsEske3XCHMtpPpjQ/C8DfZDV4uE5F+rHZR7UxY6ESSZdLaFlPGj7?=
 =?us-ascii?Q?lOrLvyjRIF+TIxewGITWQtV7roT0F5g4Tb8xmIYRFXx0t4XUN82R9/y6Ldsx?=
 =?us-ascii?Q?eapaBUAN1nPGx+2kTf+7EDqfXf5X+a24Skphc7b1AYdoVlqmEh0kA1MP0PLX?=
 =?us-ascii?Q?nXx3toAjsC3gQy167CRpPf/DYCzzjTWefuJa3zLHFPVmLCYnWgOFZ0za5nod?=
 =?us-ascii?Q?oZdTzx2tQzJLOm/LoXm9nVv7nTkILzTpMJVPfT9k28qYSvQEBKSRPLBBaXr8?=
 =?us-ascii?Q?Sd7y1WJssh6pv4Oc9gwOmJICUsb0tEe2IUVq666x83eOSIVWcUmhEcecgDvF?=
 =?us-ascii?Q?nC0yQUPiy85QdzgZgRxjojHieCC//byTfsyQAAbW8rYgWF2j3y8zIzos1E4H?=
 =?us-ascii?Q?Rf5eMISBseJHyt7KBItjwXcSvMH6qhvJMSsNc5rQP8yEbtOvskn4kBA6T2pc?=
 =?us-ascii?Q?AMLvbWEx/FCy9o5nZetMDh+RlYIywMyCBSzfmKEsd7S3ayJTJCpFfoPG7LFN?=
 =?us-ascii?Q?9K0qPzVGU0U/NtN/a1zqhxLrNVBEDn564fMZwlQkMzGs8umoUh1j1iYONwrF?=
 =?us-ascii?Q?fGSUX8M/NkizspfISC5bm5mOEOlk+SR+GuIuis5FnS6PSilKR6pSt2I7lGYc?=
 =?us-ascii?Q?h1S/alxV2KI4s7k1yvhJeQY9+VvgbbZDkRKYFnMBfGDiBAceAGPHljfHf5R9?=
 =?us-ascii?Q?X4vumjHskd/H2OD6hz+AmBAKuPdxik74YqweBc3Qx009jgTFwZeWf+Fdt1dR?=
 =?us-ascii?Q?HnzF1NbgqNqmt7SuJiRIa/G2CaSPvjRiQj3I86LKwa8Sd/9Gs9/469tcVtjX?=
 =?us-ascii?Q?nNnPoY0tO34VuJPunfz6QlTiPxnJ2YiBKGgl8ZOz+IpKJeINWAFTASy96zrW?=
 =?us-ascii?Q?TU1QhWJJrKa3duMNG8MTylfonedIudcym0Ptu9oEJBrlH67zkmXgW5YjlTC+?=
 =?us-ascii?Q?WrtAuBb7WUIWqX6DhEvXe4NeRT8n1eW/UxqzkfRuG0cbUBI2i8bKestYcb8T?=
 =?us-ascii?Q?3NwZHrncAVUS3VFrtlN12rbfv6fcVQ0oG2tmqexVIasdOeuNjwkDT/bZp+gn?=
 =?us-ascii?Q?0F1MiBdzDHtKLYJgsJKz2P+b?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a275ba0-eae2-4c88-e477-08d967204aec
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1001MB2358.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2021 16:57:44.8176
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /HLT5de/c7YhS/HNu2WH0klZzTGFuahjyQDspWGG5ZnYqF2U7gTL7TxExkLJNwaXILWH2Ppqw/8BLm/QfhD+4cx0AylCwWY+zlOkAosIiSI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1638
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10086 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0
 mlxlogscore=999 bulkscore=0 mlxscore=0 adultscore=0 malwarescore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2108240111
X-Proofpoint-GUID: b9lUN4Iyepyl9q6_Q3gtpFRbqsD5RRLC
X-Proofpoint-ORIG-GUID: b9lUN4Iyepyl9q6_Q3gtpFRbqsD5RRLC
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 24, 2021 at 07:02:44PM +0300, Kari Argillander wrote:
> On Tue, Aug 24, 2021 at 02:52:36PM +0300, Dan Carpenter wrote:
> > Add a check for when the kzalloc() in init_rsttbl() fails.  Some of
> > the callers checked for NULL and some did not.  I went down the call
> > tree and added NULL checks where ever they were missing.
> > 
> > Fixes: b46acd6a6a62 ("fs/ntfs3: Add NTFS journal")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Seems ok. It is not easist file to follow. log_replay is monster and
> it should be refactor in some point. I'm certain that many more bugs
> will be founded there. Also at least community does not have very good
> testing interface for this. 

There is a way to do allocation fault injection, but I haven't messed
with it.

My guess is that syzbot will soon start reporting a ton of bugs.  ;)

regards,
dan carpenter