Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp2910069pxb; Tue, 24 Aug 2021 10:23:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxB8bX/RXin4KyJhGs/1a2QNQ4SpMCEhULj0CzcMxLR5oz0qba6mcNLQCWSWIHRZUKwwV2w X-Received: by 2002:a17:907:9604:: with SMTP id gb4mr42295415ejc.142.1629825799050; Tue, 24 Aug 2021 10:23:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629825799; cv=none; d=google.com; s=arc-20160816; b=cvKX61HWf0c7sRZqx1bu0zvGcXVuMp7trMH44ZPA2fnSoAn27M5Zh/y5jviuqQ3ggk 7btX4MNcHiXrBWJ+wszZicfYKGLlXl4QERL85o06iirOzr6noH8isK08/kxxLePC8b+Y 76S6Z7WDo3t+QAfGWMxVk+jnflwHaufEixio6eUcpnDU2ggYHLtTfYkiU4/9T2D4wEy0 rLBICgmpiVjrsn2TIr20roqJbBpSSzNEMzoUbaMIOSXU3laKkQOruQiw76c2Oc1j6y7q JVarMHYIUHTIs77hdUy9H2ffWPp6L/dIBmSXkG7kothVhJU3PQ8Ji/wmeXy5ZJGwFgps Q1ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0lfOa3OsIOjhfZFxk2TG/uLLjq6n0gNoRAIUbhNh3C8=; b=S0nsXtIci6s0vTZPUI40PRRT8yHbSqgD0wXL9fxTjgQAyxW7ioDajnS/FAb3TSLVk3 2GrrCHeoOtSMf7qLB3zfUHhSWSQ4657aeXeQqKlDXxsUgkxpE1fmxoo6KzjLgDu52wnt AntJO1J4rfCFuzvTr6wSfGXm0G6rCAhOK1F9GucWW/kbpuAq425AfZsVD0VsgbeoPXGb O/xitdXlIj2qs1rs0chmE0nPtziTYsHZGgtPkpUqvRgweLwmZ1xBmqYZwE+ZVqGthA1S 5yzLkiw/+lHSJkZvhDtinzlswECvoF88/8ROvfBoH+PokoR4yQ5CTGmLxgU1imHI4HXJ +X+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="oZsAjq/3"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e10si22798943edj.183.2021.08.24.10.22.55; Tue, 24 Aug 2021 10:23:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="oZsAjq/3"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234884AbhHXRWP (ORCPT + 99 others); Tue, 24 Aug 2021 13:22:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:55624 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238767AbhHXRSy (ORCPT ); Tue, 24 Aug 2021 13:18:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AF96961AD1; Tue, 24 Aug 2021 17:03:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629824581; bh=r96vHC86Y2bXWDYzoPukiUPUe4HKP48t4e4w71DbyD0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oZsAjq/32VJZQRmGSnn+nd4ZeVbg+PiVS0U/W5fpywRnr3mPMnemse9Fh/+0yL3ia tsl2kveaO/wIt2kguE7xxfvuAg6/L/aQtA5ueQfGsRM3PsrBsk3VyvGyZz6+ft7ROV mbAGn95z0hqEqSCIVhOwQ4DJBawyUA5b1ELUtMoN/JgoSyQJr1v83pS1ZVUG+itrnx G5UTuSYU4dCgY4/bvEeIfLlZgpaBXRTXF8KzorQMz6gmMPn8SDmNXjYS7XAAyG1R5w onHJLgPE4awp8iH+6rtKIUL/CJCZCyhd10CbOkCP9HWoy7xSee6tLLl1IKIiEkw9E5 xdt8UjRy1dQdg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Richard Fitzgerald , Mark Brown , Sasha Levin Subject: [PATCH 4.19 09/84] ASoC: cs42l42: Don't allow SND_SOC_DAIFMT_LEFT_J Date: Tue, 24 Aug 2021 13:01:35 -0400 Message-Id: <20210824170250.710392-10-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210824170250.710392-1-sashal@kernel.org> References: <20210824170250.710392-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.205-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.19.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.19.205-rc1 X-KernelTest-Deadline: 2021-08-26T17:02+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Richard Fitzgerald [ Upstream commit 64324bac750b84ca54711fb7d332132fcdb87293 ] The driver has no support for left-justified protocol so it should not have been allowing this to be passed to cs42l42_set_dai_fmt(). Signed-off-by: Richard Fitzgerald Fixes: 2c394ca79604 ("ASoC: Add support for CS42L42 codec") Link: https://lore.kernel.org/r/20210729170929.6589-2-rf@opensource.cirrus.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/cs42l42.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 6a58c666776a..ca6541ac59e1 100644 --- a/sound/soc/codecs/cs42l42.c +++ b/sound/soc/codecs/cs42l42.c @@ -773,7 +773,6 @@ static int cs42l42_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt) /* interface format */ switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { case SND_SOC_DAIFMT_I2S: - case SND_SOC_DAIFMT_LEFT_J: break; default: return -EINVAL; -- 2.30.2