Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp2915225pxb; Tue, 24 Aug 2021 10:30:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzq5iDUj2LOyHQS9TfGqep1DIgkzzryO2SIn8rSmDFu5TqKLA8qvLEhgysv0bUDJu03zP4c X-Received: by 2002:a17:906:1382:: with SMTP id f2mr34305808ejc.536.1629826207725; Tue, 24 Aug 2021 10:30:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629826207; cv=none; d=google.com; s=arc-20160816; b=TUlJF1qm3T0INuft3GSzR4MDKSEXOH7Qpj9peJdbgi96k3fCnslzTymMQe4El/UBvA mPv5YJZzjPxfXwe9v7W/TAnB8GGGP7+49q0DPkB76Bua6Oi4QUhvdj86I93HWUo6dQoj jzgAPo3VUqJhDrFMzM3Mu8OL3O7bdzyxpwbnNsUClY9azK4zHRXT5VRe82gJ6GvzS0lf 2byc0nBpqVW4o/96LTN0yyf9+HBy6anUL1GyVzRyLTqA1DVSeyNyn7D9kVgL1KVbqXbG xPnJeOebDCP7s2y9XCT9n9nayAWeMtHyB+TiqWYp8y5P4gMN+EB+eJQlZaQwEll8PGrc ZOJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RYAvn/uy+QDIiwK16O0gfUbHVDtofDrQPnxsWQfhDXc=; b=h4ZkfOM8pqiPA/RDrnkI3npfQ+LkTZWH6jn0rsT58fEH6AYKr0PJeEwR5mMpJ9h7xc hmWWL4G/xhaps90WucUvq96XvtrYlvxaO2UlkCt+XCFLCVTLogziUvsfhC0PrVVtk4op Iw+vFMp8GNcu26PqGPoOQoTeaqQ6GWRUIj+1nZMvqTz/y3qcO4EHDiuuHkKhcx+RdDGh LQotA2bXsWewYhX+ixdlqSb0n7upLRdyeB2xHcqQnGMd4A5JWjJQMTSAeJvPfjF0dct7 GqwcdoKeIr/iaQhG7Zu90hP3q0PkbZY87vMI8KtjO7KumgYzdxxmpicn85ZUrnnXzhsj IqWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tUll0xQ6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i4si6666854edq.13.2021.08.24.10.29.43; Tue, 24 Aug 2021 10:30:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tUll0xQ6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241093AbhHXR3E (ORCPT + 99 others); Tue, 24 Aug 2021 13:29:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:35803 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240264AbhHXR1D (ORCPT ); Tue, 24 Aug 2021 13:27:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 737EF61B65; Tue, 24 Aug 2021 17:05:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629824706; bh=/FBBv4v2oXgBpv36XmecER7xB6IkFHW7SsmoN8s1vh8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tUll0xQ6nafYb5DMyvCJZ7VLl2P6w8ADpTCKEfbbqvNR32+Y6bX6L4sLz8agfe7Aq brFuLTmpyoS6q5G5vlPNkfl3MXMYk596BGgy0NLYMElESI05mtu/O33+KR436u4qvG /+bHx2kv1Ax2robqqIKQ/NQbuP5Kqr6z1PTc+pCGQIxOOTSzgVChqe1p8QuR3WxkwA 8JubXMYAqvYHUEf+7te81RuRl31djt+rkiI/qQp2Z6JAegLEy28jTvHKaToA6Ja93s oiQctAinYkJDjfmIufCgOsnYY+uR1Ein3f5hJY1hBQe0cF2R7SFfBKsJyb8XiOy8pl lWochN+l+wKnQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Richard Fitzgerald , Mark Brown , Sasha Levin Subject: [PATCH 4.14 07/64] ASoC: cs42l42: Don't allow SND_SOC_DAIFMT_LEFT_J Date: Tue, 24 Aug 2021 13:04:00 -0400 Message-Id: <20210824170457.710623-8-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210824170457.710623-1-sashal@kernel.org> References: <20210824170457.710623-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.245-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.14.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.14.245-rc1 X-KernelTest-Deadline: 2021-08-26T17:04+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Richard Fitzgerald [ Upstream commit 64324bac750b84ca54711fb7d332132fcdb87293 ] The driver has no support for left-justified protocol so it should not have been allowing this to be passed to cs42l42_set_dai_fmt(). Signed-off-by: Richard Fitzgerald Fixes: 2c394ca79604 ("ASoC: Add support for CS42L42 codec") Link: https://lore.kernel.org/r/20210729170929.6589-2-rf@opensource.cirrus.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/cs42l42.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 1d997b2df477..bcfc32efef07 100644 --- a/sound/soc/codecs/cs42l42.c +++ b/sound/soc/codecs/cs42l42.c @@ -793,7 +793,6 @@ static int cs42l42_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt) /* interface format */ switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { case SND_SOC_DAIFMT_I2S: - case SND_SOC_DAIFMT_LEFT_J: break; default: return -EINVAL; -- 2.30.2