Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp2937295pxb; Tue, 24 Aug 2021 10:59:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzk5JfbQpuq2wS8YBtvwzc/KSDkJ18cU8tU5Il0GTpMUhhaqAhjXTenE7QLDeqzehN20dVT X-Received: by 2002:a92:cac8:: with SMTP id m8mr18625151ilq.100.1629827991444; Tue, 24 Aug 2021 10:59:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629827991; cv=none; d=google.com; s=arc-20160816; b=FIfQrvENUwj4QaF3tVRZdP6lE1v/naz/FFrhVkn1EdcT7e1Ujzg1RnMqiTJvQpXxLz +qbLhjTAyH6IN5TKU/oOGPQdmXR6cQtSBvMP2/ux1B8Z4UYFnNok3S/8k6xGFNkiNGq/ oODZ1g3h0YViElpJy1jK4lx06yHbNi3qky8Rf1M8uV5XIbD6Z6zUyML77aoVKVva4ND6 f0uBwNThnoeMZ2QWSOYpNCiQNonVtTr81BeQzIuI9vOeXLADhXyEZfSE3G8iX1BOl94D QfG3Fy6w7cYvSROI+lz5RNCZJdHBZknYRsOn4xedk0ssS4Po11OERIzReLVH5xAxe00H CGTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jGPNz1d1oh7DcrnhSplS+AVN5zxduqMoVYa9ZotWhAs=; b=f+EQQLFz1x2tip3f6+5cNrZJfClzBphe3xZpV661WTEDxM1hrIk5d+lKo8u8Izx6O+ xIn6HJYrogS9gZ2evPVIgx4ZNHbtoWJO37yNG9VIp3cDdbRoiBMIcs/v0kRX4Nt60qKs Qq9Fe9fUmDziEKKCB6cWuNFSAlHqe90xnFIXArzm3e21p/PtAfYcS8dA4YMGhkMSgBCK P8z4Cr2K/Tr0V9vrveDxHOOv8zvbJQXrB6UJKXo9Z2/4PXL/Kp+AUXsSMD03SDtBjKsO cb8cR6qkUr6XTu+pPPu2fQwhKiFo08aR6/kNXw9vrHdC56z5BB4QMRbfQE+TkV2M7v51 DO0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=Q6+bFYmw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a3si17873728ilq.96.2021.08.24.10.59.39; Tue, 24 Aug 2021 10:59:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=Q6+bFYmw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239634AbhHXR6n (ORCPT + 99 others); Tue, 24 Aug 2021 13:58:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237947AbhHXR6g (ORCPT ); Tue, 24 Aug 2021 13:58:36 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29BE3C0DCB12 for ; Tue, 24 Aug 2021 10:35:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jGPNz1d1oh7DcrnhSplS+AVN5zxduqMoVYa9ZotWhAs=; b=Q6+bFYmwq8U7Vk+vRcaYzsfWJB B3AKK6w9Ke+fU8BZZgS1z8l3LkPp3EVlp93W0gQNgDGObrwnouFVUAou76dNFsGVOidIfkBnD0DFw sNg6zuzav6ds+Xw8trLwYeMCWieayhdpZwlVBNp50TDa0Zt5SOFKanS969ICYA5WKtzGeu6mynWu3 3LjnUmxbyU5sOA0uaklQKlnHI32h6GhipRs2HkvTZm5QXZ0iQPJ27ZbeQ176P/tTGLYV5OFrvsJb+ GhkR6i0ieHMNWInQcxgOIYDBIOUgDOvNWvwyJ4QI6CnIaImidmvYmJG2kQsSXOvbToFNvQ8mXC/EL D/hpYt8Q==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIaKe-00CeUi-3I; Tue, 24 Aug 2021 17:35:28 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id A16D0981196; Tue, 24 Aug 2021 19:35:27 +0200 (CEST) Date: Tue, 24 Aug 2021 19:35:27 +0200 From: Peter Zijlstra To: Linus Torvalds Cc: Dave Jones , Linux Kernel , Johannes Weiner Subject: Re: 5.14-rc breaks iotop swap io monitoring. Message-ID: <20210824173527.GA17784@worktop.programming.kicks-ass.net> References: <20210824031648.GA2725@codemonkey.org.uk> <20210824151943.GA386@codemonkey.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 24, 2021 at 09:34:02AM -0700, Linus Torvalds wrote: > Even if you enable it at run-time, processes that have been started > before it was enabled won't actually have the 'tsk->delays' > allocation. So I'm not sure how effective the run-time thing is. Right; we *could* fix that by looping through the tasklist; grabbing a task ref, doing the alloc and restarting until we've iterated the whole tasklist and not found a task without a delays thing. Didn't think it would be worth it, but can be done..