Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 24 Aug 2021 15:03:07 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc:     Nghia Le <nghialm78@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@redhat.com,
        Namhyung Kim <namhyung@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf tools: Add missing newline at the end of file
Message-ID: <YSU0W9L/TWhyQd6y@kernel.org>
References: <20210824085947.224062-1-nghialm78@gmail.com>
 <CAKXUXMzbJRHyUpFLGk8SBJHrkmkwq4VtfXmgvZtUBJGiED8qxw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKXUXMzbJRHyUpFLGk8SBJHrkmkwq4VtfXmgvZtUBJGiED8qxw@mail.gmail.com>
Precedence: bulk

Em Tue, Aug 24, 2021 at 04:37:19PM +0200, Lukas Bulwahn escreveu:
> On Tue, Aug 24, 2021 at 11:00 AM Nghia Le <nghialm78@gmail.com> wrote:
> >
> > Add missing newline at the end of file parse-sublevel-options.h.
> > Thus removing relevant warning reported by checkpatch.
> >
> > Signed-off-by: Nghia Le <nghialm78@gmail.com>
> 
> Reviewed-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>


Thanks, applied.

- Arnaldo

 
> This addresses the only instance of a "no newline at the end of the
> file" throughout the kernel tree.
> 
> This is part of a larger effort to identify all rules that checkpatch
> warns about and that are never false positives (compared to the many
> rules in checkpatch that are heuristics or are known to be ignored by
> the current development community and hence, cause many false
> positives). We could use such rules to be enforced in the submission
> process.
> 
> Lukas
> Lukas
> > ---
> >  tools/perf/util/parse-sublevel-options.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/parse-sublevel-options.h b/tools/perf/util/parse-sublevel-options.h
> > index 9b9efcc2aaad..578b18ef03bb 100644
> > --- a/tools/perf/util/parse-sublevel-options.h
> > +++ b/tools/perf/util/parse-sublevel-options.h
> > @@ -8,4 +8,4 @@ struct sublevel_option {
> >
> >  int perf_parse_sublevel_options(const char *str, struct sublevel_option *opts);
> >
> > -#endif
> > \ No newline at end of file
> > +#endif
> > --
> > 2.25.1
> >

-- 

- Arnaldo