Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 25 Aug 2021 00:45:37 +0530
From:   Utkarsh Verma <utkarshverma294@gmail.com>
To:     Johan Hovold <johan@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: Re: [PATCH] USB: serial: iuu_phoenix: Replace symbolic permissions
 by octal permissions
Message-ID: <20210824191537.GA6181@uver-laptop>
References: <20210820190306.18149-1-utkarshverma294@gmail.com>
 <YST6XZ/XJkTDm6rV@hovoldconsulting.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YST6XZ/XJkTDm6rV@hovoldconsulting.com>
Precedence: bulk

On Tue, Aug 24, 2021 at 03:55:41PM +0200, Johan Hovold wrote:
> On Sat, Aug 21, 2021 at 12:33:06AM +0530, Utkarsh Verma wrote:
> > This fixed the below checkpatch issue:
> > WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
> > Consider using octal permissions '0644'.
> 
> Please do not run checkpatch.pl on code that's already in the tree. Use
> it for your own patches before submitting them and always use your own
> judgement when considering its suggestions.
> 

Okay, I will not run checkpatch on the code that's already in the tree.

> This code does not need to be changed.
> 

But using the octal permission bits makes the code more readable. So I
made the change.
But if you don't want such changes, I will refrain from doing it in the
future.
Anyway thanks for the review.


Regards,
Utkarsh Verma