Message-ID: <4575A170.2030805@redhat.com>
Date: Tue, 05 Dec 2006 11:42:24 -0500
From: =?UTF-8?B?S3Jpc3RpYW4gSMO4Z3NiZXJn?= <krh@redhat.com>
User-Agent: Thunderbird 1.5.0.5 (X11/20060803)
MIME-Version: 1.0
To: David Miller <davem@davemloft.net>
CC: benh@kernel.crashing.org, linux-kernel@vger.kernel.org,
       stefanr@s5r6.in-berlin.de
Subject: Re: [PATCH 0/3] New firewire stack
References: <20061205052229.7213.38194.stgit@dinky.boston.redhat.com>	<1165297363.29784.54.camel@localhost.localdomain> <20061204.230502.35014139.davem@davemloft.net>
In-Reply-To: <20061204.230502.35014139.davem@davemloft.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1568
Lines: 40

David Miller wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Date: Tue, 05 Dec 2006 16:42:42 +1100
> 
>>  - It's horribly broken in at least two area :
>>
>>  DO NOT USE BITFIELDS FOR DATA ON THE WIRE !!!
>>
>>  and
>>
>>  Where do you handle endianness ? (no need to shout for
>>  that one).
>>
>> (Or in general, do not use bitfields period ....)
> 
> Yes, this is a show stopper, the endianness and
> word-size/endian testing should have been done before
> submission.

I guess my mistake here was to present it as a patch submission.  I 
acknowledged in my cover letter that it wasn't feature complete and I'm not 
pushing for inclusion just yet.  I'm very much aware of the point that when 
replacing a subsystem like this, the new code has to be as good as the old 
code.  In that respect, the patches I posted are lacking in other areas 
(isochronous streaming is the big one) that will take more work to fix than 
just making it work on big-endian and 64-bit architectures.  It's still a work 
in progress.

Having said that, I've been working on this for a while now, and I wanted to 
announce the effort and open the discussion about replacing the old stack. 
Something about "release early, release often"... :)  Anyway, I've moved the 
portability issues to the top of my list now.

Kristian

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/