Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   SeongJae Park <sj38.park@gmail.com>
To:     =?UTF-8?q?Valdis=20Kl=C4=93tnieks?= <valdis.kletnieks@vt.edu>
Cc:     SeongJae Park <sj38.park@gmail.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Thara Gopinath <thara.gopinath@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: qcom-cpufreq-hw: Fix 'make allmodconfig' build
Date:   Wed, 25 Aug 2021 06:41:30 +0200
Message-Id: <20210825044130.14795-1-sj38.park@gmail.com>
MIME-Version: 1.0
In-Reply-To: <8784.1629857764@turing-police>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

From: SeongJae Park <sjpark@amazon.de>

On Tue, 24 Aug 2021 22:16:04 -0400 "Valdis Klētnieks" <valdis.kletnieks@vt.edu> wrote:

> On Tue, 24 Aug 2021 09:14:30 -0000, SeongJae Park said:
> 
> > > > ERROR: modpost: "cpu_scale" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined!
> > >
> > > That's a different patch, am working on fixing that one now..
> >
> > I didn't take a deep look here, so I unsure if this is an appropriate fix, but
> > I was able to work-around this issue for my use case with below change.
> >
> 
> >  DEFINE_PER_CPU(unsigned long, cpu_scale) = SCHED_CAPACITY_SCALE;
> > +EXPORT_PER_CPU_SYMBOL_GPL(cpu_scale);
> 
> Aha.  That's the part I wasn't finding.  Would you like to submit your patch,
> or shall I send it in with a "Suggested-by" for you?

I'd prefer 'Suggested-by', as I didn't take a deep look here.

Suggested-by: SeongJae Park <sjpark@amazon.de>


Thanks,
SJ