Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 24 Aug 2021 21:44:38 -0700 (PDT)
Subject:     Re: [PATCH v2 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1
In-Reply-To: <20210804123015.807929-1-bmeng.cn@gmail.com>
CC:     Conor.Dooley@microchip.com, Atish Patra <Atish.Patra@wdc.com>,
        linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
        geert@linux-m68k.org, bin.meng@windriver.com,
        conor.dooley@microchip.com
From:   Palmer Dabbelt <palmer@dabbelt.com>
To:     bmeng.cn@gmail.com
Message-ID: <mhng-8451ce80-2f44-40f0-945c-f2fd13a80bd7@palmerdabbelt-glaptop>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 04 Aug 2021 05:30:14 PDT (-0700), bmeng.cn@gmail.com wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> Per the DT spec, 'local-mac-address' is used to specify MAC address
> that was assigned to the network device, while 'mac-address' is used
> to specify the MAC address that was last used by the boot program,
> and shall be used only if the value differs from 'local-mac-address'
> property value.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> Reviewed-by: conor dooley <conor.dooley@microchip.com>
> ---
>
> (no changes since v1)
>
>  arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> index 0659068b62f7..a9c558366d61 100644
> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> @@ -317,7 +317,7 @@ emac1: ethernet@20112000 {
>  			reg = <0x0 0x20112000 0x0 0x2000>;
>  			interrupt-parent = <&plic>;
>  			interrupts = <70 71 72 73>;
> -			mac-address = [00 00 00 00 00 00];
> +			local-mac-address = [00 00 00 00 00 00];
>  			clocks = <&clkcfg 5>, <&clkcfg 2>;
>  			status = "disabled";
>  			clock-names = "pclk", "hclk";

Thanks, these are on fixes.