Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 25 Aug 2021 08:12:55 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Tang Bin <tangbin@cmss.chinamobile.com>
Cc:     davem@davemloft.net, wg@grandegger.com, kuba@kernel.org,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: mscan: mpc5xxx_can: Remove useless BUG_ON()
Message-ID: <20210825061255.nhkg3yobirnn75c7@pengutronix.de>
References: <20210823141033.17876-1-tangbin@cmss.chinamobile.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kwyhwexn7jes4aja"
Content-Disposition: inline
In-Reply-To: <20210823141033.17876-1-tangbin@cmss.chinamobile.com>
Precedence: bulk


--kwyhwexn7jes4aja
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 23.08.2021 22:10:33, Tang Bin wrote:
> In the function mpc5xxx_can_probe(), the variale 'data'
                                               ^b

Fixed typo while applying.

> has already been determined in the above code, so the
> BUG_ON() in this place is useless, remove it.
>=20
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
>  drivers/net/can/mscan/mpc5xxx_can.c | 1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can/mscan/=
mpc5xxx_can.c
> index 3b7465acd..35892c1ef 100644
> --- a/drivers/net/can/mscan/mpc5xxx_can.c
> +++ b/drivers/net/can/mscan/mpc5xxx_can.c
> @@ -317,7 +317,6 @@ static int mpc5xxx_can_probe(struct platform_device *=
ofdev)
> =20
>  	clock_name =3D of_get_property(np, "fsl,mscan-clock-source", NULL);
> =20
> -	BUG_ON(!data);
>  	priv->type =3D data->type;
>  	priv->can.clock.freq =3D data->get_clock(ofdev, clock_name,
>  					       &mscan_clksrc);

Thanks,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--kwyhwexn7jes4aja
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmEl32QACgkQqclaivrt
76mchAf+NffU83nHOfdrqDPqYDX7v53Hf3NOoRhQNfP+vK8QKW5ZQymf7bYzdYBp
LpwVyT1Udgu48ldFLIe0MJtD4JV5RWVtmnnrX1dh8+58xxjrul2l1zEhRWWieQ6p
8QA0782HJdUk9UXDNiUnRNOUcWKkKjlwSERyaQE/1YVKaZv4ZnFo5DXhdkKtZYW6
7wqDpkq5V2puoWIvHHqf3MGSowz/y9AruLLEPfhGTLI+t4DNAjPC9pcmpMNg7f1d
CeNmzEzUg5qmcXEQGziytWt1ECBzS/A9ihhAJVwp2tjIiQXT/HSeoypcx+uCozzM
4eH69CYs6kuPC1OUkp+DMehqeLV1sA==
=ft+K
-----END PGP SIGNATURE-----

--kwyhwexn7jes4aja--