Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <9e78ecd5b79ed7f0ca91021799e6e7396c458094.camel@gmail.com>
Subject: Re: [PATCH v1 2/2] mmc: core: Let BKOPS timeout readable/writable
 via sysfs
From:   Bean Huo <huobean@gmail.com>
To:     Ulf Hansson <ulf.hansson@linaro.org>
Cc:     Adrian Hunter <adrian.hunter@intel.com>,
        linux-mmc <linux-mmc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Bean Huo <beanhuo@micron.com>
Date:   Wed, 25 Aug 2021 10:43:31 +0200
In-Reply-To: <CAPDyKFrQLDiamWZGzDDoA0EeRhR+VaeWuUHiu9EAMqDrQT-5CA@mail.gmail.com>
References: <20210817224208.153652-1-huobean@gmail.com>
         <20210817224208.153652-3-huobean@gmail.com>
         <CAPDyKFrQLDiamWZGzDDoA0EeRhR+VaeWuUHiu9EAMqDrQT-5CA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2021-08-24 at 16:33 +0200, Ulf Hansson wrote:
> On Wed, 18 Aug 2021 at 00:42, Bean Huo <huobean@gmail.com> wrote:
> > From: Bean Huo <beanhuo@micron.com>
> > 
> > For special cases, the application in the userspace wants to change
> > BKOPS operation timeout value, also, wants eMMC back to
> > R1_STATE_TRAN
> > after BKOPS timeouts. A fixed BKOPS timeout value(120s) is no
> > longer
> > feasible, therefore, it is better to let the user controls its
> > timeout
> > value.
> 
> I am not fond of exporting tweakable timeout values through sysfs.
> Primarily because it's ABI and it becomes difficult to change.
> 
> Can you perhaps explain in more detail when you want to have a
> different timeout?
> 
> Perhaps we can do something similar as we currently do for
> mmc_santize(), where we allow userspace to pass the cmd-timeout?
> 
> Kind regards
> Uffe
> 
> > Signed-off-by: Bean Huo <beanhuo@micron.com>
> > 

Hi Ullf,
Thanks for your review. 

Actually, taking the first patch "MMC: core: Issue HPI in case the
BKOPS timed out" is good enough in the most of cases. And the current
120s timeout for the manual BKOPS is also enough, we don't need to
change this timeout value through sysfs.

Kind regards,
Bean