Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp237504pxb; Wed, 25 Aug 2021 01:56:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOE/wBY2Sg3ETitARP0oMVUBK+mSo/yQ1cKNnBwYG4EPNNlURum15tb43W8HhUdHAVVMBn X-Received: by 2002:a05:6402:148:: with SMTP id s8mr48044477edu.298.1629881772323; Wed, 25 Aug 2021 01:56:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629881772; cv=none; d=google.com; s=arc-20160816; b=C6DNDwmjdGdrHfD+u0jErS3n7ZzaBh/3xjgpy7ocjitHQEX18yt89dPls9DS+Cn2od Ru//4N8cAkWK1WIvyLdUZv/8DYUuXpkYDTp7YMKQcIudQeracAs26eIxd+orxIRIU1io GnbmG59Xvy9bUPM2fm+dG/BoLpPIX2P+uVC2psoXNYePl9X9dm8xA4hcbstNK1LeVVWr H3DtntesWGur65z2tbn7AO5orGoujyKZd9g0EONcGvfORe35Ay9iSmPPSHYJ2voC82Mt z6u8gcDhGUlv5x6iI0NZz5Pv25w1UQjig6GuzIBLCIm+RivzkDxdXeksAROxtePV2dSE slKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=GHQDac8rAJr8d+DiBZ/kM/tYDn0HuWPrMNwwFnLhhc8=; b=CIF1zWv0jXWs4ET+OFHOs9llHa+2W7TjZThshZ3GixcPneR0EqecQjX9Zh2TZcEzUt j0CdCoCH1ryO63lHfE8bYsDBtCfoI2DGyUl3t76hkO2tRPXCk1De/iinkFi7L6cLRUmp vy9Ggvwcat10/Nb27mgFGcOZXLzhxp41VgJewzERUgpqdhZ7wU8dg6lxLkVkZHidOUVr Vw9nB01aMSEGngtgb7vyTyHmy7cZ0y69gU4g4F6fvIzb6N02PB2Zvep0HmtmQIgt0ZuK 2rwWYxGnC8/oxQv4191d8Z82hcZ37JFBV9c9wOFZVn0tymPOqK2bfxMvs9cN14Ak6ZHN x/qg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m7si3179776edq.197.2021.08.25.01.55.48; Wed, 25 Aug 2021 01:56:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232306AbhHYIye (ORCPT + 99 others); Wed, 25 Aug 2021 04:54:34 -0400 Received: from verein.lst.de ([213.95.11.211]:55333 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231963AbhHYIyd (ORCPT ); Wed, 25 Aug 2021 04:54:33 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 0C18267357; Wed, 25 Aug 2021 10:53:46 +0200 (CEST) Date: Wed, 25 Aug 2021 10:53:45 +0200 From: "hch@lst.de" To: sasaki tatsuya Cc: "kbusch@kernel.org" , "axboe@fb.com" , "hch@lst.de" , "sagi@grimberg.me" , "linux-nvme@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] nvme: update keep alive interval when kato is modified Message-ID: <20210825085345.GA31419@lst.de> References: <526a1a756d6c4643b15b1b305cc32817@kioxia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <526a1a756d6c4643b15b1b305cc32817@kioxia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Any reason we can't just call this from nvme_passthru_end instead of inventing a new API? Right now the nvmet passthrough code never uses the underlying keep alive code, so it doesn't make a difference, but I expect we'll need more handling for passthrough commands like this, and we might also grow more users (e.g. the io_uring based passthrough).