Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        gregkh@linuxfoundation.org, straube.linux@gmail.com,
        Pavel Skripkin <paskripkin@gmail.com>
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/6] staging: r8188eu: add error handling of rtw_read16
Date:   Wed, 25 Aug 2021 11:48:05 +0200
Message-ID: <2227654.mbYB7oqmoa@localhost.localdomain>
In-Reply-To: <ab20fcd7-69a8-0530-7770-0e309178b0f0@gmail.com>
References: <cover.1629789580.git.paskripkin@gmail.com> <1665728.ljvk3MsED4@localhost.localdomain> <ab20fcd7-69a8-0530-7770-0e309178b0f0@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
Precedence: bulk

On Wednesday, August 25, 2021 10:22:16 AM CEST Pavel Skripkin wrote:
> On 8/25/21 7:35 AM, Fabio M. De Francesco wrote:
> > Dear Pavel,
> > 
> > Please note that if and when my patch "Use usb_control_msg_recv / send () in
> > usbctrl_vendorreq ()" will be merged, "if (res! = len)" will always evaluate 'true'
> > and usb_read16 () will always return -EIO even if usbctrl_vendorreq () succeeds.
> > 
> 
> Yep, thank you, but it depends on which series will go in first :)
> 
> There is a chance, that you will need to clean up this part, if mine 
> will be merged before yours
> 

Ha-ha ... I know that beautiful rule: whoever breaks must fix! 
However there should be another rule which says that
the old (me) takes precedence over the young (you) :-)

Seriously, thank you so much for your help and the "Reviewed by" 
tag on my work.

Regards,

Fabio
  
> With regards,
> Pavel Skripkin
>