Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp290085pxb; Wed, 25 Aug 2021 03:25:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdne5hqoe0cvNL4j/H9K8/X4b9NTdL5yaH4+BKSzFkimj5tUYu7sSIdDj5z4el/uJ8hVBL X-Received: by 2002:a17:907:2458:: with SMTP id yw24mr27684231ejb.326.1629887119111; Wed, 25 Aug 2021 03:25:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629887119; cv=none; d=google.com; s=arc-20160816; b=J0DuqUfTGTPT2nEA7uy6CJgc5cvl8K/3xfHDKonYhzl6tMeUqdsEBi2zbGVDElTPoH x+4dJ2Y+nM3mV9pSN/FN3zXSIQfiFdhsaOyjkVvQnTn5W3pvnGPt6cBbPu+ruBwmqwK5 TJGXA795OLX+w0JM4T6UPlP/SP5rsS0p4yrU54Xw6I2YXPaUctoGa7CBvLPAX7iEezE3 tYRgbaWBt7lgnEYzDln2oiYDsflKdZbWZDciqaSx2l+B91b/W1Gps1Z7KznH/MtXpsDN +Bd81Pkzx11BgcRHe+IYkAUMTz8JHm+E5KOD5hUc3stZSQ4bcTZm24j4Xqj0mbiaAa0q hnzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bqO0kxx913euEZZ2nvBvKlACnSEdhitR+P6iaet8hsY=; b=0GjuXVvV0UBV0HTkbTXCsPb/6xROOrMfN861gYOIROPv6In0kRMnWWvCDE7lp3S1ln OkrILwg0/uTwcomNH04f3qWYuNzONAnmmQSSjOlOuEQ3jJ66EbRkKsEx8Pr35LNviuBt ZFW1pQ/Lb09X2RRwvh0fbOjDN9+PTxJVVl10MymP0zJgFfoczO2G5V7U0MX9yCypvplk X86ek5Qi98FqRSwuSRFOq8o2QukOSFKIfGUJmV4VVzRUx2nrRfUOZXzCw4Im2gLQAN+z m0/Xsz3MSGOO14y4OZyVU3O/nX4qztgL1T3qZXmol10p6YQtJ8LUfgnEzMroFWSy61Hu UGQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ou+byWju; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 18si20970924ejj.476.2021.08.25.03.24.55; Wed, 25 Aug 2021 03:25:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ou+byWju; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238303AbhHYKYA (ORCPT + 99 others); Wed, 25 Aug 2021 06:24:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:37064 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237180AbhHYKX4 (ORCPT ); Wed, 25 Aug 2021 06:23:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1226E61212; Wed, 25 Aug 2021 10:23:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629886990; bh=b86R3glVuehPSGIAqorJ6zxBkwSAg6T+BgqVduzfR0M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ou+byWjuwVLazkRMsIMTDmFoPs+jHYuoG4b9Yr9eB+6Dt9hXFZaFup+oaYp5jzfw9 5ww4OypWXyvdeJlMmrT1p/V9KNoYl/6yfBni0zXiXJwZmICGrDknnxjAn2NlenBq42 Tu6YjEfKlPmOld1UJkGMykscZhgEX/BXk5P9BD0YX8E2DQw1/MryoNKVvTMr/b6XvL zOUhWzp/Hl32VSZUTquuXT3uPjiLOh7i4p5RL57gYR4XN1dxfT4NCtbTSW/QdETOWT GQblx1pAtggD0wFTGXB+hTAVRfA6i72gEYsYaBpSqW5EPKOHGpL2atsDEh0upzJBb1 3n0ivpJp6JUZg== From: Mark Brown To: Chunyan Zhang Cc: Mark Brown , LKML , Baolin Wang , linux-spi@vger.kernel.org, Orson Zhai , Chunyan Zhang , Luting Guo Subject: Re: [PATCH 1/3] spi: sprd: Pass offset instead of physical address to adi_read/_write() Date: Wed, 25 Aug 2021 11:22:37 +0100 Message-Id: <162988541636.8193.7086076559922137758.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210824070212.2089255-1-zhang.lyra@gmail.com> References: <20210824070212.2089255-1-zhang.lyra@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Aug 2021 15:02:10 +0800, Chunyan Zhang wrote: > From: Chunyan Zhang > > The register offset would be added a physical address base and then pass to > the function sprd_adt_read()/_write() each time before calling them. So we > can do that within these two functions instead, that would make the code > more clear. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/3] spi: sprd: Pass offset instead of physical address to adi_read/_write() commit: 5dc349ec131c6d40aeb2545064e285f0025fbb39 [2/3] spi: sprd: Make sure offset not equal to slave address size commit: 2b961c51f4d35c45116b21936b563cbb78fba540 [3/3] spi: sprd: fill offset only to RD_CMD register for reading from slave device commit: f674aacd5005184acf3cf7b851a299573d64fdd6 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark