Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968642AbWLETLk (ORCPT ); Tue, 5 Dec 2006 14:11:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S968644AbWLETLk (ORCPT ); Tue, 5 Dec 2006 14:11:40 -0500 Received: from mga03.intel.com ([143.182.124.21]:20822 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968642AbWLETLj (ORCPT ); Tue, 5 Dec 2006 14:11:39 -0500 X-ExtLoop1: 1 X-IronPort-AV: i="4.09,501,1157353200"; d="scan'208"; a="154170972:sNHT52302145" From: "Chen, Kenneth W" To: "'Ingo Molnar'" Cc: "Siddha, Suresh B" , "'Andrew Morton'" , "'Christoph Lameter'" , "linux-kernel" Subject: RE: [-mm patch] sched remove lb_stopbalance counter Date: Tue, 5 Dec 2006 10:57:12 -0800 Message-ID: <000001c7189f$2d129e10$ff0da8c0@amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AccYhCbDqnrS34O3RC+k6UjJYuGLBgAGkcfw In-Reply-To: <20061205154147.GA4865@elte.hu> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2180 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3410 Lines: 89 Ingo Molnar wrote on Tuesday, December 05, 2006 7:42 AM > * Chen, Kenneth W wrote: > > > but, please: > > > > > > > -#define SCHEDSTAT_VERSION 13 > > > > +#define SCHEDSTAT_VERSION 12 > > > > > > change this to 14 instead. Versions should only go upwards, even if > > > we revert to an earlier output format. > > > > Really? sched-decrease-number-of-load-balances.patch has not yet hit > > the mainline and I think it's in -mm for only a couple of weeks. I'm > > trying to back out the change after brief reviewing the patch. > > not a big issue but it costs nothing to go to version 14 - OTOH if any > utility has been updated to version 13 and is forgotten about, it might > break spuriously if we again go to 13 in the future. OK, with a reluctant agreement, I've changed the version to 14. [patch] sched: remove lb_stopbalance counter Remove scheduler stats lb_stopbalance counter. This counter can be calculated by: lb_balanced - lb_nobusyg - lb_nobusyq. There is no need to create gazillion counters while we can derive the value. Signed-off-by: Ken Chen Signed-off-by: Suresh Siddha Acked-by: Ingo Molnar --- ./include/linux/sched.h.orig 2006-12-05 07:56:11.000000000 -0800 +++ ./include/linux/sched.h 2006-12-05 07:57:55.000000000 -0800 @@ -684,7 +684,6 @@ struct sched_domain { unsigned long lb_hot_gained[MAX_IDLE_TYPES]; unsigned long lb_nobusyg[MAX_IDLE_TYPES]; unsigned long lb_nobusyq[MAX_IDLE_TYPES]; - unsigned long lb_stopbalance[MAX_IDLE_TYPES]; /* Active load balancing */ unsigned long alb_cnt; --- ./kernel/sched.c.orig 2006-12-05 07:56:31.000000000 -0800 +++ ./kernel/sched.c 2006-12-05 08:02:11.000000000 -0800 @@ -428,7 +428,7 @@ static inline void task_rq_unlock(struct * bump this up when changing the output format or the meaning of an existing * format, so that tools can adapt (or abort) */ -#define SCHEDSTAT_VERSION 13 +#define SCHEDSTAT_VERSION 14 static int show_schedstat(struct seq_file *seq, void *v) { @@ -466,7 +466,7 @@ static int show_schedstat(struct seq_fil seq_printf(seq, "domain%d %s", dcnt++, mask_str); for (itype = SCHED_IDLE; itype < MAX_IDLE_TYPES; itype++) { - seq_printf(seq, " %lu %lu %lu %lu %lu %lu %lu %lu %lu", + seq_printf(seq, " %lu %lu %lu %lu %lu %lu %lu %lu", sd->lb_cnt[itype], sd->lb_balanced[itype], sd->lb_failed[itype], @@ -474,8 +474,7 @@ static int show_schedstat(struct seq_fil sd->lb_gained[itype], sd->lb_hot_gained[itype], sd->lb_nobusyq[itype], - sd->lb_nobusyg[itype], - sd->lb_stopbalance[itype]); + sd->lb_nobusyg[itype]); } seq_printf(seq, " %lu %lu %lu %lu %lu %lu %lu %lu %lu %lu %lu %lu\n", sd->alb_cnt, sd->alb_failed, sd->alb_pushed, @@ -2579,10 +2578,8 @@ redo: group = find_busiest_group(sd, this_cpu, &imbalance, idle, &sd_idle, &cpus, balance); - if (*balance == 0) { - schedstat_inc(sd, lb_stopbalance[idle]); + if (*balance == 0) goto out_balanced; - } if (!group) { schedstat_inc(sd, lb_nobusyg[idle]); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/