Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Date:   Wed, 25 Aug 2021 10:49:14 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From:   yajun.deng@linux.dev
Message-ID: <01d7cf96c63c05097ef28789e2e27d6f@linux.dev>
Subject: Re: [PATCH linux-next] arm64: PCI: Introduce pcibios_free_irq()
 helper function
To:     "Will Deacon" <will@kernel.org>
Cc:     catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com
In-Reply-To: <20210825100500.GC24546@willie-the-truck>
References: <20210825100500.GC24546@willie-the-truck>
 <20210825071612.21543-1-yajun.deng@linux.dev>
Precedence: bulk

August 25, 2021 6:05 PM, "Will Deacon" <will@kernel.org> wrote:=0A=0A> [+=
Lorenzo]=0A> =0A> On Wed, Aug 25, 2021 at 03:16:12PM +0800, Yajun Deng wr=
ote:=0A> =0A>> Introduce pcibios_free_irq() to free irq in pci_device_pro=
be() and=0A>> pci_device_remove() that in drivers/pci/pci-driver.c.=0A> =
=0A> Please can you describe the problem you're solving?=0A> =0A=0Apcibio=
s_alloc_irq() will be called in pci_device_probe(), but there hasn't pcib=
ios_free_irq()=0Ain arm64 architecture correspond it. pcibios_free_irq() =
is an empty function in =0Adrivers/pci/pci-driver.c.So pcibios_alloc_irq(=
) and pcibios_free_irq() don't correspond.=0A=0A>> Signed-off-by: Yajun D=
eng <yajun.deng@linux.dev>=0A>> ---=0A>> arch/arm64/kernel/pci.c | 10 +++=
++++++-=0A>> 1 file changed, 9 insertions(+), 1 deletion(-)=0A>> =0A>> di=
ff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c=0A>> index 1=
006ed2d7c60..40da5aff4548 100644=0A>> --- a/arch/arm64/kernel/pci.c=0A>> =
+++ b/arch/arm64/kernel/pci.c=0A>> @@ -25,10 +25,18 @@=0A>> int pcibios_a=
lloc_irq(struct pci_dev *dev)=0A>> {=0A>> if (!acpi_disabled)=0A>> - acpi=
_pci_irq_enable(dev);=0A>> + return acpi_pci_irq_enable(dev);=0A> =0A> Th=
is means we'll now fail device probe if we can't enable the GSI. Is that =
a=0A> problem?=0A> =0AOh, It would be better that hasn't return.=0A> Will