Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 25 Aug 2021 15:51:59 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     kernel test robot <lkp@intel.com>, Larry.Finger@lwfinger.net,
        phil@philpotter.co.uk, gregkh@linuxfoundation.org,
        straube.linux@gmail.com, fmdefrancesco@gmail.com,
        clang-built-linux@googlegroups.com, kbuild-all@lists.01.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/6] staging: r8188eu: add error handling of rtw_read8
Message-ID: <20210825125159.GU1931@kadam>
References: <c59d5d850bf9aab208704182c83086609289cb9c.1629789580.git.paskripkin@gmail.com>
 <202108251911.Vwmzl4rI-lkp@intel.com>
 <9743e1ee-75f4-6231-427b-8c7f659fb252@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9743e1ee-75f4-6231-427b-8c7f659fb252@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (62.8.83.99) by JNAP275CA0047.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Wed, 25 Aug 2021 12:52:12 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bc3be84a-e92a-43e4-e8e6-08d967c72b77
X-MS-TrafficTypeDiagnostic: MWHPR10MB1903:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR10MB1903A2AE48B3007A78F0BF568EC69@MWHPR10MB1903.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3044;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: F4NkzW3FdMljpK8+VgUuYnhhEW5Afs14Hjz6dQZ+15QXEfIZowe3k9z1RZ3gfoD9dwAuUWqfz6ORk9y8SC9F9/K00iTH/3/VGqrK5WaLD8vFXxbCvJ2pJLnZC4yD2HjNS7wwzuLB8/3KdQSum0AVjRytBvc4iBZdOinK0cXsxkX66/Gm2fDzheHE/3pPeBEKITog4WD8a7wyni8h53vqvBAWXdcVrF2IuIMfi6FZByPE63NfwPypy20Eb6kx+I/wSovutAD76MqvydKKt2YP8M4jyscooIJOgbx0+sF+w0O632ndZAte1lYJav2p6IjmETHpuhHSrxCAuansjGBRA1HuVIDuxXM17sWIQc+W8nkE5EI72aRQgrMTuRTbAN1qr9TTL8HKqMEDFnfmi6yGd8x/LdYIEFnsV9tBtdox0VvOxLtff9lIotBO3y5lNWEeYo44QERJylVmX0hzNazotJ1snXwz1yXHbfKexyfFGdz8u1z3KcjehQimyPN/h/4tlgV+zD6epkcXEJDjskE34lndRY5DfNU/4lzTc2LE+TEEFj6t0BI52BIQmxFg6hb7doGMPnoj3ptu/+QPph3CIetnerCGWS1VETG67YJdkxD6483yGLnGZq7ZlJoMV3hIuuTF9P4WZea0QDjkI4BWvMByDgPJZGvwYxYibR/sC37X7uAdvhhPseCcVJaCuTaw2gP8TL5aqMZhB4tJLe42rNGBmdHwe5ncZh/rO5/het8koKXxcJ5P8MaSUk6cbWcfZ21fifGGxUUo9U6GAKEtH9rN6Ld1ERueOJHDyZUXoQToILC0ELt2Rx3CZ7r2hwUqbryOosFWdKLxsNHb+SLzVA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(136003)(366004)(396003)(346002)(966005)(478600001)(55016002)(5660300002)(2906002)(44832011)(9686003)(83380400001)(33656002)(956004)(66946007)(66476007)(66556008)(53546011)(7416002)(316002)(8676002)(6666004)(1076003)(52116002)(6496006)(8936002)(9576002)(86362001)(6916009)(4326008)(186003)(38100700002)(38350700002)(26005)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?B7KlDnRi+ywNZGu6cgoKEekQQ76dzot+YnHZN/L2k1GgeIPABnYHqNUg4EYg?=
 =?us-ascii?Q?fMT5RgHgITxBAw0ZXEhoEms7mlNdmMm46bh52QffKOOv7wrppvowo/42ni+A?=
 =?us-ascii?Q?0wWNRY56dzVA292ZS2CmjqyvpW6MKLwhQMwfskUEeRoB4qoKGJ12yQijZebv?=
 =?us-ascii?Q?LToFzXwtASoUhNZBbwUJgHq8bpWgUKjxWs6Ku29eE0kL+qxehXtx5T2A/2Ej?=
 =?us-ascii?Q?yp9S4snENMnnfWO9D/FVWSuz4Ey8Wf+X7ooHPaFfsBv3t8X+QznOsnUt9LUd?=
 =?us-ascii?Q?8tC4Ntv9wr4DiBLAxSE3ubBCWldEDXxZ+YYYbW1/rBMbUM8G5H9E+PFvDIwo?=
 =?us-ascii?Q?/+8VrYdpdgZ8LlM8A5TjqB2MsBZ4oLEwLmo52wXm3uMA/eMwGQto83kOfMMU?=
 =?us-ascii?Q?e7Xy3b7OS1LMaLfHfwhC3GRQOxa94g6IVMuKcg6xCQn7AR/qVTA6bmi0kdaG?=
 =?us-ascii?Q?wCpzE6OulzuF/osHFWOdLnAQ+00e8NxhZG4fs5FesQBbUHGhLZd1ZJigShl+?=
 =?us-ascii?Q?QZZCID7GEaaHQjNRD0k8TC3HTTF5JkStmXaEwxyw2H3E9CHersBp6oaSQmzO?=
 =?us-ascii?Q?TgqFMUAVii3qf+4X2WIvI7PIEY4ZHAvJVo6a9oxtzc1YDtfly9t9dtv5hbSm?=
 =?us-ascii?Q?RWmZEJA4r1M9s8/3Hq3VE2lX9xn/opvP3/Gdh37AsBg86WqcSbS87S5Y1YBI?=
 =?us-ascii?Q?gCsxqIZ0klcNAlIq22JzdSc7nTxz8DPxjQULGizYvNe8EEC9248HTsilwei/?=
 =?us-ascii?Q?I/rKxQJFqfnLrY9QPGVPmgTlVVUfCsxtP9WtwXnpef78nQxfh7tOYrY+Wea4?=
 =?us-ascii?Q?51P7klGeQQ9CrC6jA/d8F89b6RBVrzkeimi2wdyMaG5rvuSxJ86EKLX4MXPb?=
 =?us-ascii?Q?q8Wo/pSFCwxMx/VEv9YoctFbVBAPM1xE7jcawaXh4jETi9iaxTXZmdrbHUEw?=
 =?us-ascii?Q?cXKQF4vWMl8vemY+uEMCGLNLm/1HcnrOOXpPrf31Aju9jO//fJ+PuLrCZqlw?=
 =?us-ascii?Q?boayhht/qtBEXfix6pP1cITXez3prdjAB7avmfkBNJDOrD34YNx7Cu8ycnkT?=
 =?us-ascii?Q?HH/mku5izYtbTLKqhpbiGP7072gusATMVXm7NfGPXEnUfbhvjn8kgH4aWmtk?=
 =?us-ascii?Q?XV5oo0DjxwsvCpp0dbG/Ke2KAUcqVX6Hf3nLRQBzp6Um6NK8OvdgQfrZ6XLk?=
 =?us-ascii?Q?MJMIReKf6IV2gergvSYdxVVtRiAUzVNMSXsxun9X7SNh0BYisnHBly8ZaJVk?=
 =?us-ascii?Q?meSz+c8ngVAZbLiYWr7QEoE4z+qUOxjLrUDVSvbpl70v5pHvUr66y2FbHliA?=
 =?us-ascii?Q?gPlRjJEv02ZZ/JLVa28sDmO/?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc3be84a-e92a-43e4-e8e6-08d967c72b77
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2021 12:52:17.9573
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zdL+JWcXQzcFy6AHCKJUWewQRhrcEXs1J4qAjC0PSwQcxbldOOL5g0TwfMT/fbywyUwxKL1Reo8BzVXxRiVLAUbjHZblIj4ti0USGmK9FjY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1903
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10086 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0
 mlxlogscore=999 bulkscore=0 mlxscore=0 adultscore=0 malwarescore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2108250077
X-Proofpoint-ORIG-GUID: wG3t9nL-3LS_3D1BR1puCyovgWsEaK_U
X-Proofpoint-GUID: wG3t9nL-3LS_3D1BR1puCyovgWsEaK_U
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 25, 2021 at 03:17:06PM +0300, Pavel Skripkin wrote:
> On 8/25/21 3:05 PM, kernel test robot wrote:
> > Hi Pavel,
> > 
> > Thank you for the patch! Yet something to improve:
> > 
> > [auto build test ERROR on staging/staging-testing]
> > 
> > url:    https://github.com/0day-ci/linux/commits/Pavel-Skripkin/staging-r8188eu-remove-read-write-_macreg/20210824-162756
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 093991aaadf0fbb34184fa37a46e7a157da3f386
> > config: arm-buildonly-randconfig-r001-20210825 (attached as .config)
> > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project ea08c4cd1c0869ec5024a8bb3f5cdf06ab03ae83)
> > reproduce (this is a W=1 build):
> >          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >          chmod +x ~/bin/make.cross
> >          # install arm cross compiling tool for clang build
> >          # apt-get install 11.1.1
> >          # https://github.com/0day-ci/linux/commit/d4e4bbed4e59df37967086f60fe92cb1b4504d37
> >          git remote add linux-review https://github.com/0day-ci/linux
> >          git fetch --no-tags linux-review Pavel-Skripkin/staging-r8188eu-remove-read-write-_macreg/20210824-162756
> >          git checkout d4e4bbed4e59df37967086f60fe92cb1b4504d37
> >          # save the attached .config to linux build tree
> >          mkdir build_dir
> >          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/staging/r8188eu/
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All errors (new ones prefixed by >>):
> > 
> > > > drivers/staging/r8188eu/hal/usb_halinit.c:2022:3: error: expected expression
> >                     u8 tmp;
> >                     ^
> >     1 error generated.
> > 
> > Kconfig warnings: (for reference only)
> >     WARNING: unmet direct dependencies detected for QCOM_SCM
> >     Depends on (ARM || ARM64) && HAVE_ARM_SMCCC
> >     Selected by
> >     - ARM_QCOM_SPM_CPUIDLE && CPU_IDLE && (ARM || ARM64) && (ARCH_QCOM || COMPILE_TEST && !ARM64 && MMU
> > 
> > 
> 
> We need to fix Kconfig, ok, I will take a look at it later
> 

This is not related to your patch.  Ignore it.


> > vim +2022 drivers/staging/r8188eu/hal/usb_halinit.c
> > 
> 
> >    2020		case HW_VAR_BCN_VALID:
> >    2021			/* BCN_VALID, BIT(16) of REG_TDECTRL = BIT(0) of REG_TDECTRL+2, write 1 to clear, Clear by sw */
> > > 2022				u8 tmp;
> 
> Hm, I don't know anything about ARM compilers, so should I wrap this code
> block with {}?

Yep.

> 
> My local gcc 11.1.1 (x86_64) does not produce any warnings/errors
> 

You should figure out whats up with that because it shouldn't compile
with the gcc options that the kernel uses.

regards,
dan carpenter