Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 25 Aug 2021 16:34:32 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     kernel test robot <lkp@intel.com>, Larry.Finger@lwfinger.net,
        phil@philpotter.co.uk, gregkh@linuxfoundation.org,
        straube.linux@gmail.com, fmdefrancesco@gmail.com,
        clang-built-linux@googlegroups.com, kbuild-all@lists.01.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/6] staging: r8188eu: add error handling of rtw_read8
Message-ID: <20210825133432.GW1931@kadam>
References: <c59d5d850bf9aab208704182c83086609289cb9c.1629789580.git.paskripkin@gmail.com>
 <202108251911.Vwmzl4rI-lkp@intel.com>
 <9743e1ee-75f4-6231-427b-8c7f659fb252@gmail.com>
 <20210825125159.GU1931@kadam>
 <bd50c00e-1814-dc32-36cf-73cf58123201@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bd50c00e-1814-dc32-36cf-73cf58123201@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (62.8.83.99) by JNXP275CA0039.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:18::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.18 via Frontend Transport; Wed, 25 Aug 2021 13:34:45 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cba8cc5a-bbc8-4a96-8a79-08d967cd1d7b
X-MS-TrafficTypeDiagnostic: CO1PR10MB4721:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO1PR10MB4721F36F290F2F71DF2223B58EC69@CO1PR10MB4721.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:370;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Fw2e3d7A7TP9pbZqTVDsKLX3RiGF99uEjVo5muTy7zZSAqMDGNJBwppbSHkEY1w5lsi/A8/CB9ArGnGxBW5LCO5nNU3IZDcHgl1uRjlOvI2q+vh6Rl1gIrosXmyVG+q+1nhN8G5K++QJf0jCbj7prAdBnFmwr0DLNHqTZUoKo+vIBoH2rB1xuRAvLvleqRURuWaiYeQBTeCJ6JcaMZT1Dtzs8KqiH3A0f/rtqS8sYsk3Y5FjDUdPt+P7WbUQ9UoTxsmlxC1mV23/4wkyQnwtdCmnchoZl2wFWahAz1FB7mEnQDmmcF3iVVyeCDmXb6eiMjFNGDBQLWD9FAVCYrzBkrAFbDJDGAFFlpDZL3CzNDw9nV0iyJ/qvKEtd5Lyau3ijieG2FE7eEW/qlFep8w+6Cu638MGx58zEscodyO/JSAkY3H3XOu7bYLiEUSgJD4MQlUwvNYODkJdLEpFO5MwYZG+lsxcQIA/dVYyk3oMcw9JmWEvITmj8qEHGHo060bh2E3uN6qGrmH1rjNVxloVABeJ0BuBfnbjKcVxWsvfZJdWl7YYHmpDktVFp4lRhBZwOGsewe34JjnRBAvUUsaVB1+JtOWOgB3tI/ncqv3Ui/5vRPilHrC2CWyTvrODRfGU9ssGy/hNFNCbQfxnhIqsP+GENzMMNe4O+YaNuJXjAz0f6MNnRgZ1xJg0gWpkM/5oFxjGG+SL4e0SzLM47FnZVQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(136003)(366004)(39860400002)(376002)(346002)(66946007)(1076003)(6916009)(8676002)(2906002)(6666004)(66476007)(86362001)(316002)(956004)(38100700002)(66556008)(83380400001)(26005)(9686003)(9576002)(5660300002)(186003)(55016002)(7416002)(4326008)(8936002)(33716001)(6496006)(33656002)(478600001)(38350700002)(52116002)(44832011);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GK4ltSOpsKpcqmRMT5QIbd75o6cD0rpEJrv4GzEeSI4KWvkbL1T/+kLsTdfE?=
 =?us-ascii?Q?r33Fg5mQZFT4x+S7IlZAE3RiPfF7eiJ3A4Vi+mC1P+kld2ZTa962N1H5jN/m?=
 =?us-ascii?Q?47e26r0ru0+ox+P2OF/HSJmZrDMxGEVDk5XdmEGzYYTz3hoQDZ+1MKn0OW8l?=
 =?us-ascii?Q?JKGljI3xQkFXBH9ylIyF/olMZrqEmb7FGqWpWW95hxbGfFP4uzV7DA0Sm/Hd?=
 =?us-ascii?Q?0tmg0hPk4NL+JGK1d402MugDC5v1y8MTg/2dlN23r2H85wnf8DVl8uy5hf5k?=
 =?us-ascii?Q?+BgYT3OIqmqy8uDZxjizc90n8fJn4smOQyI8CVZO1rV7Sb5PpnJLf/oEHKa6?=
 =?us-ascii?Q?cX9Nf2Y9JhwxvV1bafnEjX1JGc6OX8Y24LBweXRSi+1Wt/joOrLBRD3/NPgL?=
 =?us-ascii?Q?Tw3uGQ3JYs4EzaihJFx5i21F/UqPDbcvffSa/0C29sDfcYDAgLQfphGeT8Jg?=
 =?us-ascii?Q?x/+qAtlN9LW174NgPYYXQDk6taCJ5JrhiBXIjFtB01ncGXUh/tGeeWTz/vxz?=
 =?us-ascii?Q?TUE4uN7MNKvXPSyXihsuFDAT7Ezh58GTtddjpzI/HLiV4r0LnV8Ou0Ds28LM?=
 =?us-ascii?Q?igNTSPYlAmW1XMGwQ4/8+aBiFlGZo80R/1dyYIULz7VLIvuPBMlmwbf7ygJc?=
 =?us-ascii?Q?k1uRHmEl50XQh30y9VsXcswCIRU9gmLMeNquUX/4UiQY7V7snVGWJQO715Q2?=
 =?us-ascii?Q?z7mZeXN+Iwg3RG7+hfneOnx6/KLkXgIgVjNQKXnBGmCKGPa5cMI5QgweAIrM?=
 =?us-ascii?Q?UhkVyqQ/ucnIGn5wNBM0TTnFvcqVZ48lvsTuf+TTL3ZNL68AGrbDlvYGAEqQ?=
 =?us-ascii?Q?2GkXtq1kdAq45gMUuDxy9B/s1Dz7EewSPJP59SAu88/M1icgH4wdnRYSdarc?=
 =?us-ascii?Q?YNkPrCenXF55ZcFSZsPycHR7CasDSEJtZojAnze8lWlnHSSWQLZhN+a4ZsS9?=
 =?us-ascii?Q?2VfKI6yqPO2bDjWHKa2AGj9XIahTGuG3VgVCehpVY3q007zuJ6dYtoURmgAW?=
 =?us-ascii?Q?MUfLYZz0h4WyN1VsJOWu4yOzsf7Hu/uhDdwz2BWLt4MkCAEHvQ03wlruDmXL?=
 =?us-ascii?Q?/3Kt5Osg2KMsQ33u7AqHBljX4+yGclrHeEGCiyIbWtd8ovtxo6qTwVPkn6yb?=
 =?us-ascii?Q?+vOM4tFc2jSrs0T0DzNrbFcUY3JyolZyxiJIZReHsEnfctDYz3RxvAmTtBw/?=
 =?us-ascii?Q?gBUNq7mCxtpnVkw6Lm1PMzzpZRpF1Rg+cj6xb2xT0t0K3ma2cs3avKhgC+In?=
 =?us-ascii?Q?Ry6h9pBPC+knTpAlrOvWFZt2aw/aSAKw7FSVZ+hv2G7wCGDl8qJaN3qE9BRk?=
 =?us-ascii?Q?TZ8pzd4ab1IgbvYY0Gv8BKQ1?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cba8cc5a-bbc8-4a96-8a79-08d967cd1d7b
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2021 13:34:51.5054
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SJmetYI4q+k1TI+HUazH8SIbE/VdXedWHUDY8FJZP9IWN8f8lCsTq+htaxM5pKgFlzKiL5aFZLbUDJyuYJPm1U6NXehDpMjBxHroHhzIqFE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4721
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10086 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0
 mlxlogscore=999 bulkscore=0 mlxscore=0 adultscore=0 malwarescore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2108250081
X-Proofpoint-ORIG-GUID: c8Pxbh9qBWHgozzwTncyy8g2lfjsSw8O
X-Proofpoint-GUID: c8Pxbh9qBWHgozzwTncyy8g2lfjsSw8O
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 25, 2021 at 04:02:26PM +0300, Pavel Skripkin wrote:
> > This is not related to your patch.  Ignore it.
> > 
> > 
> > > > vim +2022 drivers/staging/r8188eu/hal/usb_halinit.c
> > > >
> > > 
> > > >    2020		case HW_VAR_BCN_VALID:
> > > >    2021			/* BCN_VALID, BIT(16) of REG_TDECTRL = BIT(0) of REG_TDECTRL+2, write 1 to clear, Clear by sw */
> > > > > 2022				u8 tmp;
> > > 
> > > Hm, I don't know anything about ARM compilers, so should I wrap this code
> > > block with {}?
> > 
> > Yep.
> > 
> > > 
> > > My local gcc 11.1.1 (x86_64) does not produce any warnings/errors
> > > 
> > 
> > You should figure out whats up with that because it shouldn't compile
> > with the gcc options that the kernel uses.
> > 
> 
> AFAIK, at least 2 guys except me in this CC list compiled my series without
> errors/warnings. Maybe, staging tree is missing some Makefile updates?
> 
> 
> I'll resend series this evening anyway, but this is strange....

Hm...  In my version of GCC the error is:

drivers/staging/r8188eu/hal/usb_halinit.c:1870:3: error: a label can only be part of a statement and a declaration is not a statement

That's a different error from what I was expecting.  It's caused by
having a declaration directly after a case statement.  The warning that
I was expecting was from -Wdeclaration-after-statement and it looks
like this:

warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]

You really should try investigate why this compiles for you because
something is going wrong.  It should not build without a warning.

regards,
dan carpenter