Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] nvme: update keep alive interval when kato is modified
To:     "hch@lst.de" <hch@lst.de>,
        sasaki tatsuya <tatsuya6.sasaki@kioxia.com>
Cc:     "kbusch@kernel.org" <kbusch@kernel.org>,
        "axboe@fb.com" <axboe@fb.com>,
        "sagi@grimberg.me" <sagi@grimberg.me>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <526a1a756d6c4643b15b1b305cc32817@kioxia.com>
 <20210825085345.GA31419@lst.de>
From:   Hannes Reinecke <hare@suse.de>
Message-ID: <2fc5b98a-b397-3be1-1957-986e8b6aa732@suse.de>
Date:   Wed, 25 Aug 2021 17:51:25 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20210825085345.GA31419@lst.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 8/25/21 10:53 AM, hch@lst.de wrote:
> Any reason we can't just call this from nvme_passthru_end instead
> of inventing a new API?  Right now the nvmet passthrough code never
> uses the underlying keep alive code, so it doesn't make a difference,
> but I expect we'll need more handling for passthrough commands like
> this, and we might also grow more users (e.g. the io_uring based
> passthrough).
> 
Yeah, we'll need that anyway if and when hostid becomes settable.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer