Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968691AbWLEUkz (ORCPT ); Tue, 5 Dec 2006 15:40:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S968694AbWLEUky (ORCPT ); Tue, 5 Dec 2006 15:40:54 -0500 Received: from omx2-ext.sgi.com ([192.48.171.19]:55835 "EHLO omx2.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S968691AbWLEUkx (ORCPT ); Tue, 5 Dec 2006 15:40:53 -0500 Message-ID: <4575D951.3010705@sgi.com> Date: Tue, 05 Dec 2006 14:40:49 -0600 From: Michael Reed User-Agent: Thunderbird 1.5.0.8 (X11/20060911) MIME-Version: 1.0 To: ltuikov@yahoo.com CC: Andrew Morton , linux-scsi , linux-kernel Subject: Re: Infinite retries reading the partition table References: <520003.85125.qm@web31807.mail.mud.yahoo.com> In-Reply-To: <520003.85125.qm@web31807.mail.mud.yahoo.com> X-Enigmail-Version: 0.94.1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 600 Lines: 18 Luben Tuikov wrote: ...snip... > This statement in scsi_io_completion() causes the infinite retry loop: > if (scsi_end_request(cmd, 1, good_bytes, !!result) == NULL) > return; The code in 2.6.19 is "result==0", not "!!result", which is logically the same as "result!=0". Did you mean to change the logic here? Am I missing something? Mike - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/