Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp745722pxb; Wed, 25 Aug 2021 14:06:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRSEo54ckynSJ2VQ5MxYPO6vJWjaqiEhlmyAorO6ZyeUzlDeR+UUuIgQfWTWOjYalNGQwX X-Received: by 2002:a05:6602:d9:: with SMTP id z25mr369864ioe.154.1629925590265; Wed, 25 Aug 2021 14:06:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629925590; cv=none; d=google.com; s=arc-20160816; b=PCA7OgegQECTvPy0HLWl06SmsRgq58/xTHgLuxv3JlCaFLFilH+hZVZ5DUqlONo7sF G6368/VRqttrjPnm7FipjifGKSRI/7EyA5x3AFfjfVon1siY9F+IDS3m+xVgT/KmIxQC uZg8zZepH4kBcPQgaozP5ydCi1ClyymueSsgEawUR9/tUP9ABk3E7w22owEqD38LarJK HVwmOMUzIkD2PI7NFw+T7esr37YsWjm7dOJtTjq515EtqqaiNnom312C1POLvqnonnxc QS6us6GmhGPTKs7mqcds2NyyKdTo1l75yEaccZaMDA0T6o32g3gBt4KmFGQKBdeAiAm0 gSMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Rm7f85yoW9A6THgwsdrwFLIXQBDyyGySyGos9LgqPAA=; b=Th8YVLMtbUNA5dtWlSw1Ea7YouaP05VHG6TeVpIk8tg6ouppj79AQRum3PyznjKcvW N82+HVSpA1Q79bDg/yPO085Nn2Dkm6fcbm7Z5Je1jB07x19Gji2/kzA9a18GrFPzREUX p0EOW9g6PZF8jkfExdPri3SYJdMNrX4aHSutaL//kT2RY4Yy56LQxZ6FmMkS5IgTzpya PNrbkgTJjIOsaVGHqjwW9BRtHX01IvbEqyLxk2UCRJFd2tfxoblOJ9B1sjiKI0LWe8+K cWXmrp16ixbrETs2muGtCIhmJ1PAET2HGNQ/lsv7kZ8gCH54EpwbYJAi8qMMNSv8Z4ha kfoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p8si966280ilh.18.2021.08.25.14.06.19; Wed, 25 Aug 2021 14:06:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235469AbhHYSgl (ORCPT + 99 others); Wed, 25 Aug 2021 14:36:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233928AbhHYSgk (ORCPT ); Wed, 25 Aug 2021 14:36:40 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22E40C061757 for ; Wed, 25 Aug 2021 11:35:54 -0700 (PDT) Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIxkU-0005eY-Nq; Wed, 25 Aug 2021 20:35:42 +0200 Received: from ore by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mIxkS-0003S3-Oq; Wed, 25 Aug 2021 20:35:40 +0200 From: Oleksij Rempel To: "David S. Miller" , Jakub Kicinski , Andrew Lunn , Heiner Kallweit , Russell King Cc: kernel test robot , Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net v1 1/1] net: usb: asix: ax88772: fix boolconv.cocci warnings Date: Wed, 25 Aug 2021 20:35:38 +0200 Message-Id: <20210825183538.13070-1-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot drivers/net/usb/asix_devices.c:757:60-65: WARNING: conversion to bool not needed here Remove unneeded conversion to bool Semantic patch information: Relational and logical operators evaluate to bool, explicit conversion is overly verbose and unneeded. Generated by: scripts/coccinelle/misc/boolconv.cocci Fixes: 7a141e64cf14 ("net: usb: asix: ax88772: move embedded PHY detection as early as possible") Reported-by: kernel test robot Signed-off-by: kernel test robot Reviewed-by: Oleksij Rempel --- drivers/net/usb/asix_devices.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c index f6f3955a3a0f..dc87e8caf954 100644 --- a/drivers/net/usb/asix_devices.c +++ b/drivers/net/usb/asix_devices.c @@ -754,7 +754,7 @@ static int ax88772_bind(struct usbnet *dev, struct usb_interface *intf) return ret; priv->phy_addr = ret; - priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10 ? true : false); + priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10); asix_read_cmd(dev, AX_CMD_STATMNGSTS_REG, 0, 0, 1, &chipcode, 0); chipcode &= AX_CHIPCODE_MASK; -- 2.30.2